Rockbox

Tasklist

FS#5615 - settings.h modification for easier remote implementation

Attached to Project: Rockbox
Opened by Martin Scarratt (mmmm-) - Thursday, 29 June 2006, 12:33 GMT
Last edited by Martin Scarratt (mmmm-) - Thursday, 29 June 2006, 13:31 GMT
Task Type Patches
Category Remote
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Version 3.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Small change defining remote buttons in settings.h
This task depends upon

Closed by  Peter D'Hoye (petur)
Saturday, 01 July 2006, 00:22 GMT
Reason for closing:  Accepted
Additional comments about closing:  check the committed code to see how it\'s supposed to be done. If not clear, read irc log of 20060701 starting 01:36 ;)
Comment by Peter D'Hoye (petur) - Thursday, 29 June 2006, 22:23 GMT
this patch has no functionality, right?
It just creates defines that are nowhere used...

or do I miss something?
Comment by Martin Scarratt (mmmm-) - Friday, 30 June 2006, 08:14 GMT
Yep...that's right...
It's just that in the other patches for remote support I'll use it, so it would make my life easier creating patches and testing if it was already committed.
Comment by Peter D'Hoye (petur) - Friday, 30 June 2006, 08:18 GMT
I think it would be better to include this with the first patch that actually uses them
Comment by Martin Scarratt (mmmm-) - Friday, 30 June 2006, 08:34 GMT
Oh bugger...but then I have to change code, add this patch, test the code remove the patch and then make a new patch! my fingers are getting sore! ;)

Also the patches I'm making on flyspray don't work unless you install this one too. I could include it in every patch but then I would have to change them all as soon as one is committed! Life is hard eh?
Comment by Peter D'Hoye (petur) - Friday, 30 June 2006, 08:47 GMT
submit a simple patch that includes this one, and continue once it is committed?
*maybe* I have a bit of time to look at it sunday evening....

Loading...