Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5627 - H100 grayscale bitmap fix

Attached to Project: Rockbox
Opened by Andreas Mattsson (AM) - Sunday, 02 July 2006, 21:02 GMT+2
Last edited by Alex Parker (BigBambi) - Saturday, 05 June 2010, 18:44 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type Iriver H100 series
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Updates the iriver H100 LCD-driver so as to make the handling of 4-gray bitmaps analogous to its monochrome bitmap-handling. This means the white pixels of an image are no longer drawn on top of other images.
Useful for WPS as it allows you to place grayscale bitmaps behind other bitmaps and properly display text on top of grayscale bitmaps. This was previously not possible.

Changes were made to the lcd_bitmap_part function in lcd-h100.c and the function setblock was removed as it no longer was used.
I'd like it if this was included in CVS.
(application/octet-stream)    lcd-h100_4gray.patch (2 KiB) 
 firmware/drivers/lcd-h100.c |   52 ++++++++++++++++----------------------------
 1 file changed, 20 insertions(+), 32 deletions(-)

This task depends upon

Closed by  Alex Parker (BigBambi)
Saturday, 05 June 2010, 18:44 GMT+2
Reason for closing:  Out of Date
Comment by Andreas Mattsson (AM) - Monday, 03 July 2006, 10:32 GMT+2
Ok, I've now applied the same fix to the iPod 4-gray driver (lcd-2bit-horz.c). Here's the iPod patch and combined (iriver+iPod) batch.
(application/octet-stream)    lcd-ipod_4gray.patch (1.6 KiB) 
 firmware/drivers/lcd-2bit-horz.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

(application/octet-stream)    lcd_4gray.patch (4.5 KiB) 
 firmware/drivers/lcd-2bit-horz.c |   16 +++++--------
 firmware/drivers/lcd-h100.c      |   46 ++++++++++++++-------------------------
 2 files changed, 24 insertions(+), 38 deletions(-)

Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 03 July 2006, 10:46 GMT+2
OK, so this patch makes white pixels transparent?

I would prefer if the grayscale drivers implemented the same mask color approach as the color targets. However, this is definitely a step in the right direction. Could you please submit a new patch without the MSDOS newlines and the TAB characters?
Comment by Andreas Mattsson (AM) - Monday, 03 July 2006, 11:31 GMT+2
I didn't really look into how color targets handle transparency. My main goal was to make it so that monochrome vs grayscale bitmaps could work interchangably with the same behaviour thinking it would make sense for you to for example be able to swap out the monochrome bitmaps of a WPS for grayscale versions without everything getting screwed up...

Did a find-and-replace for tab characters and ran dos2unix for the 2 source files. Here are the new patches.
(application/octet-stream)    lcd_4gray.patch (4.4 KiB) 
 firmware/drivers/lcd-2bit-horz.c |   12 ++++------
 firmware/drivers/lcd-h100.c      |   46 ++++++++++++++-------------------------
 2 files changed, 22 insertions(+), 36 deletions(-)

(application/octet-stream)    lcd-h100_4gray.patch (2.8 KiB) 
 firmware/drivers/lcd-h100.c |   46 ++++++++++++++++----------------------------
 1 file changed, 17 insertions(+), 29 deletions(-)

(application/octet-stream)    lcd-ipod_4gray.patch (1.6 KiB) 
 firmware/drivers/lcd-2bit-horz.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 03 July 2006, 11:47 GMT+2
Have you made any performance tests other than the WPS, like some of the plugins?
Comment by Andreas Mattsson (AM) - Monday, 03 July 2006, 12:32 GMT+2
Ok, I'm a total rockbox dev n00b (this is my first patch) so by performance testing what exactly do you mean? Is there some debug mode to show framerates or something I should use? I've done a search for all source files that use lcd_bitmap(), lcd_bitmap_part(), screen->bitmap() or screen->bitmap_part() and have tried out all the plugins that do - noticing no difference. But is there any way to get actual performance figures for comparison?
Comment by Andreas Mattsson (AM) - Monday, 03 July 2006, 12:37 GMT+2
only limited testing on the iPod though as I don't have one myself... (only tested using simulator)
Comment by Andreas Mattsson (AM) - Thursday, 20 July 2006, 15:42 GMT+2
updated to CVS
(application/octet-stream)    lcd_4gray.patch (4.7 KiB) 
 firmware/drivers/lcd-h100.c      |   51 +++++++++++++--------------------------
 firmware/drivers/lcd-2bit-horz.c |   17 ++++---------
 2 files changed, 24 insertions(+), 44 deletions(-)

(application/octet-stream)    lcd-h100_4gray.patch (2.9 KiB) 
 firmware/drivers/lcd-h100.c |   51 +++++++++++++++-----------------------------
 1 file changed, 18 insertions(+), 33 deletions(-)

(application/octet-stream)    lcd-ipod_4gray.patch (1.7 KiB) 
 firmware/drivers/lcd-2bit-horz.c |   17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

Comment by Andreas Mattsson (AM) - Wednesday, 16 August 2006, 10:47 GMT+2
updated to CVS (wont bother making separate patches for h100 and ipod anymore, this one includes both)
(application/octet-stream)    lcd_4gray.patch (4.5 KiB) 
 firmware/drivers/lcd-2bit-horz.c |   17 ++++---------
 firmware/drivers/lcd-h100.c      |   48 +++++++++++++--------------------------
 2 files changed, 23 insertions(+), 42 deletions(-)

Comment by Jonas Häggqvist (rasher) - Sunday, 14 December 2008, 21:03 GMT+2
I'm pretty sure this is both horribly out of date, and unneeded, since I don't think there's a need for this because of viewports/backgrounds etc: "Useful for WPS as it allows you to place grayscale bitmaps behind other bitmaps and properly display text on top of grayscale bitmaps. This was previously not possible."

Loading...