Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5653 - Increase disk spindown time in JPEG-viewer

Attached to Project: Rockbox
Opened by PaulJam (PaulJam) - Wednesday, 12 July 2006, 21:14 GMT+2
Last edited by Peter D'Hoye (petur) - Friday, 20 October 2006, 01:32 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

While in most situations a short spindown time of the harddrive is better, it is in my opinion not good in the JPEG-viever plugin. I use the default spindown time of 5 seconds and if use the slideshow feature (with the default speed) the harddrive will always spin down a moment before the next Picture loads, this is very annoying (because of the clicking and the longer time the loading screen is shown), propably increases the powerconsumption and i could imagine that it stresses the hardware more then necessary. The same situation happens in manual mode when i look at a pictue too long (more then 5 seconds).

What i would like to see is an additional option in the menu of the JPEG-viewer that allows to set a different spindown time than the system setting:

Disk spindown => Increase spindown time [0..60,always]

The setting should be remembered by the JPEG-viewer (the slideshow timeout should be remembered too).
This task depends upon

Closed by  Peter D'Hoye (petur)
Saturday, 21 October 2006, 16:48 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Didn\'t use supplied patch but got some inspiration from it ;)
Comment by Jonas Häggqvist (rasher) - Wednesday, 12 July 2006, 21:32 GMT+2
How about simply making the JPEG-viewer set the spindown to min(slideshow-delay + 1, some_sensible_constant)? This won't work when browsing regular images of course, but at least it'd avoid having to have this configuration setting inside the jpeg viewer.
Comment by Peter D'Hoye (petur) - Thursday, 13 July 2006, 01:18 GMT+2
I wouldn't want spindown times to grow big when setting bigger slideshow times. So why not set spindown time to 0 in slideshow mode and have it spin down immediately after loading.
Comment by Hristo Kovachev (bger) - Thursday, 13 July 2006, 12:42 GMT+2
IMHO setting the spindown time to 0 (btw, the min spindown time is 3 sec) isn't a good idea. That means 100 spin up/spindown cycles for a slideshow of 100 pictures, and i don't think the hard disk drives in the players will like it...
OTOH it will be worse if you drop the unit with disk spinning while looking at some pictures ...
Comment by Peter D'Hoye (petur) - Thursday, 13 July 2006, 13:12 GMT+2
I know what you mean, it's just that keeping the drive spinning will eat battery big time, so maybe it needs both: if slideshow time > n seconds shut down disk immediately, else keep it running
Comment by Alistair Marshall (amar) - Friday, 14 July 2006, 17:59 GMT+2
could you cache more than one picture at a time/would this help?
Comment by Gwen Roelants (Adion) - Sunday, 20 August 2006, 21:04 GMT+2
I just tried to look into this, but unfortunately it appears to be impossible to set the spindown time from within a plugin.
(I think the function I need is ata_spindown )
I don't know if there's another way to edit the spindown time...
Comment by Gwen Roelants (Adion) - Monday, 21 August 2006, 10:30 GMT+2
I've added ata_spindown to plugin.h, and I've changed jpeg.c to use it.
When slideshow is enabled, and the player would spindown for less than 10 seconds between pictures, then the spindowntime is set to the slideshowtime + 2 seconds.
When slideshow is enabled, but the slideshow time is more than 10 seconds longer than the current spindown time, then the spindown time is set to minimum (3 seconds) since else it would spindown after a while anyway. It is only set to 3 seconds if no mp3 is playing though.
In all other cases, the spindown time is restored to the user setting.
   jpeg_patch.txt (4.7 KiB)

Loading...