Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5677 - Remove current track from current playlist.

Attached to Project: Rockbox
Opened by David Rothenberger (drothenberger) - Tuesday, 18 July 2006, 15:59 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Saturday, 04 June 2011, 23:29 GMT+2
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch adds a "Remove from current" option to the playlist menu. This option
- Removes the current track from the playlist.
- Saves the playlist unless the playlist is dynamic.
- Skips to the next track. (*)

* If the track is the last track in the playlist, Repeat is not set to All,
and the playlist was not saved because it is dynamic or an error occurred,
the track is not skipped so it's easier to save the playlist with the change.

I'm not sure whether saving the playlist automatically is a good idea or not.
I like it because I often invoke this option from the remote while driving and
it's difficult to save the playlist the normal way under those circumstances.
Also, I rarely remove tracks from the playlist. However, if you were planning to
remove many tracks, saving after each removal is a big waste of battery. Comments
on this aspect (or any aspect) of the patch would be appreciated.
   remove-from-playlist.patch (3.1 KiB) 
 apps/tree.c            |   15 +++++++++++----
 apps/lang/english.lang |   14 ++++++++++++++
 apps/onplay.c          |   38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Saturday, 04 June 2011, 23:29 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  No activity since years. Plus, you can remove tracks from the playlists context menu these days.
Comment by David Rothenberger (drothenberger) - Tuesday, 18 July 2006, 16:33 GMT+2
Updated patch that applies to CVS HEAD after the playlist catalog was committed.
   remove-from-playlist.patch (3 KiB) 
 apps/tree.c            |   15 +++++++++++----
 apps/lang/english.lang |   15 ++++++++++++++-
 apps/onplay.c          |   38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+), 5 deletions(-)

Comment by David Rothenberger (drothenberger) - Friday, 21 July 2006, 01:20 GMT+2
Updated for CVS HEAD. Also, verified it compiles for all targets and sim targets.
   remove-from-playlist.patch (3.1 KiB) 
 apps/tree.c            |   15 +++++++++++----
 apps/lang/english.lang |   15 ++++++++++++++-
 apps/onplay.c          |   38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+), 5 deletions(-)

Comment by David Rothenberger (drothenberger) - Tuesday, 25 July 2006, 22:27 GMT+2
Updated for CVS HEAD. Verified it compiles for all targets and sim targets.
   remove-from-playlist.patch (3.2 KiB) 
 apps/tree.c            |   15 +++++++++++----
 apps/lang/english.lang |   14 ++++++++++++++
 apps/onplay.c          |   38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+), 4 deletions(-)

Comment by David Rothenberger (drothenberger) - Tuesday, 15 August 2006, 00:35 GMT+2
Updated for CVS HEAD. Verified it compiles for all targets and sim targets.
   remove-from-playlist.patch (3.2 KiB) 
 apps/tree.c            |   15 +++++++++++----
 apps/lang/english.lang |   14 ++++++++++++++
 apps/onplay.c          |   38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+), 4 deletions(-)

Comment by Kris Weissmann (kw) - Tuesday, 13 March 2007, 18:55 GMT+2
Why has this patch never made it into builds / releases?
I miss this feature so much.
[How can the patch be implemented?]
Comment by David Rothenberger (drothenberger) - Saturday, 19 May 2007, 19:35 GMT+2
Synced with Rockbox SVN r13402
   remove-from-playlist.patch (2.5 KiB) 

    

  

    
    
      
    
    Comment by Björn Stenberg (zagor) -
    Tuesday, 22 May 2007, 14:43 GMT+2
  

  
    
      
  

    
David, please upload your latest patch again. I accidentally removed the file in the flyspray transition. :-(


  
    
    
      
    
    Comment by David Rothenberger (drothenberger) -
    Tuesday, 22 May 2007, 23:46 GMT+2
  

  
    
      
  

    
Here's the latest version again. This was synced with r13402. I verified it compiles for all targets.


      

          
                
              
            remove-from-playlist.patch
                  
                  (2.5 KiB)
          

    
 apps/lang/english.lang |   14 ++++++++++++++
 apps/onplay.c          |   38 +++++++++++++++++++++++++++++++++++++-
 2 files changed, 51 insertions(+), 1 deletion(-)


    

  

  
  




  
Loading...