Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5782 - remove the need to #ifdef show_*_backdrop();

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Wednesday, 09 August 2006, 11:20 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 20 May 2007, 11:01 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

this #defines show_*_backdrop() so we dont need to put it inside #ifdef HAVE_LCD_COLOR
(application/octet-stream)    backdrop.patch (6.9 KiB) 
 apps/bookmark.c          |    5 -----
 apps/screens.c           |    8 ++------
 apps/tree.c              |    6 +-----
 apps/gui/gwps.c          |   30 +-----------------------------
 apps/recorder/backdrop.h |    4 +++-
 5 files changed, 7 insertions(+), 46 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 20 May 2007, 11:01 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  macros suck
Comment by Jonathan Gordon (jdgordon) - Wednesday, 09 August 2006, 11:25 GMT+2
grrr... Bj�n's (c) notice is annoying :p
(application/octet-stream)    backdrop.patch (6.5 KiB) 
 apps/bookmark.c          |    5 -----
 apps/screens.c           |    6 +-----
 apps/tree.c              |    6 +-----
 apps/gui/gwps.c          |   30 +-----------------------------
 apps/recorder/backdrop.h |    4 +++-
 5 files changed, 6 insertions(+), 45 deletions(-)

Comment by Matthias Mohr (aka Massa) (mmohr) - Tuesday, 22 August 2006, 12:36 GMT+2
In principle it works very well.

But I don't know if we really want to hide functions via #define.
If we start this, we would have to do it for every possible function/target.

If you then have a look at the sourcecode you'll see apparent functions which
are not relevant for your target...
I think it's more confusing than having #ifdef around them.

(btw, the #define methos is only possible for functions without parameters -
which makes it somehow limited... ;)

my two cents...

Loading...