Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jdgordon - 2006-08-09
Last edited by jdgordon - 2007-05-20

FS#5782 - remove the need to #ifdef show_*_backdrop();

this #defines show_*_backdrop() so we dont need to put it inside #ifdef HAVE_LCD_COLOR

(application/octet-stream)    backdrop.patch (6.9 KiB)
Closed by  jdgordon
2007-05-20 09:01
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

macros suck

jdgordon commented on 2006-08-09 09:25

grrr… Bj�n’s © notice is annoying :p

(application/octet-stream)    backdrop.patch (6.5 KiB)
mmohr commented on 2006-08-22 10:36

In principle it works very well.

But I don’t know if we really want to hide functions via #define.
If we start this, we would have to do it for every possible function/target.

If you then have a look at the sourcecode you’ll see apparent functions which
are not relevant for your target… I think it’s more confusing than having #ifdef around them.

(btw, the #define methos is only possible for functions without parameters -
which makes it somehow limited… ;)

my two cents…

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing