Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5809 - add playback menu and better saving for rockpaint and text_editor

Attached to Project: Rockbox
Opened by Alistair Marshall (amar) - Sunday, 13 August 2006, 22:15 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 26 July 2007, 10:04 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Two versions, the first adds the playback menu to both rockpaint and text_editor however because rockpaint has fancy menus, the playback menu looks out of place so I created a version which does not add the playback menu to rockpaint (though I still think it is useful)

both versions also add a / to the start of new files that are being saved and now add a .txt or .bmp extension if they are missing
   plugins.patch (4.1 KiB)
 apps/plugins/rockpaint.c   |   13 +++++++++++++
 apps/plugins/text_editor.c |   17 +++++++++++++----
 2 files changed, 26 insertions(+), 4 deletions(-)

   plugins_noplay.patch (3.1 KiB)
 apps/plugins/rockpaint.c   |    5 +++++
 apps/plugins/text_editor.c |   17 +++++++++++++----
 2 files changed, 18 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 26 July 2007, 10:04 GMT+2
Reason for closing:  Accepted
Comment by Alistair Marshall (amar) - Tuesday, 24 July 2007, 20:26 GMT+2
OK with the announcement of the tracker cleanup week, I decided to look at my own active patches. I have broken this one in 2
text_playback.patch - This simply adds the playback to the text editor menu.
paint_save.patch - This means when you save a new file it automatically puts a leading / in the file name and adds .bmp at the end

2 very simple patches
   text_playback.patch (1.9 KiB)
 apps/plugins/text_editor.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

   paint_save.patch (0.7 KiB)
 apps/plugins/rockpaint.c |    5 +++++
 1 file changed, 5 insertions(+)

Loading...