Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5823 - Title for plugins/themes directories

Attached to Project: Rockbox
Opened by Will Robertson (aliask) - Wednesday, 16 August 2006, 07:43 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

When browsing plugins or themes from the menu, the list would display the title "/", because tc.dirlevel wasn't initialised properly for those calls.
The way I've fixed it isn't the best (tc.dirlevel still isn't done properly), but it was the simplest solution.

So now, browsing plugins displays the folder name - "rocks", is there anyone against renaming this folder to "plugins"? I think it would be more logical this way - viewers are also "rocks" technically...
   plugins_title.patch (0.8 KiB) 
 apps/tree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Saturday, 21 April 2007, 14:38 GMT+2
Reason for closing:  Out of Date
Comment by Alistair Marshall (amar) - Wednesday, 16 August 2006, 18:46 GMT+2
viewers are also plugins ;)

Someone suggested a while a go creating subfolders so that the plugins could be categorised into demos, applications, games etc (like in the manual)

I think this is a good idea and if the name of the rocks folder is going to be renamed, then this should be reconsidered

(perhaps this is not the place to discuss it)


Comment by Will Robertson (aliask) - Thursday, 17 August 2006, 08:45 GMT+2
There is already a patch for that, you can find it here: http://www.rockbox.org/tracker/task/5464 (in fact, you commented on it)

I've knocked up a quick patch to rename the rocks directory for the previously stated purpose.
   rocks_rename.patch (10 KiB) 
 apps/main_menu.c                  |    2 +-
 apps/settings.h                   |    2 +-
 apps/plugins/chessbox.c           |    2 +-
 apps/plugins/clock.c              |    2 +-
 apps/plugins/viewers.config       |    6 +++---
 apps/plugins/vu_meter.c           |    2 +-
 apps/plugins/lib/configfile.c     |    4 ++--
 firmware/test/fat/test.sh         |   10 +++++-----
 firmware/test/fat/test16.sh       |   10 +++++-----
 manual/plugins/firmware_flash.tex |    2 +-
 tools/buildzip.pl                 |   20 ++++++++++----------
 11 files changed, 31 insertions(+), 31 deletions(-)

Comment by Alistair Marshall (amar) - Thursday, 17 August 2006, 16:48 GMT+2
thanks, i couldnt remember the number

Loading...