Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5855 - Pong Upgrades

Attached to Project: Rockbox
Opened by Travis Hyyppa (Travis) - Saturday, 19 August 2006, 12:08 GMT+2
Last edited by Frank Gevaerts (fg) - Saturday, 08 January 2011, 17:34 GMT+2
Task Type Patches
Category Games
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Made pong look a lot nicer for color targets and added demo and one player modes for all.

I set the foreground to green and the background to black.

I also added a simple 1 player function to play against the computer. To play two players all you need to do is press one of the normal right player buttons.
(application/octet-stream)    pong.patch (6.6 KiB) 
 ./apps/plugins/pong.c |  119 ++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 106 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Saturday, 08 January 2011, 17:34 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Mostly committed as r29007. I left out all colour changes (both the pulsing and the background/foreground).

Please submit a new patch if you want either of those, but if so, please make the pulsing configurable.
Comment by Shachar (Lamed) - Wednesday, 06 September 2006, 23:46 GMT+2
"/* Give ball a little push to keep it from getting stuck between wall and pad */",

I'm not sure as I don't have a development environment available atm, but I'm pretty positive I've already solved the wall-pad bug. other then that It sounds like a good idea but I haven't gone through the code really :)

I think we should increase the ball side and make the game a little harder (ie faster ball or smaller pads, at least reffering to the h1x0, which is too easy to play imho)
Comment by Travis Hyyppa (Travis) - Thursday, 07 September 2006, 00:03 GMT+2
With the AI Player sometimes the ball will get stuck against the top/bottom of the screen and the side of the AI pad. The bump helps it, but it still happens, a lot less often now though. :)

Having the game get incrementally harder as you move on would be nice.
Comment by Nicolas Pennequin (nicolas_p) - Thursday, 09 November 2006, 00:02 GMT+2
redid the patch so it applies correctly
   pong_20061108.patch (6.3 KiB) 
 apps/plugins/pong.c |  117 ++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 105 insertions(+), 12 deletions(-)

Comment by Ryan Dechant (gravedigg154) - Friday, 22 December 2006, 08:46 GMT+2
I love this. I hate playing against myself, now I finally have AI to play against. Great patch.
Comment by Travis Hyyppa (Travis) - Wednesday, 31 January 2007, 18:40 GMT+2
Updated!

» Now includes a 'demo' mode which will play cpu<->cpu until a button is pressed.
» Also, if music is playing, the paddles will pulse bright green to the beat.
   pong_multi_pulse.patch (8.8 KiB) 
 apps/plugins/pong.c |  179 ++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 159 insertions(+), 20 deletions(-)

Comment by Andre Coleman (drestar23) - Monday, 14 May 2007, 02:19 GMT+2
I am new to this whole rockbox mp3 player thing so could someone please tell me how to apply this and any other patch????
Comment by Shachar (Lamed) - Monday, 14 May 2007, 15:47 GMT+2
start off by reading the 'For Developers' Section under the wiki's index
http://www.rockbox.org/twiki/bin/view/Main/DocsIndex

You have to know how to compile and how to work with patches
Comment by Antoine Cellerier (dionoea) - Saturday, 30 June 2007, 22:35 GMT+2
Redid patch to remove tabs/trailing spaces and keep code formating consistent with previous code.

Would it be possible to have the pads blink in different colors? (maybe have smoother transitions)
   pong_multi_pulse_patch.diff (8.8 KiB) 
 apps/plugins/pong.c |  166 +++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 152 insertions(+), 14 deletions(-)

Comment by josh (naegling23) - Sunday, 11 November 2007, 23:11 GMT+2
would love to see this, im not savy enough to patch rockbox though.
Comment by Taylore (trailblaze) - Monday, 25 August 2008, 23:25 GMT+2
When Patching, There is a hunk error.. That means it needs an update right? Hmmph this looked kool since the pong version right now isnt what it could be... can someone with knowledge in this stuff resyncdify this patch?
Comment by Thomas Schott (scotty) - Monday, 01 September 2008, 13:41 GMT+2
trailblaze: Of course! Here it is (r18377) ;-)

This patch crashes (at least) the simulator after a view seconds when playing music in the background while pong is running :-(
Didn't try it on a real device yet.
   pong_ai_and_multi_pulse.diff (8.7 KiB) 
 apps/plugins/pong.c |  164 +++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 150 insertions(+), 14 deletions(-)

Comment by Taylore (trailblaze) - Monday, 01 September 2008, 19:16 GMT+2
Thanxs a lot.. No crashing here on my ipod nano! I love the oulsing colors 2 my music.. Thanxs for making this experience possible!
Comment by Thomas Schott (scotty) - Thursday, 04 September 2008, 12:48 GMT+2
On my iPod pong works fine with the patch :-)
Don't know what causes the simulator crashes...
Comment by Taylore (trailblaze) - Friday, 16 January 2009, 23:00 GMT+2
Hmm.. I loved this patch.. lol, played it everyday... hmm, but now on build 19778, im getting 2 of those darn hunk error again....I feel bad asking, but may you please re-sync it please?
Comment by Thomas Schott (scotty) - Saturday, 17 January 2009, 00:58 GMT+2
Here it is.

The simulator crashes are gone somehow :-)
   pong_ai_and_multi_pulse-r19778.diff (8.6 KiB) 
 apps/plugins/pong.c |  164 +++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 150 insertions(+), 14 deletions(-)

Comment by Taylore (trailblaze) - Tuesday, 20 January 2009, 23:28 GMT+2
Thank you very much! works again... I love this patch!
Comment by Gman (Thecoolgman) - Thursday, 02 April 2009, 04:58 GMT+2
Can you make it where I can vs the ai?
Comment by Thomas Schott (scotty) - Sunday, 13 December 2009, 20:31 GMT+2
sync to SVN
   pong_ai_and_multi_pulse-r23974.diff (8.3 KiB) 
 apps/plugins/pong.c |  160 ++++++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 148 insertions(+), 12 deletions(-)

Loading...