Rockbox

Tasklist

FS#5882 - Allow playlist catalog view in browser and fix crash in ID3 view

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 25 August 2006, 13:24 GMT
Last edited by Steve Bavin (pondlife) - Wednesday, 27 June 2007, 07:49 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Selecting Playlist catalog > (select) from the ID3 view context menu causes a hard crash. This is because an empty menu is generated:
a) The View option is not displayed unless in the WPS. (This seems illogical to me - you'd want to start playback this way, surely.)
b) The Add options aren't supported in ID3 mode. (They should be implemented, but that's for another day.)

The attached patch enables the View option from the browser view and makes options consistent. This resolves the crash and allows playback to be started via playlist catalog. Before committing, it also needs to switch to the WPS when this is done, but I'm unsure how to achieve this. (HINT!)

Either way, that's a minor bug compared to a crash when you've not got a reset pin available!
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 27 June 2007, 07:49 GMT
Reason for closing:  Fixed
Additional comments about closing:  Other menu work has fixed this.

Loading...