This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#5882 - Allow playlist catalog view in browser and fix crash in ID3 view
Attached to Project:
Rockbox
Opened by Steve Bavin (pondlife) - Friday, 25 August 2006, 15:24 GMT+2
Last edited by Steve Bavin (pondlife) - Wednesday, 27 June 2007, 09:49 GMT+2
Opened by Steve Bavin (pondlife) - Friday, 25 August 2006, 15:24 GMT+2
Last edited by Steve Bavin (pondlife) - Wednesday, 27 June 2007, 09:49 GMT+2
|
DetailsSelecting Playlist catalog > (select) from the ID3 view context menu causes a hard crash. This is because an empty menu is generated:
a) The View option is not displayed unless in the WPS. (This seems illogical to me - you'd want to start playback this way, surely.) b) The Add options aren't supported in ID3 mode. (They should be implemented, but that's for another day.) The attached patch enables the View option from the browser view and makes options consistent. This resolves the crash and allows playback to be started via playlist catalog. Before committing, it also needs to switch to the WPS when this is done, but I'm unsure how to achieve this. (HINT!) Either way, that's a minor bug compared to a crash when you've not got a reset pin available! 
playlistcatcontextmods.patch
(1.4 KiB)
apps/onplay.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) |
This task depends upon
Closed by Steve Bavin (pondlife)
Wednesday, 27 June 2007, 09:49 GMT+2
Reason for closing: Fixed
Additional comments about closing: Other menu work has fixed this.
Wednesday, 27 June 2007, 09:49 GMT+2
Reason for closing: Fixed
Additional comments about closing: Other menu work has fixed this.