This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#5900 - Custom WPS Line with x/y/width coordinates and font face/color settings
Attached to Project:
Rockbox
Opened by P.I.Julius (pijulius) - Tuesday, 29 August 2006, 17:43 GMT+1
Last edited by Paul Louden (Llorean) - Wednesday, 16 January 2008, 15:18 GMT+1
Opened by P.I.Julius (pijulius) - Tuesday, 29 August 2006, 17:43 GMT+1
Last edited by Paul Louden (Llorean) - Wednesday, 16 January 2008, 15:18 GMT+1
|
DetailsThis patch adds a new tag in your wps which looks like this:
%e|11|219|50|1|B8C8E1|%alMusic Details: 11 = x coordinate 219 = y coordinate 30 = width 1 = userfont1 (this is the font face for this line wich is defined in the wps.cfg) B8C8E1 = the color for the line %al is the normal tag for aligning text to the left NOTE1: It depends on the multifont-userfonts.patch NOTE2: All values have to be specified none of them is optional. NOTE3: %s (scrolling tag) is not working yet, but I hope to integrate it soon. Bests, Julius 
customline.patch
(6.1 KiB)
gwps-common.c | 128 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ gwps.h | 3 + 2 files changed, 131 insertions(+) |
This task depends upon
Closed by Paul Louden (Llorean)
Wednesday, 16 January 2008, 15:18 GMT+1
Reason for closing: Rejected
Additional comments about closing: See viewports.
Wednesday, 16 January 2008, 15:18 GMT+1
Reason for closing: Rejected
Additional comments about closing: See viewports.
hex_to_rgb is defined in setings.c but it seems not to be exported as I cannot find it in settings.h. Do you have any idea for a solution?
Ciao
Norbert
CC gui/gwps-common.c
gui/gwps-common.c: In function `format_display':
gui/gwps-common.c:1332: warning: implicit declaration of function `hex_to_rgb'
gui/gwps-common.c: In function `gui_wps_refresh':
gui/gwps-common.c:1896: error: `FONT_USER1' undeclared (first use in this function)
gui/gwps-common.c:1896: error: (Each undeclared identifier is reported only once
gui/gwps-common.c:1896: error: for each function it appears in.)
gui/gwps-common.c:1899: error: `FONT_USER2' undeclared (first use in this function)
gui/gwps-common.c:1902: error: `FONT_USER3' undeclared (first use in this function)
gui/gwps-common.c:1905: error: `FONT_USER4' undeclared (first use in this function)
gui/gwps-common.c:1908: error: `FONT_USER5' undeclared (first use in this function)
gui/gwps-common.c:1911: error: `FONT_USER6' undeclared (first use in this function)
gui/gwps-common.c:1914: error: `FONT_USER7' undeclared (first use in this function)
gui/gwps-common.c:2117: error: structure has no member named `set_custom_width'
Regarding your compile error, it is because you didn't apply the multifont and multifon-userfonts patches to your source. I wrote about this see NOTE1. I wanted to make links to the other two patches, but I don't really know how to place links in this tracker system, and I can't seem to find a way to link this patch to the other two, I see there is a place for "This task depends upon" but I wasn't able to add there anything.
the playback screen if I apply this patch
(together with the multifont, multifont-user and custom_disply_width path)
this happens with all themes. The file list display is ok
Without this single patch (but still with all the others) the remote is
back to normal
How did you checked this out? did you try to use a tag as specified above?:
%e|11|219|50|1|B8C8E1|%alMusic
please note that it does not support scrolling lines (it will be implemented separattely in the future, so you won't have any need for it) so if you use %s%alMusic it won't show up, %s is not supported. The rest should work, but write me if you can't get it to work. For e.g. try to use one of my themes to check it out, for e.g. jClix or jBlackGlass, both use this feature ti display the texts on the wps.
Cheers,
Julius
Just want to make sure all others old wps are still working
together with this patch :-)
And still the remote screen in the simulator becomes blank
on the playback screen. Removing the patch and it is back.
Cannot try it on may real X5 because I dont have a remote there
Sorry, but it seems we really can't have this patch working together with the scrollmargins patch.
And in the main WPS either or scroll margins or custom line
seems to work.
Is the remote working in your build in the simulator?
Both of course together in one WPS will be a problem :-)
NO scroll margins and the remote is blank
This change in gwps-common.c is the reason
display->set_foreground(global_settings.fg_color);
If I comment this single lines the remote is back working
any ideas?
of display->set_foreground it also works
between a wps that uses %e and a wps without.
Else the screen layout is wrong because the %e
specific values are still used
gui/gwps-common.c: In function 'gui_wps_refresh':
gui/gwps-common.c:2119: error: too many arguments to function
This is what line 2119 looks like.
display->setmargins(data->line_xpos, data->line_xpos+data->line_width, data->line_ypos);
Help?
display->setmargins(data->line_xpos, data->line_ypos);
If you dont have the scroll_margins patch applied.
Sorry that this slipped into the patch
From looking into the current scrolling code which is strictly line based
I am a little bit curious how this will be done :)
Do you have allready some implementation ideas how you will do this?
How will this match with custom y-positions?
As I said that I will do it, I did it :) so here you go, the attached patch adds scrolling capabilities to the customline patch, so now there is no need for scrollingmargins :) (just kidding)
So to use it you have to use the same scrolling line mark as always, for e.g.:
%e|11|219|100|1|B8C8E1|%al%sMusic_text_which_will_scroll
would scroll the line on the x=11 y=219 coordinates within a 100px long area. Please note the "%s" after "%al" which is important/necessary to activate the scrolling option.
It includes a few fixes too, like reseting the margins on wps exit (thanks a lot Max!) and some other fixes.
Wish you the bests!
Julius
ps: only platform I tested iPod 4g and 5g (sorry Max, I haven't had the chance to test it on X5)
Can you enlighten me for a moment, because I am thinking about including the patches into my Norbu build:
Questions:
- If I include this patch and leave out scrollmargins, will the old WPS continue to work? Or is some changing necessary?
- Which additional patches do I need to include, and in which order, to get customline working?
Thanks a lot and all the best
Norbert
1: This patch does not replace the scrollmargins patch in any way, it just does the some thing with some more options like font face, color and x/y positioning, so if you removed the scrollmargins patch from your build the wps-es would have to be modified to support this patch
2: To make this patch working you would need the followings:
#5898 Custom display width
#4733 Multifont
#5901 Multiple user fonts for using in WPS
and I would suggest the
#5899 Custom List/Menu x/y coordinates and width
but this patch is not a must to have customline working.
NP, you're welcome! I hope this helps, write me if there is anything.
Cheers,
Julius
Cheers,
Julius
Thanks a lot I will try it asap
Max
If I use a WPS with %e and %s
sometimes when switching back to the file browser
still scrolling lines from the WPS are displayed
'over' the browser lines
Could you somehow give me more info on this bug because I can't seem to reproduce it.
Thanks in advance!
Julius
I use the following "very very simple" WPS
%e|5|15|130|4|FFFF00|%al%s%?ia<%ia|%?d2<%d2|(Artist Unknown)>>
%e|5|35|130|1|FFFF00|%al%pt
%e|5|35|130|1|FFFF00|%al%pc
%e|5|50|130|3|FFFF00|%al%s%?id<%id|%?d1<%d1|(Album Unknown)>>
%e|5|67|130|3|FFFF00|%al%s%?it<%it|%fn>
%e|5|85|130|2|FFFF00|%al%sNext: %?It<%It|%Fn>
%pb|0|0|160|99
Displaying the WPS works fine with scrolling but when I switch during playing
to the file browser and lines have been scrolling in the WPS the same
lines scroll in the browser wih the same larger font as in the WPS
wps: /.rockbox/wps/Custom_Test.wps
foreground color: FFFFFF
background color: 000000
userfont1: /.rockbox/fonts/helvR10.fnt
userfont2: /.rockbox/fonts/helvR10.fnt
userfont3: /.rockbox/fonts/helvR12.fnt
userfont4: /.rockbox/fonts/helvR14.fnt
browserfont: /.rockbox/fonts/helvR10.fnt
wpsfont: /.rockbox/fonts/helvR10.fnt
menufont: /.rockbox/fonts/helvR10.fnt
the following line is missing in lcd-16bit.c in the "normal"
lcd_puts_scroll_style_offset function to reset the normal
scrolling line attributes
...
s->customline = false;
...
...
s->customline = false;
s->line_font = curfont;
s->line_xpos = 0;
s->line_ypos = 0;
s->line_width=0;
...
to reset all customline attributes
the difference
%e|10|32|146|1|FFFFFF|%al%s%?C <%e|64|32|94|1|FFFFFF|%?ia <%ia|%fn>|%?ia <%ia|%fn>>
%e|10|50|146|3|FFFFFF|%al%s%?C <%e|64|50|94|3|FFFFFF|%?it <%it|%fm>|%?it <%it|%fm>>
%e|10|63|146|3|FFFFFF|%al%s%?C <%e|64|63|94|3|FFFFFF|%?id <%id|%d1>|%?id <%id|%d1>>
This code allows you to set an alternate display based on whether album art is present, and works fine. However, when aligned right it doesn't work - nothing is displayed except when a line needs to scroll.
%e|10|32|146|1|FFFFFF|%ar%s%?C <%e|64|32|94|1|FFFFFF|%?ia <%ia|%fn>|%?ia <%ia|%fn>>
%e|10|50|146|3|FFFFFF|%ar%s%?C <%e|64|50|94|3|FFFFFF|%?it <%it|%fm>|%?it <%it|%fm>>
%e|10|63|146|3|FFFFFF|%ar%s%?C <%e|64|63|94|3|FFFFFF|%?id <%id|%d1>|%?id <%id|%d1>>
However, if the scrolling margin tags are removed everything displays, but then of course there is no scrolling.
%e|10|32|146|1|FFFFFF|%ar%?C <%e|64|32|94|1|FFFFFF|%?ia <%ia|%fn>|%?ia <%ia|%fn>>
%e|10|50|146|3|FFFFFF|%ar%?C <%e|64|50|94|3|FFFFFF|%?it <%it|%fm>|%?it <%it|%fm>>
%e|10|63|146|3|FFFFFF|%ar%?C <%e|64|63|94|3|FFFFFF|%?id <%id|%d1>|%?id <%id|%d1>>
I'm living with the glitch for now, but if there's anything you could do to fix it of course I'd be appreciative. Or, if I'm just doing this wrong, I'd appreciate knowing that, too.
There is only handling of left aligned strings for customline
Adding the following fixes it
if (left_width != 0)
{
display->puts_customline_scroll(i,(unsigned char *)data->format_align[i][data->curr_subline[i]].left);
}
if (center_width != 0)
{
display->puts_customline_scroll(i, (unsigned char *)data->format_align[i][data->curr_subline[i]].center);
}
if (right_width != 0)
{
display->puts_customline_scroll(i,(unsigned char *)data->format_align[i][data->curr_subline[i]].right);
}
display->puts_customline_scroll(i,(unsigned char *)data->format_align[i][data->curr_subline[i]].left);
of course :-)
I finally used a way similiar to the "normal" scroll lines (below)
Which is to use puts_customline_scroll if scrolling is needed
and putsxy with the correct alignment if no scrolling is needed.
This seems to work as expected
A request to the authos of this patch ...
I like the patches that are being implimented into the RB build, but there isn't much happening for the remote. Can this patch be extended to support the x5 remote?
Any thoughts?
regards,
vm3
I'm pretty sure it can be, it just has to be worked on.
Btw: I had a lot on my head and that's why there wasn't much happening here, I will try to sync this soon and than I will have a look on the x5 too.
Bests,
Julius
I actually change your patch already a little bit to work on the x5
(+ some bugfixes) I will try to upload a version with my changes soon
Unfortunately I dont own a remote and can only use the simulator to test
but we have lots of people using my builds on the iaudophile forums to test :-)
Max
Thanks a lot for your help, I saw that changing things for e.g. display->set_foreground to lcd_set_foreground fixes a few problems, but I'm just curios, if you do this changes didn't you get a Warning at compilation? because I do and I think the changes should be made somewhere in the x5 firmware driver files (but it's just a thought as I said).
Thanks!
Julius
and lcd-remote-2bit.c (which is used for the x5) to include
the new calls from you e.g. lcd_set_custom_width aso.
Now the display-><call> can be used
Thanks again!
Julius
and cannot do what I want to do and that is rockbox
coding :-)
is a different one. Since the x5 has only a 2bit remote display.
setting the foreground of the remote makes not much sense.
The result is that nothing is displayed on the remote
Thats the reason for changing it to lcd_set_foreground so that
it only has an effect on the main units screen
The only thing missing are the lcd_puts_customline_scroll and
lcd_puts_customline_scroll_style_offset implementations in
lcd-remote-2bit.c but I guess they will look similiar to
the ones in lcd-16bit.c
I added empty functions for lcd_remote_puts_customline_scroll and
lcd_remote_puts_customline_scroll_style_offset at the moment in
lcd-remote-2bit.c otherwise it would crash if using an rwps file
but scrolling is not supported at the moment
Sorry I still use the scroll_margins patch below so the
patches are dependend on it but I guess you know what to do :)
regards,
vm3
lcd_remote_puts_customline_scroll and
lcd_remote_puts_customline_scroll_style_offset
(just a copy of your code from lcd-16bit.c adapted to the remote API)
I did a quick test with the simulator and scrolling
seems to work now also on the remote
So again, Thanks a lot man!
You know for sure :)
since I also use the scoll_margins patch you must replace
leftmargin and rightmargin with xmargin and your custom_width
in my patches
to customline on the iaudiophile forum. I will keep you informed
of any problems found.
Unfortunately I wasn't able to have a look into these modifications/additions, but I really hope/try to do my best to find some free time to get on with the coding.
The following in lcd-16bit.c function scroll_thread gives problems when I use an animated peakmeter
Then scrolling lines are not displayed correct
..
if (s->customline) {
lcd_setfont(s->line_font);
lcd_setmargins(s->line_xpos, s->line_xpos+s->line_width, s->line_ypos);
lcd_set_custom_width(s->line_width);
}
...
I found that the last two lines (lcd_setmargins and lcd_set_custom_width)
can be safely removed and that fixes the problem. Still the wps works correct
I am not sure why but maybe you know :-)
Regards
Max
So the only patch which makes me crazy is this one. Do i really have to make a seperate build without the scrolling_margins applied??? I read that Max made it to use both scrolling margins and custom line, but as already said... i cant reproduce this... the lcd16bit.c causes always troubles also with the patches he offered. Any hints????
Thanks in advance!
Sacha
I have tried all instructions/modified patches so that the following line of patches applied in there stated order would build for my 5G iPod. They all apply, some requiring you to directly edit the source due to rejects, but when I attempt to build for my iPod, i always get an error. Here is the patches used:-
scroll-margins_20061025.patch
custom_display_width-scroll_margins.patch
multifont-20060930.patch
multifont-userfonts-20060828.patch
customline-20060930.patch
custom_list_position-20060930.patch
I apply/build using Cygwin.
e.g. I only build for an X5
Can you tell me the eaxct build error you get
lcd_puts_custom_line_scroll-style... With your latest patch applied it argues that
something wrong with the variables...
Will reproduce it this morning and post a more precice error message here...
As far as i can remember it argued about undeclared or first use of variables fgcolor or so...
I saw this variables occuring also in your patch at the lcd.h hunks...
int right_margin;
int fgcolor; <--- I dont have those in my lcd.h
int bgcolor; <--- where are they from?
+ /* Custome line arguments */
+ bool customline;
+ int line_font;
I applied the patches ind the same order as Kyle mentioned without th lcustom_list_position...
Error:
In function: lcd_puts_customline_scroll_style_offset "struct scrollinfo" has no member named fgcolor ... has no member bg_color
Any ideas ?
;-)
They are missing in the patch because they got added by another patch
I use :-(
Just add
int fgcolor;
int bgcolor;
to lcd.h
Applied all the patches i mentioned above except for custom_list_position-20060930.patch.
Tried to build rockbox with Cygwin for my iPod and this is what it spat back out at me :-
CC drivers/lcd-16bit.c
drivers/lcd-16bit.c: In function 'lcd_puts_customline_scroll_style_offset':
drivers/lcd-16bit.c:878: warning: implicit declaration of function 'lcd_getxmarg
in'
drivers/lcd-16bit.c:907: error: 'xmargin' undeclared (first use in this function
)
drivers/lcd-16bit.c:907: error: (Each undeclared identifier is reported only onc
e
drivers/lcd-16bit.c:907: error: for each function it appears in.)
drivers/lcd-16bit.c: In function 'scroll_thread':
drivers/lcd-16bit.c:1036: error: too few arguments to function 'lcd_setmargins'
make[1]: *** [/home/rockbox-src/build/firmware/drivers/lcd-16bit.o] Error 1
make: *** [all] Error 2
xmargin is replaced with leftmargin when you apply
the scroll_margins patch.
You must use "my" customline-20060930.patch from above
NOT the "original" one
Sorry that it has the same name :-(
Your patch assumes that int fgcolor and int bgcolor; are already set (line 394 and 395 in the patch)
I dunno where these are from but only if i add these two also two my lcd.h (they arent there natively)
the patch runs through without any Errors... Could you figure out which patch adds these two so i can make a clean build???
Thx ;-)
I never put it there because it changes some other things too
Sorry for any confusion it caused
I've got a working build now and must say it was worth the trouble and the H10
users appear to be happy now ;-) THx Max thx to Pijulius (You and PJ are both mentioned
in the build remarks)
http://www.rockbox.org/tracker/task/2838 and
http://www.rockbox.org/tracker/task/4783
hope this helps :-)
I finally tracked down this issue. The problem is that you
MUST not mix lines wih and without %e in the same WPS else
it gets screwed up e.g. %t lines etc.
The fix is to always add a "dummy" %e tag in front
e.g. %e|0|0|0|1|FFFFFF|%t0.3% .....
Second, I tried to use your patches on the current CVS so that I could also include the scrollwheel acceleration patch on my 5G iPod... they were a little out of date, and required a fair amount of massaging to get them to incorporate. I finally did get a build, but it was a bit glitchy, so I reverted back to your 20060930 binary, which works great but doesn't have the scroll acceleration. (I can get around that with a custom config for the tagcache navigator, though.)
Any news on patch syncs with CVS?
And also, I came across a problem with custom lines and custom fonts in your 20060930 build. Perhaps I'm doing something wrong, or perhaps there's a problem with the code...
I was customizing your jBlackBox9 theme -- I wanted to make the Artist and Title info larger.
So, in the theme .cfg, I added:
userfont2: /.rockbox/fonts/helvR18.fnt
and in the theme .wps, I changed the following lines:
FROM
%e|117|5|150|1|FFFFFF|%al%cb d, H:Mc;%e|117|5|240|1|FFFFFF|%alBattery: %bt
%e|133|42|167|1|FFFFFF|%al%s%?ia<%ia|%?d2<%d2|(Artist Unknown)>>
%e|133|56|167|1|FFFFFF|%al%s%?id<%id|%?d1<%d1|(Album Unknown)>>
%e|133|70|167|1|FFFFFF|%al%s%?it<%it|%fn>
%e|113|100|187|1|FFFFFF|%alTrack: %pp of %pe - %pc [%pt]
%e|113|114|187|1|FFFFFF|%alCodec: %fc (%fbkbps)
%e|70|154|230|1|FFFFFF|%al%sNext: %?It<%It|%Fn>
TO
%e|117|5|150|1|FFFFFF|%al%cb d, H:Mc;%e|117|5|240|1|FFFFFF|%alBattery: %bt
%e|126|33|190|2|FFFFFF|%al%s%?ia<%ia|%?d2<%d2|(Artist Unknown)>>
%e|126|56|190|1|999999|%al%s%?id<%id|%?d1<%d1|(Album Unknown)>>
%e|126|71|190|2|FFFFFF|%al%s%?it<%it|%fn>
%e|113|100|187|1|FFFFFF|%alTrack: %pp of %pe - %pc [%pt]
%e|113|114|187|1|FFFFFF|%alCodec: %fc (%fbkbps)
%e|70|154|230|1|FFFFFF|%al%sNext: %?Ia<%Ia - > %?It<%It|%Fn>
the changes being some x/y modifications to Artist and Title, color modification to Album, and adding the artist to the Next song text.
The mods worked as expected, EXCEPT if the Artist or Song Title is long and scrolls. If this happens, then the Date-Time/Battery text and the Track text get confused about which font they are supposed to be displayed in and keep bouncing between them. So then you end up with the text being correct *most* of the time, but with a weird ghost effect from pieces of the old, larger text still being diplayed below the actual text.
Note that this is only a problem with text that updates itself -- the Codec line, the album line, and the Next line all display normally (even with scrolling in the Next line) -- and only a problem when the larger text scrolls. If the larger text doesn't scroll, then the display works perfectly.
Any ideas? Is it a problem with the way I changed things? or a problem with the scrolling mods in the customline patch?
They should apply cleanly on CVS from 1.Nov
About the problem with the font changing.
This comes from the multifont patch I guess
I have also read this on the mystic river forums
I will try to reproduce this on my X5
If you're interested in comparing my patches to the originals, feel free to check them out: http://www.ungerdesign.com/rockbox/patches/. I know C, and can do OK comparing and fixing the failures and fuzz 2's I found, but I'm still a bit uneasy simply because I'm not the one who wrote the patches, therefore I'm not entirely sure I knew what some of the sections I was tweaking were trying to accomplish. :-) There were a few warnings in the build process which I don't have time to figure out (see the text files in the /rockbox/ directory for details).
I also posted some builds: http://www.ungerdesign.com/rockbox/. These should be direct replacements for Julius's builds. Except that the USB cable plug/unplug behavior has been reversed -- plugging in the cable just charges the iPod, and holding down Menu while plugging it in makes it go into Disk Mode. It's just easier for me in the long run that way. :-)
Enjoy!
The ones at http://rockbox.webhop.org/ should now apply cleanly agains CVS from 12.Nov
I will compare them to yours
in the multitfont customline and scroll_margins patches
If you want to check them out look at http://rockbox.webhop.org/
I will post them to their respective flyspray entries after
all the testing is done
Could you tell me what source those patches on http://rockbox.webhop.org/ will apply to?
Anyway, 2 problems Ive encountered with the older patches (using ipod nano):
* (This problem relates to the album art patch) It wont display text if put a %s in the "else" condition of album art. Works fine for the "if" part of condition.(%?C<%s scrolls fine|%s no scroll and is just a blank line>).
* Make error comes up, still compiles though. Error is:
drivers/lcd-16bit.c: In function 'scroll_thread':
drivers/lcd-16bit.c:1011: warning: 'fgcolor' may be used uninitialized in this function
I tried putting int fgcolor; in the lcd.h as mentioned by Sacha (Angyman), but it didnt make any difference.
* Get a briefly weird "popping" happening with text that uses %ac and %ar, and the larger text that pops up is ghosted. Happens on the actual player, doesnt occur in the sim. It seems to correlate with where code is put in the wps.
Are these solved in the newer patches?
order as described in the series file.
Of course some are dependend on each other so it might not
be possible to just use specific ones separately
And (I know Im asking alot!) the possibilty to allow %s in the else argument of the album art tag?
Many (many) thanks.
Would make it easier to debug for me
Points to note:
* Might have to play around with where the playlist position, clock and date go to get the pop effect.
* "Popping" effect only occurs when playing music and only on the player (i use the nano, dont know if it happens on other players). It doesnt happen on the sim.
* I think the "popping" also happens if the first instance of some text code has a %ac after all the preloads etc used in the wps.
* Cant use %ar or %s in the else condition of the %?C album art. So if no album art is found, a blank line is shown. Only %al works.
If need more info or the source/build, email me or icq (see my profile) as Im online for most of the time. Many thanks.
And for enhancements to the album_art patch you should post this request there :-)
even with your test wps :-)
%e|76|17|90|3|000000|%ac%s%?C<%?ia<%ia|(Artist Unknown)>|>
%e|12|17|154|3|000000|%ac%s%?C<|%?ia<%ia|(Artist Unknown)>>
the text is always centered
Or do you mean something different?
Decided to try to patch the latest source (19/12/06) with the patches from http://rockbox.webhop.org/. After some coaxing I got them to patch fine, it didnt build at first, so corrected sum undeclared errors. When running the sim, all text is aligned almost off screen. (See pic below)
http://www.billyblair.com/misc/rb_scrn.png
And when I try to play music, it crashes. (see pic below)
http://www.billyblair.com/misc/rb_crash.png
The patches I use are (applied in that order):
progressbar_ycoord_extension2.1.patch0
bmp_resize_v0.99.3.patch
album_art_v5.01.patch
custom_display_width.patch
multifont-20060828.patch
multifont-userfonts-20060828.patch
customline-20060930.patch
custom_list_position-20060930.patch
Ive a feeling the scrolling margins and/or the colorised-wps+battery-volume_levels.patch altered the patches that were to be applied after them on the original list. But I couldnt find any thing.
I appreciate any help, getting a massive headache from it all! See http://ipodfoo.blogspot.com to see why Im torturing myself.
scroll_margins patch. they depend on each other.
colorized_wps is optional.
This is a build containing this patch. You will get also the patches for the actual source there
Not displayable example:
%s%e|11|100|80|1|B8C8E1|%acMusic
Displayable examples:
%s%e|11|100|80|1|B8C8E1|%alMusic
%e|11|100|80|1|B8C8E1|%acMusic
%s%e|11|100|10|1|B8C8E1|%acMusicMusicMusicMusicMusicMusicMusicMusicMusicMusic
here width is less than text length
Unfortunately I cannot post it here because it is very dependent on some other patches
I include in my build. But if you want to try take a look at
http://members.a1.net/maxwen/rockbox/patches-20070320/index.htm
And everyone is welcome to adapt the patch so it works also "standalone" to post it here
this is not just a simple sync but a rewrite
because of the many changes in the wps code
maybe not the optimal impl but it is a start (synced against 20070430)
depends on multifont multifont-userfonts and scroll_margins patch
http://www.rockbox.org/tracker/task/6796
THX!
and depends on another patch I use. I will try to
change this
So you have an iPod? And it happens with jclix and jblackglass theme?
I had also some wps where I needed to move the %pb line in the wps file
to get the progressbar displaying correctly
Can you try to move the %pb at the end of the file?
# ymargin_scrollinfo.patch FB6796
# scroll-margins_20070424.patch -p0 FB2954
# album_art_20070426.patch -p0 FB3045
# bmpresize-20070417.patch -p0 FB5697
# progressbar_slider_20070430.patch -p0 FB6505
# multifont-20070515.patch -p0 FB4733
# multifont-userfonts-20070430.patch FB5901
# customline-20070430.patch -p0 FB5900
# colorized-wps-20070430.patch
# custom_list_position-20070430.patch -p0 FB5899
I probably don't need some of those but I didn't want to take a chance on dependencies. I have fooled around with the placement of %pb and it doesn't seem to change anything. I think there may be some sort of problem with it refreshing.
dependencies as usual
FS#6796?I've tried patching for the sansa with multifont and scrolling margins and i get a compiling error.
Can you post the error lines please
FS#6796), just had these errors when i got to this patch.instead I created my own some time ago which his now out of sync :(
Sorry for the confusion.
I will try to create a version of the customline patch to be used with the
latest "original" one. In the meantime if you like you can try "my version"
of scroll_margins found here http://rockbox.webhop.org/