Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5903 - Move doom game files to /.rockbox/doom

Attached to Project: Rockbox
Opened by Dominik Riebeling (bluebrother) - Tuesday, 29 August 2006, 19:10 GMT+2
Last edited by Nils Wallménius (nls) - Friday, 10 November 2006, 20:28 GMT+2
Task Type Patches
Category Games
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Simply as the title says: currently doom looks for its files in /games/doom. IMO the game files shouldn't be put in a visible folder but as pacbox does somewhere below /.rockbox -- configuration and themes are also stored there. The attached patch simply modifies doom to look in /.rockbox/doom for its files.
   doom-to-rockboxdir.patch (1.5 KiB) 
 apps/plugins/doom/g_game.c     |    2 +-
 apps/plugins/doom/rockmacros.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Saturday, 13 January 2007, 16:17 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  after some discussion the data is now located in /.rockbox/doom
Comment by Paul Louden (darkkone) - Tuesday, 29 August 2006, 20:36 GMT+2
Had I commit access, I would so be all over this. It would solve the question of "I keep clicking on the Doom files and it doesn't do anything." As well as improving consistency.
Comment by Jonas Häggqvist (rasher) - Tuesday, 29 August 2006, 20:51 GMT+2
Is there any reason this should not be applied? I've been wondering about this ever since Doom appeared first.

Actually, wouldn't it be smarter to have /.rockbox/games/ and then packbox and doom dirs under that?
Comment by Paul Louden (darkkone) - Tuesday, 29 August 2006, 20:53 GMT+2
That could work as well.

The way I see it, any files that are unnecessary (and perhaps unwise) for a user to have direct access to should be hidden under /.rockbox/

A /.rockbox/games folder would be perfectly suitable I think, though people might ask why we don't put the game plugins there so that they're categorized. Maybe /.rockbox/gamedata ?
Comment by Jonas Häggqvist (rasher) - Tuesday, 29 August 2006, 20:57 GMT+2
Gamedata is probably a better name indeed. But other than that, how could it possibly be a problem, except for the fact that people will need go into a hidden folder to put the files there - I don't know how much of a problem that is?
Comment by Paul Louden (darkkone) - Tuesday, 29 August 2006, 20:59 GMT+2
The folder isn't hidden on a Windows PC at least. On other operating systems, it's still possible to find it, and most Linux users wouldn't have a problem doing so. I think it's a good idea.
Comment by Jonas Häggqvist (rasher) - Tuesday, 29 August 2006, 21:06 GMT+2
It will of course break the game for anyone who has it installed into /games/doom/ right now - what's the error it emits if no files are found? It should probably say something like "no files found in .rockbox/games/doom" so people can see what's going wrong (if they bother to read the error message of course).

Other than that, i say go for it.
Comment by Steve Bavin (pondlife) - Tuesday, 29 August 2006, 22:28 GMT+2
Why not look in /.rockbox/doom (or wherever) first, then fall back to looking in /games/doom, then fall back to giving an error which refers to .rockbox/doom?
Comment by Dominik Riebeling (bluebrother) - Tuesday, 29 August 2006, 22:46 GMT+2
having a fallback location might cause additional confusion if the user sometimes has installed files into /.rockbox/doom and later places additional files in /games/doom causing "doom doesn't find my files" problems. Also, implementing a fallback method would need a tiny bit more work (not that it matters, but anyhow ...)

When moving the game files to /.rockbox/gamedata/doom/ we should also consider moving the pacbox data to /.rockbox/gamedata/pacbox/.
Comment by Jonas Häggqvist (rasher) - Tuesday, 29 August 2006, 22:55 GMT+2
This patch moves Doom data to /.rockbox/gamedata/doom/ and pacbox data to /.rockbox/gamedata/pacbox/
Comment by Jonas Häggqvist (rasher) - Tuesday, 29 August 2006, 22:56 GMT+2
I'll try that again..
(application/octet-stream)    games_data_move.diff (2.3 KiB) 
 apps/plugins/doom/g_game.c     |    2 +-
 apps/plugins/doom/rockmacros.h |    2 +-
 apps/plugins/pacbox/pacbox.c   |    4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

Comment by Dominik Riebeling (bluebrother) - Tuesday, 29 August 2006, 23:22 GMT+2
Jonas, with your patch I get the following warnings:

rockdoom.c:211: warning: initializer-string for array of chars is too long
rockdoom.c:211: warning: (near initialization for ‘wads_builtin[0]’)

The attached modified version fixes this. Also used ROCKBOX_DIR for the pacbox path. So far I only tested doom on the h120 sim, I need to get the pacbox roms before I can test the modified pacbox.
   games_data_move2.diff (2.9 KiB) 
 apps/plugins/doom/g_game.c     |    2 +-
 apps/plugins/doom/rockdoom.c   |    2 +-
 apps/plugins/doom/rockmacros.h |    2 +-
 apps/plugins/pacbox/pacbox.c   |    4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

Comment by Jonas Häggqvist (rasher) - Tuesday, 29 August 2006, 23:36 GMT+2
That was a stupid mistake of me. I just tested pacbox in the sim with your patch. Works nicely.
Comment by Daniel Stenberg (bagder) - Monday, 08 January 2007, 12:41 GMT+2
I'm in favour of this move as well
Comment by Paul Louden (darkkone) - Monday, 08 January 2007, 12:44 GMT+2
I'm in favour of this AND including rockdoom.wad in the download. It's 280kb, uncompressed, so it won't hurt the download size too much (in my opinion) and we can change the splash to "No IWAD in /.rockbox/doom" to be a bit more explicit about what is needed, as the Base Wads one is somewhat vague anyway.

Loading...