Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5925 - iRiver H10 (6GB) bitmap positioning bugfix

Attached to Project: Rockbox
Opened by Thilo-Alexander Ginkel (tg) - Friday, 01 September 2006, 20:17 GMT+2
Last edited by Barry Wardell (barrywardell) - Monday, 04 September 2006, 00:16 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To Barry Wardell (barrywardell)
Player Type iriver H10
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch for the H10 LCD code fixes the problem that the x and y coordinates for the origin of bitmaps drawn on the LCD seem to be swapped resulting in the file list to be shifted to the right and the status bar to be drawn over the file list.

As I own an H10 6GB, I do not know whether this patch is required for the H10 20GB or if conditionals are required to swap the coordinates only for the H10 6GB.
(application/octet-stream)    h10_bitmap_origin.patch (0.7 KiB) 
 firmware/target/arm/iriver/h10/lcd-h10.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Tuesday, 05 September 2006, 01:16 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Now in CVS
Comment by Barry Wardell (barrywardell) - Saturday, 02 September 2006, 00:35 GMT+2
I think something similar is required for the 20GB too. It has recently been pointed out to me that the 20GB screen is actually 128x160 but rotated by 90degrees, hence X and Y being mixed up and all the graphical glitches. I'm currently working on a more thorough fix that will hopefully work with all models. I'll post a patch here for testing once it's ready.

Loading...