Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5969 - Track skip in repeat-1 mode skips the track

Attached to Project: Rockbox
Opened by Will Robertson (aliask) - Monday, 11 September 2006, 07:24 GMT+2
Last edited by Will Robertson (aliask) - Friday, 03 August 2007, 15:48 GMT+2
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Previously skipping a track in repeat-1 mode would start playback again of the same track.
As dongs pointed out on IRC (repeatedly) from his detailed studies of many people this is unintuitive.

So here the fix is.
   repeat1.patch (0.6 KiB) 
 playlist.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Will Robertson (aliask)
Friday, 03 August 2007, 15:48 GMT+2
Reason for closing:  Invalid
Additional comments about closing:  Patch completely useless, perhaps this could be opened as a feature request if anyone feels it's necessary. No point leaving the task open.
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 11 September 2006, 08:04 GMT+2
I honestly don't believe that disabling the Repeat-1 function is the way to solve this.
Comment by Will Robertson (aliask) - Monday, 11 September 2006, 08:53 GMT+2
Oh boy am I red faced. I guess I should have tested this a bit more before testing it hey :)
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 11 September 2006, 10:28 GMT+2
Hehe. :-)

As you can see, the problem is that the repeat-1 is handled at the playlist level by building a playlist with only 1 track and letting it repeat. This is why it isn't easy to fix this issue.

A possible solution would be to handle the repeat-1 in the playback code instead, so it only calls playlist_next() when actually skipping a track.

Loading...