This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#6007 - TextViewer bugs
Attached to Project:
Rockbox
Opened by PaulJam (PaulJam) - Saturday, 16 September 2006, 16:53 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 06:16 GMT+1
Opened by PaulJam (PaulJam) - Saturday, 16 September 2006, 16:53 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 06:16 GMT+1
|
Details1. If you are in narrow view mode and the text contains a string of characters that has a "-" in it, where the part of the sring after the "-" is so long that it doesn't fit on a single line (for example a long URL), it happens, that only the part in front of the "-" is shown, and the following lines in the text remain blank and you can't scroll down any further.
Example: The textfile contains the following text: aaaaaaaa bbbbb-cccccccccccccccccccccccccccccccccccccccc ddddddddd it only shows: aaaaaaaa bbbbb If a longer text contains such a string, and you are at the end of the file and try scroll up to the position of this string the player (in this case a H300) freezes. 2. If you watch a textfile in wide view and scroll some columns to the right and then change the view to narrow, then the viewer doesn't use the full display width and parts of the textlines are missing/not shown. It seems as if the view stays scrolled to the left and so the first few characters (depending on how much you scrolled right in wide view) of each line outside the visible area. 3. If you scroll down (paged scrolling) in a long text file, after a while audio playback pauses until you stop scrolling. |
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Sunday, 05 August 2007, 06:16 GMT+1
Reason for closing: Fixed
Additional comments about closing: quick hack commited to fix point 1, so can finally close this
Sunday, 05 August 2007, 06:16 GMT+1
Reason for closing: Fixed
Additional comments about closing: quick hack commited to fix point 1, so can finally close this
3 is because its not yielding enough (hopefully Slasheri's new schedular fixed this tho, let us know if i should add a yield call in to fix this)
point 1 is beyond my level of understanding of the code
To reproduce it open the textfile
http://www.rockbox.org/irc/rockbox-20060914.txt
in the viewer plugin and scroll (in narrow mode) down to timeindex 01.06.33. The join message is only shown half and the text behind that is missing.
The workaround i'm using is to remove the part
,'-'
near the end of line 242 of the file apps/plugins/viewer.c (version 1.49)
but i don't think this is a proper fix for this problem.