Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6033 - CPU boosting tracker

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Wednesday, 20 September 2006, 13:09 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch allows an ID (character) to be passed in whenever the CPU is boosted. The IDs of all current boosts are tracked and a string of them is made available to the user in the debug CPU frequency screen.

For example...
"Frequency: 124185600
boost_counter: 3 dtv"
...would tell the user that the current CPU boost is due to dircache, tagcache and voice. This is very useful in hunting down cases where the CPU appears to be boosted for no good reason, either bugs or user-comprehension.

The patch is provided in two parts:
1) boosttracking.patch adds the capability to do tracking via the new routine cpu_boost_id().
2) boosttrackingused.patch then uses this capability in most parts of the main rockbox code.

This patch only enables boost tracking for targets where MEM > 1, so as not to increase Archos binary size (although it probably doesn't make much difference).
For cases (e.g. plugins/codecs) where routines call the original cpu_boost() routine, a '?' character is used as the boost ID. In future the plugin/codec APIs could have cpu_boost_id added, or the original cpu_boost could be removed.
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 11 October 2006, 10:18 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Added to CVS some time back.
Comment by Steve Bavin (pondlife) - Wednesday, 20 September 2006, 13:12 GMT+2
Comment by Steve Bavin (pondlife) - Wednesday, 20 September 2006, 13:13 GMT+2
To add tracking capability:
(application/octet-stream)    boosttracking.patch (4.9 KiB) 
 apps/debug_menu.c        |   16 +++++++++------
 firmware/system.c        |   48 +++++++++++++++++++++++++++++++++++++++++++----
 firmware/export/system.h |   28 ++++++++++++++++++++++++++-
 3 files changed, 81 insertions(+), 11 deletions(-)

Comment by Steve Bavin (pondlife) - Wednesday, 20 September 2006, 13:15 GMT+2
To use this capability (after above patch):
(application/octet-stream)    boosttrackingused.patch (7.3 KiB) 
 apps/main.c                |    4 ++--
 apps/tagcache.c            |   14 +++++++-------
 apps/tagtree.c             |   16 ++++++++--------
 apps/tree.c                |    8 ++------
 firmware/common/dircache.c |    6 +++---
 apps/playback.c            |    6 +++---
 apps/pcmbuf.c              |    2 +-
 7 files changed, 26 insertions(+), 30 deletions(-)

Loading...