Warning: mysqli_real_connect(): Headers and client library minor version mismatch. Headers:50625 Library:50543 in /sites/rockbox.org/flyspray/adodb/drivers/adodb-mysqli.inc.php on line 108 FS#6052 : more responsive skip



FS#6052 - more responsive skip

Attached to Project: Rockbox
Opened by RealNameCanBeAskedFor (MHen) - Sunday, 24 September 2006, 05:47 GMT
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Operating System Archos Player
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This path improved the responsiveness of the skip commands while the buffer is filled with data. In particular, it allows you to skip during the first seconds of a song playing.

This is achieved by simply removing all pending MPEG_NEED_DATA from the mpeg_queue when inserting a skip there. Thus preventing the skip to be delayed by the loading of no-more-needed data.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Thursday, 19 October 2006, 11:43 GMT
Reason for closing:  Accepted
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 25 September 2006, 11:35 GMT
Looks nice and simple. I think we could commit it right away.

I think I'd like the function to be called queue_remove_from_head().
Comment by RealNameCanBeAskedFor (MHen) - Monday, 25 September 2006, 20:40 GMT
I am very happy, you like this patch. I attach is the same patch with the function renamed.
Comment by Ryan Sawhill (ryran) - Monday, 25 September 2006, 21:32 GMT
Comment by Linus Nielsen Feltzing (linusnielsen) - Thursday, 19 October 2006, 08:03 GMT
Oooops, looks like I forgot about this one. Can I have your real name for the credits?
Comment by RealNameCanBeAskedFor (MHen) - Thursday, 19 October 2006, 10:20 GMT
Yes, after a while I was a bit confused, what to do next.

Of course you can have my real name.
Comment by Linus Nielsen Feltzing (linusnielsen) - Thursday, 19 October 2006, 10:22 GMT
You do realize that I will put your name in the CREDITS file?
Comment by RealNameCanBeAskedFor (MHen) - Thursday, 19 October 2006, 11:33 GMT
Yes, I know that. I read that even before I started programming Rockbox (at http://www.rockbox.org/docs/contributing.html) and it's fine with me.

To explain my attitue in a few sentences: It's okay that anyone who reads something I wrote knows my name. But I want to avoid that anyone knowing my name can easily get a list of all things I wrote. Not because I have anything to hide, but because I do not have any control about that data. Who knows what a future employer will find in 30 years time, when he searches the Internet for my name.

But I'm not fanatic about that. The only sensible format of a credits file is plain text. To have my name in there is okay with me.