Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6056 - No text under pictures non displayed...

Attached to Project: Rockbox
Opened by TheKind (TheKind) - Sunday, 24 September 2006, 13:18 GMT+2
Last edited by Nicolas Pennequin (nicolas_p) - Thursday, 03 July 2008, 17:37 GMT+2
Task Type Bugs
Category Themes
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Player Type All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hello,
if you preload a picture and don't show it, you can't write any text where the image should be when it is shown.

I made a preview of the problem on a wps attached.

Would like to add shadow on album art and other things, but cause of this bug i can't...

Thanks for fixing that.
   bugreport.zip (42.5 KiB)
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Thursday, 03 July 2008, 17:37 GMT+2
Reason for closing:  Wont Fix
Additional comments about closing:  This is a limitation of how WPS rendering is done. It's easy to work around it.
Comment by Jonas Häggqvist (rasher) - Sunday, 24 September 2006, 14:09 GMT+2
I believe this is a valid report, although it should be verified (by the submitter, preferably) with a clean cvs build.

The problem is unrelated to album art.
Comment by TheKind (TheKind) - Sunday, 24 September 2006, 14:18 GMT+2
Yeah i know that, but i only was saying why i would like it to be fixed :D
Comment by Jonas Häggqvist (rasher) - Sunday, 24 September 2006, 14:30 GMT+2
I just confirmed this with a clean CVS build simulator and the provided test-case (although for some reason neither the clock nor the background image worked in the simulator, the bug was very much visible).

Definitely valid.
Comment by TheKind (TheKind) - Sunday, 24 September 2006, 15:01 GMT+2
Still Unconfirmed ?

Thanks Jonas
Comment by Dominik Riebeling (bluebrother) - Sunday, 24 September 2006, 15:01 GMT+2
The tracker should _never_ be used to report "bugs" against inofficial builds unless the reporter states that this behaviour is also present in the official build (and he can reproduce it with a current cvs build!) in the first place. The tracker gets abused for support requests and similar pretty much recently which clutters it and degrades its usability. Thus I find it unacceptable to report against inofficial builds.

Just my 2¢.
Comment by TheKind (TheKind) - Sunday, 24 September 2006, 15:10 GMT+2
This bug is on officials releases o_O!

It is unrelated to Album Art!

Screenshot made with Uisimulator with non-modified rockbox:
(Used the wps in the first post)
   Official build.JPG (6 KiB)
Comment by TheKind (TheKind) - Monday, 25 September 2006, 17:59 GMT+2
Any updates?
Comment by Nicolas Pennequin (nicolas_p) - Saturday, 07 April 2007, 04:32 GMT+2
I have a solution for the problem.
The test WPS clearly shows the problem is solved (although the text under the picture doesn't reappear instantly), and other WPSs don't seem to be broken.
I might commit the patch but it needs to be cleaned up a bit first and the issue discussed.
   images.patch (3.9 KiB) 
 apps/gui/gwps-common.c |   33 +++++++++++++++++++++++++++++----
 apps/gui/gwps.h        |    3 +++
 2 files changed, 32 insertions(+), 4 deletions(-)

Comment by Nicolas Pennequin (nicolas_p) - Sunday, 18 November 2007, 14:58 GMT+2
I never committed the patch above because it became outdated and felt a bit clumsy anyway.
I've committed something that aims to fix similar problems, but doesn't quite fix this one.

A solution is to make the disappearing text lines dynamic by adding %?mh<> conditionals in each of them. I know it's a bit hackish, but I prefer having a hack in a WPS than in the displaying code.

The more general issue is very similar to  FS#6827 : static vs. dynamic. Dynamic things will always overwrite static things. To avoid this, there are several solutions, including forcing the static elements to become dynamic.
However, the best solution is to avoid overlapping, as the WPS code wasn't meant for it anyway.
Comment by Marc Guay (Marc_Guay) - Thursday, 03 April 2008, 00:48 GMT+2
Has this been made irrelevant by viewports?
Comment by Nicolas Pennequin (nicolas_p) - Friday, 04 April 2008, 19:27 GMT+2
I don't think viewports have solved the issue, but I'm tempted to close this as "Not a Bug". It's more of a limitation of the WPS displaying code. I think allowing overlap would require a complete restructuring of the displaying code and frankly it's not on my priority list.

Loading...