Rockbox

Tasklist

FS#6097 - Voice "Shutting down"

Attached to Project: Rockbox
Opened by Will Robertson (aliask) - Sunday, 01 October 2006, 10:48 GMT
Last edited by Dominik Riebeling (bluebrother) - Monday, 17 September 2007, 10:13 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Just a small patch to enable the voicing of the splash "Shutting down", so you can tell at what point to stop holding "play" on the iPods if you can't see the screen.
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Monday, 17 September 2007, 10:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  addressed by  FS#6159 
Comment by Jonas Häggqvist (rasher) - Sunday, 01 October 2006, 11:35 GMT
I can't see any reason not to do this, so if no one yells at me (in say, the next couple of days), I'll commit this.

In the same vein, a "Rockbox is ready" voice on startup might be useful (but should probably only be voiced if there's nothing to resume, or Rockbox isn't set to resume). I guess that's for another patch though, but I thought I'd throw the idea out somewhere.
Comment by Will Robertson (aliask) - Sunday, 01 October 2006, 11:44 GMT
Hrm, that's not a bad idea, and it wouldn't exactly be difficult to do. I'll knock up a quick patch for that too.
Comment by Will Robertson (aliask) - Sunday, 01 October 2006, 12:24 GMT
And here it is. I'm not sure that I've put the voicing call in the right place, but it works properly there.
Comment by Jonas Häggqvist (rasher) - Sunday, 01 October 2006, 12:35 GMT
Looks nice to me. I'm strongly in favour of this, and I think I saw someone request it on the mailing list, but perhaps we should ask there to see what the blind users want?

After all, it could be that they'd simply be annoyed by it, and I just realised that the browser speaks on startup if you have voice files/directories on. I still think it'd be a nice idea though, especially for blind users' first boot (since file and directory voicing isn't on by default).
Comment by Jonas Häggqvist (rasher) - Sunday, 01 October 2006, 12:40 GMT
And that was just dead wrong, the first folder/file doesn't seem to be voiced on boot. More reason to add the startup message.
Comment by Jonas Häggqvist (rasher) - Sunday, 01 October 2006, 12:46 GMT
I just fired off a message to the users list to ask for opinions.
Comment by Steve Bavin (pondlife) - Sunday, 01 October 2006, 15:00 GMT
Personally I'd rather just see a fix for the bug where the first directory/file is voiced when the tree is displayed. Then add a "Shutting down" to the standard voice file and have this played on closedown if the voice menus are enabled.

Also, I wouldn't want to hear a startup message if "Resume on startup" is enabled.
Comment by Jonas Häggqvist (rasher) - Sunday, 01 October 2006, 16:10 GMT
The mailing list responses so far seems to indicate that people are interested in both features.

> Personally I'd rather just see a fix for the bug where the first directory/file is voiced when the tree is displayed.

True, but this still doesn't fix the "first time user" issue. IIRC, the default setting has both file and dir voicing off, so there won't be any feedback the first time you start Rockbox (or if you don't use dir and file voicing at all, or use .talk clips and don't have a talk clip for the first file in the browser).

> Then add a "Shutting down" to the standard voice file and have this played on closedown if the voice menus are enabled.

Agree, shuttingdown.patch above does this.

> Also, I wouldn't want to hear a startup message if "Resume on startup" is enabled.

Agree again, rockbox_ready.patch above checks for resume on startup.

As a minimum, shuttingdown.patch is definitely commit-ready as far as I can tell.
Comment by Will Robertson (aliask) - Friday, 13 October 2006, 05:39 GMT
Just wanted to give this a bump to see if this is still "commit worthy" :)
Comment by Steve Bavin (pondlife) - Friday, 13 October 2006, 06:20 GMT
shuttingddown.patch should be ok.

I fixed the problem so the initial directory/file is now voiced when you start up (if you have the option enabled), so please retest/update rockbox_ready.patch to ensure it doesn't talk in this case. I would check myself, but am not at my own PC right now.
Comment by Will Robertson (aliask) - Friday, 13 October 2006, 10:07 GMT
I've updated the rockbox_ready.patch to include checks for both file voicing and directory voicing, and disables the "rockbox ready" clip if either are turned on.
I havn't tested this patch further than simply compiling, as I don't have any rockbox compatible devices at home at the moment, so this should probably be checked first.
Comment by Will Robertson (aliask) - Sunday, 22 October 2006, 01:13 GMT
I've now tested rockbox_ready_v2.patch and it works exactly as it should. Here's hoping for a commit.
Comment by Nils Wallménius (nls) - Sunday, 02 September 2007, 09:07 GMT
A different patch has been committed that added voicing of "Shutting Down"
Comment by Daniel Dalton (ddalton) - Monday, 17 September 2007, 09:12 GMT
This task can probably be closed since it was included in p6159 which has been committed.

Loading...