Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6138 - Be more talkative in info menu

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Saturday, 07 October 2006, 06:19 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 24 October 2007, 13:04 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Under the Rockbox info screen, speak the estimated remaining battery
time as well as the buffer size.

Under the version (credits) option, do speak the firmware version
number (spell it).

I'm a new Rockbox user, I'm blind and I'm a programmer. There's lots of
things I'd like my player to tell me. I thought I'd start with something
simple while I learn how to go about contributing. Thanks.
   rb-info-talk-more.diff (1.8 KiB) 
 rockbox-devel/apps/lang/english.lang |   14 ++++++++++++++
 rockbox-devel/apps/main_menu.c       |   12 ++++++++++++
 2 files changed, 26 insertions(+)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 24 October 2007, 13:04 GMT+2
Reason for closing:  Out of Date
Comment by Stephane Doyon (sdoyon) - Saturday, 14 October 2006, 03:21 GMT+2
New version: The version strings isn't actually spoken from the credits
plugin, of course... Just have the version spelled with the other stuff
under the info menu.
   rb-info-talk-more2.diff (1.8 KiB) 
 rockbox-devel/apps/lang/english.lang |   14 ++++++++++++++
 rockbox-devel/apps/main_menu.c       |   11 +++++++++++
 2 files changed, 25 insertions(+)

Comment by daniel (daniel) - Monday, 11 June 2007, 11:43 GMT+2
I have made a change to this patch. It looks for main_menu.c in the menus folder under apps. Before it looked for main_menu.c in the apps folder. Hope this is ok. Thanks
   sayinfo.diff (1.9 KiB) 
 rockbox-devel/apps/lang/english.lang |   14 ++++++++++++++
 rockbox-devel/apps/menus/main_menu.c |   11 +++++++++++
 2 files changed, 25 insertions(+)

Comment by Daniel Dalton (ddalton) - Sunday, 05 August 2007, 07:01 GMT+2
I have updated this patch.
It just had a few errors but now it should compile and apply fine.
Use p0 to add it.
   sayinfo.diff (1.7 KiB) 
 apps/lang/english.lang |   16 +++++++++++++++-
 apps/menus/main_menu.c |   10 ++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)

Comment by Daniel Dalton (ddalton) - Thursday, 23 August 2007, 12:32 GMT+2
Update so it now applies cleanly and compiles on the latest svn build. Also I have got the time to be spoken before the disk free info.
Requires
fs#7647
Here it is...
   say_info_screen.diff (2.1 KiB) 
 apps/menus/main_menu.c |   32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

Comment by Daniel Dalton (ddalton) - Thursday, 23 August 2007, 12:45 GMT+2
Sorry about the last patch forgot to include the lang part.

Anyway here is the complete patch again. Can someone test it and make sure it is working?
Requires
 FS#7647 
   fix_info.diff (2.4 KiB) 
 apps/lang/english.lang |    2 +-
 apps/menus/main_menu.c |   32 ++++++++++++++++++--------------
 2 files changed, 19 insertions(+), 15 deletions(-)

Comment by Daniel Dalton (ddalton) - Friday, 21 September 2007, 08:42 GMT+2
Should now use
 FS#7798 
Comment by Daniel Dalton (ddalton) - Sunday, 07 October 2007, 11:38 GMT+2
Resinced to r15011.
My patch ( FS#7897 ) was committed and changed some rtc code in main_menu.c.
Anyway here is an update compiles and applies fine on the latest svn.

Also added speaking of the total disk size.

Requires
 FS#7798 
Here it is.
   speak_info_screen.patch (1.8 KiB) 
 apps/lang/english.lang |    4 ++--
 apps/menus/main_menu.c |   14 +++++++++++---
 2 files changed, 13 insertions(+), 5 deletions(-)

Loading...