Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6164 - PLAY action executes again on exit from settings_save_config()

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Wednesday, 11 October 2006, 03:35 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 22 July 2007, 07:50 GMT+2
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

After saving settings, the release action for the PLAY button is executed
again from the file browser, going to WPS and toggling playback...

I believe this patch should fix this detail.
   settings_save-screenchange (0 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 22 July 2007, 07:50 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  fixed a while ago. trying not to reintroduce.
Comment by Stephane Doyon (sdoyon) - Wednesday, 11 October 2006, 03:37 GMT+2
Woops, here's the attachment
   settings_save-screenchange.diff (0.4 KiB) 
 rockbox-devel/apps/settings.c |    1 +
 1 file changed, 1 insertion(+)

Comment by Jonathan Gordon (jdgordon) - Thursday, 30 November 2006, 15:30 GMT+2
Right idea, but thats not the best place for it.
signalscreenchange() shhuold only be called in functions which actually have a button loop,
Hopefully the new menu system will be commited soon which will solve this problem.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 26 December 2006, 22:55 GMT+2
OK, my nano doesnt like pressing play in the vkeyboard, So i dont know if this fixes your problem or not. so, can you replace BUTTON_PLAY with BUTTON_PLAY|BUTTON_REL in apps/keymaps/keymap-ipod.c line 159 and let me know if that fixes it?
Comment by Jonathan Gordon (jdgordon) - Monday, 19 February 2007, 08:02 GMT+2
just checking if this is still an issue?

Loading...