Rockbox

Tasklist

FS#6166 - X5 power button mapping should be on release

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Wednesday, 11 October 2006, 01:48 GMT
Last edited by Alex Parker (BigBambi) - Saturday, 05 June 2010, 21:09 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System iAudio X5
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

The keymap for the X5 binds actions to presses of the POWER button.
The button driver acts on repeats though. So whenever you hold the button
to shut off the player, it first executes the action for POWER in the
current context, and then shuts down. The action's effect wil probably have
been forgotten by the time the device reboots, so it's not all that important,
but it nags me: I'm holding the button waiting for confirmation that it's
shutting down and there's a spurious effect :-). I believe the correct
thing to do is to trigger on release.

I believe this patch should fix this.
This task depends upon

Closed by  Alex Parker (BigBambi)
Saturday, 05 June 2010, 21:09 GMT
Reason for closing:  Out of Date
Comment by Michael Sevakis (MikeS) - Tuesday, 07 November 2006, 00:33 GMT
I think that the power button should be reserved for special functions if it's needed but not used in general. There's already too many ways to exit a menu or go back. Power/rec/left...it's kind of over the top imho. :P
Comment by Stephane Doyon (sdoyon) - Saturday, 11 November 2006, 04:07 GMT
OK, that makes sense.

I don't necessarily agree that having multiple keys do the same thing is
bad, but I do agree that POWER ought to be used as a last resort.

How about this:
-take POWER out of the standard context. AFAICT no context relies on it
exclusively: there's (usually?) LEFT or REC to cancel.
-Change FM_STOP to long REC.
-Change ACTION_PS_RESET to REC.
Comment by Rani Hod (RaeNye) - Sunday, 05 August 2007, 13:30 GMT
The problem is that X5 is missing a STOP/CANCEL button:
there are 4 directions, PLAY, REC, SELECT and POWER.

(the remote has the same number of buttons but they are structured in a weird way:
VOL+, VOL-, MENU on one slider; PREV, PLAY/POWER, NEXT on another slider and separate REC, MODE buttons.)

The problem with sdoyon's suggestion is twofold:
-POWER exits many plugins which cannot spare another button.
-REC returns to Main Menu everywhere else.

The programmatically clean way to solve everything is deciding that POWER should be used exclusively to return to Main Menu, exiting plugins, stopping FM radio, shutting down, etc.
The only "small" problem is that this button is awkward and uncomfortable (it's a sliding switch) :(
Comment by Stephane Doyon (sdoyon) - Monday, 06 August 2007, 04:02 GMT
I'm sorry but I don't fully understand the previous comment.

Let me try to clarify: this isn't about removing POWER from key mappings:
that part was because of Mikes' suggestion. What I am saying is that,
AFAICT, the POWER actions should trigger on release of the button instead
of on press, so that spurious actions don't occur while turning off the
player.

Here's an example to demonstrate my problem: withvoice menus enabled, in
the root menu, on Files, press RIGHT to go to the browser, then turn off
player. While you hold POWER, it'll say "Files". If you have P#6159
applied, it'll say "Files", "Shutting down". And you have to know to keep
holding when you hear the disconcerting spurious utterance of
"Files". A similar situation occurs in other contexts.

The attached patch works around this confusing behavior by having the
action trigger on release.

I'm not familiar with the remote: from the previous comment... is there a
problem with triggering on release of POWER with the remote?
Comment by Rani Hod (RaeNye) - Monday, 06 August 2007, 22:49 GMT
Oh, I thought you meant that the patch changes the key mapping further than trigger-on-release.
IMHO this patch should be committed (when reviewed and tested, obviously) but there's a place for a X5 keymap discussion anyway.
Comment by Stephane Doyon (sdoyon) - Wednesday, 08 August 2007, 03:26 GMT
Sheesh... typo! Here's a new patch.

Well I just tested it and it works for me.

As for other X5 keymap changes, well I had P#6238... Had no comments
on it.
Comment by Stephane Doyon (sdoyon) - Friday, 10 August 2007, 05:00 GMT
It works better if I also catch the condition where power is released
after a repeat has triggered. Since the slider is a bit awkward,
sometimes you hold it longer than intended. So yet another patch.
Comment by Michael Köster (custos) - Saturday, 20 October 2007, 18:03 GMT
I can confirm that the patch works. Nevertheless it would be nice if the same holds for the remote control. Pressing and holding pause causes the same ugly effect there.
I do not yet understand the syntax for the keymap-x5-file, otherwise I would do it by myself. So if someone can do it for me, or even better, explain it to me, or even best, point me to the doxygen-doc where everything is written, you will win an enthusiastic rockbox-fan :-)
Comment by Daniel Dalton (ddalton) - Saturday, 20 October 2007, 21:43 GMT
If you can log on to irc I will try to help you. I am ddalton.
Comment by Stephane Doyon (sdoyon) - Wednesday, 28 November 2007, 04:29 GMT
custos: if you're still there, could you explain a bit more? I'm not
familiar with the remote. Which one is PAUSE?
Comment by Michael Köster (custos) - Wednesday, 28 November 2007, 16:28 GMT
I'm so sorry, because of my relocation and my diploma thesis I completely forgot this issue. However, I apologize.
So, back to topic, below I wrote the url for a picture of the remote control.
http://www.jetmall.net/ProductImages/pic_x5_acc_remote.jpg
The pause button is on the upper right picture. While short pressing the wheel results in pausing the song, long pressing leads to the rockbox menu (database, playlists etc.). If you hold the pause button long enough the system switches the power off but beforehand it shows the rockbox menu (the ugly effect).

Also short pressing the menu button (it's the wheel on the upper left picture) invokes the same rockbox menu. In my opinion this redundancy isn't necessary.
(Long pressing shows the randomplay and song repeating section).

Said this it is furthermore more intuitive if the so called "menu button" leads to the menu and nothing else, the randomplay section should be reached with the red button (upper right picture, red button, by now this button is inoperable) because it is labelled as "A<->B"

Pressing the mode button (upper right picture, in the middle) causes rockbox to show the filesystem.
In short:
Now:
Menu short -> Rockbox menu
Menu long -> randomplay menu
Mode short -> Directory etc.
Mode long -> context menu
red -> nothing
pause short -> pause
pause long -> Rockbox menu
pause very long -> shut down

Would be nice:
Menu short -> Rockbox menu
Menu long -> nothing
Mode short -> Directory etc.
Mode long -> context menu
red short -> randomplay-menu
pause short -> pause
pause long -> nothing
pause very long -> shut down


Should I open a new bug for this?

@ddalton: irc seems to be a bad idea. Aren't you an australian? And i'm from germany, so the time shift might be to large. But if you permit, I would send you an email with my questions.
Comment by Stephane Doyon (sdoyon) - Saturday, 01 December 2007, 04:30 GMT
> So, back to topic, below I wrote the url for a picture of the remote
> control.

OK, but well I'm blind :-).

It would be a lot clearer if you used the same button names as Rockbox does:
PLAY VOL_UP VOL_DOWN REW FF REC MENU MODE

> The pause button is on the upper right picture. While short pressing the
> wheel results in pausing the song, long pressing leads to the rockbox menu
> (database, playlists etc.). If you hold the pause button long enough the
> system switches the power off but beforehand it shows the rockbox menu (the
> ugly effect).

Hmm but since it has mappings on both release and LONG press, that can't
be helped, unless you actually want to move button assignments around.

> Also short pressing the menu button (it's the wheel on the upper left
> picture) invokes the same rockbox menu. In my opinion this redundancy isn't
> necessary.

AFAICT, LONG PLAY stops playback, while MENu invokes the menu (with
playback continuing). So not sure there's really redundancy there?

> Should I open a new bug for this?

If you mean to reassign remote buttons, yes perhaps you should.

Loading...