Rockbox

Tasklist

FS#6266 - Flush buffered audio if user skips during pause

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Tuesday, 31 October 2006, 16:39 GMT
Last edited by Steve Bavin (pondlife) - Tuesday, 31 July 2007, 07:58 GMT
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Operating System SW-codec
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

If the user skips to a new track while playback is paused, upon resuming a little bit of the previous track is played. This patch detects this scenario and flushes the old data before resuming playback.
This task depends upon

Closed by  Steve Bavin (pondlife)
Tuesday, 31 July 2007, 07:58 GMT
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Wednesday, 01 November 2006, 08:05 GMT
Note this patch could be simplified quite a bit, but would break the sim until  FS#6267  is fixed. Hence the need for another global variable :(
Comment by Steve Bavin (pondlife) - Wednesday, 07 February 2007, 10:13 GMT
Sync to SVN
Comment by Steve Bavin (pondlife) - Monday, 30 July 2007, 11:30 GMT
Sync to SVN - please test and report back!
Comment by Peter D'Hoye (petur) - Monday, 30 July 2007, 22:19 GMT
Just tested this on h300 and works as advertised...
feel free to commit ;)
Comment by Johnathon Mihalop (Soul-Slayer) - Tuesday, 31 July 2007, 02:22 GMT
Confirmed on Gigabeat and H10. I think it's commitable :p
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 31 July 2007, 04:42 GMT
Question: what would be the effect if we always flushed when resuming?
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 31 July 2007, 04:50 GMT
Hmmm, maybe I should have had a better look at the patch before asking. It would of course break the crossfading. I was thinking that we shouldn't need to detect this scenario as a special case.

Loading...