This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#6301 - new tags for WPS and tagcache
Attached to Project:
Rockbox
Opened by Robert Kukla (roolku) - Tuesday, 07 November 2006, 15:09 GMT+2
Last edited by Thomas Martitz (kugel.) - Sunday, 05 June 2011, 13:37 GMT+2
Opened by Robert Kukla (roolku) - Tuesday, 07 November 2006, 15:09 GMT+2
Last edited by Thomas Martitz (kugel.) - Sunday, 05 June 2011, 13:37 GMT+2
|
DetailsTagcache is great for selecting and ordering tracks according to
specific criteria and has allowed me to (re-)discover the music in my collection in new and different ways. For example I love being able to listen to the works of an artist in chronological order. But for some things I still needed to create off-line playlists using a number of scripts I wrote which is cumbersome and so I set out to integrate these features into tagcache. This is the result. Unfortunately it is impossible to separate the features from each other, as they sometimes modify the same lines in the source, but I have provided patches for the different stages (starting with simple changes to more complex) ones. I don't know if people feel this should go into CVS or not. I have mainly written it for myself, but if there is interest I can do any required changes. Anyway. Here it goes: 1_relplay.patch relative playtime (relplay) is the cumulative actual playtime divided by cumulative maximum playtime. I prefer the measure to playcount which counts regardless of how much of a track I have played and score which discards the number of times a track was played. For example if you play half of a track twice, these are the values: playcount = 2 relplay = 100 score = 50 If you play them completely you'll get: playcount = 2 relplay = 200 score = 100 2_comment.patch This adds the comment field from id3 and vorbis tags to WPS (%fC, %FC) and tagcache. That is where I have stored special version info (live, remix etc) and it helps me to not have to listen to the same song again and again in different incarnations. For example: "browse" -> genre ? comment !~ "live" & comment !~ "mix" -> artist -> album -> title "live" -> artist ? comment !~ "live" -> album -> title 3_lyrics+albumart.patch I have about 2000 lyrics files of different formats to be used with the excellent plugin sncviewer: http://forums.rockbox.org/index.php?topic=2372.0 and it is difficult to remember which tracks have lyrics and which don't. So this patch creates a WPS tag (use either plain %fl or %?fl<none|txt|snc|lrc|lrc8>) and a tagcache tag for tracks with lyrics. For example: "lyrics" -> lyrics -> genre -> artist -> title "need timestamps" -> genre ? lyrics = "TXT" -> artist -> title Similar for album art. The WPS code %fa will indicate if a track has an associated image file. Since I have a h120, I am only interested in *.jpg files, but it can be extended to include *.bmp files if so required. "no album art" -> genre ? albumart = "<Untagged>" -> artist -> title I use it with patch: http://forums.rockbox.org/index.php?topic=2372.msg16986#msg16986 4_rating.patch This patch adds the rating (which was replaced by score) back into rockbox as WPS tag %rr and it can also be used with tagcache: For example: %format "fmt_best" "%01 %s" rating title %limit = "100" %sort = "inverse" "best of" -> genre ? comment !~ "live" & rating > "0" -> title = "fmt_best" 4_set_rating.patch Displaying a rating is not much good if you can't set it, so this patch re-enables the set rating code that is still included in rockbox. 4_set_rating_alt.patch Personally I find the original settings screen a little clumsy, so I have provided an alternative method. To install, pick one of the patches (two for level 4) and patch with -p0 from the root of the rockbox source tree. Enjoy. :) 
1_relplay.patch
(2.6 KiB)
apps/tagcache.c | 9 ++++++--- apps/tagcache.h | 2 +- apps/tagtree.c | 1 + 3 files changed, 8 insertions(+), 4 deletions(-)
2_comment.patch
(8.1 KiB)
apps/metadata.c | 4 ++++ apps/tagcache.c | 18 ++++++++++++------ apps/tagcache.h | 8 ++++---- apps/tagtree.c | 2 ++ apps/gui/gwps-common.c | 3 +++ firmware/id3.c | 11 +++++++++++ firmware/export/id3.h | 1 + 7 files changed, 37 insertions(+), 10 deletions(-)
3_lyrics+albumart.patch
(12.2 KiB)
apps/metadata.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++- apps/tagcache.c | 24 ++++++++--- apps/tagcache.h | 8 +-- apps/tagtree.c | 4 + apps/gui/gwps-common.c | 13 ++++++ firmware/id3.c | 11 +++++ firmware/export/id3.h | 7 +++ 7 files changed, 160 insertions(+), 11 deletions(-)
4_rating.patch
(15.3 KiB)
apps/metadata.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++- apps/tagcache.c | 37 +++++++++++------ apps/tagcache.h | 10 ++-- apps/tagtree.c | 16 ++++++- apps/gui/gwps-common.c | 14 ++++++ firmware/id3.c | 11 +++++ firmware/export/id3.h | 8 +++ 7 files changed, 178 insertions(+), 22 deletions(-)
4_set_rating.patch
(0.6 KiB)
apps/onplay.c | 6 ++++++ 1 file changed, 6 insertions(+)
4_set_rating_alt.patch
(1.9 KiB)
apps/onplay.c | 43 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-) |
This task depends upon
Closed by Thomas Martitz (kugel.)
Sunday, 05 June 2011, 13:37 GMT+2
Reason for closing: Out of Date
Additional comments about closing: There doesn't seem to be interest in this anymore. Open a new task if this is wrong.
Sunday, 05 June 2011, 13:37 GMT+2
Reason for closing: Out of Date
Additional comments about closing: There doesn't seem to be interest in this anymore. Open a new task if this is wrong.
Each higher number cumulatively includes the prior ones?
lyrics & albumart are now stored as an integer in the database rather than as text. This is computational more efficient, doesn't need the two extra data files but most importantly allows to dynamically update the database. For example when a *.txt lyrics file is synced to a *.lrc file, the wps and database will change to reflect this on the next re-buffer event.
As a disadvantage one needs to specify the numeric value in search conditions. (i.e. 'lyrics = "4"' instead of 'lyrics = "TXT"').
6_dayssince.patch
Only useful for targets with RTC (written for my modded h1x0). The patch introduces two new tags: dayssinceplayed and dayssinceadded and can be used in tagnavi_custom.config like for example:
%format "fmt_dsp" "%d %s" dayssinceplayed title
%menu_start "played" "played"
"last n days" -> genre ? dayssinceplayed >= "0" & dayssinceplayed < "" -> artist -> title = "fmt_dsp"
"last week" -> genre ? dayssinceplayed >= "0" & dayssinceplayed < "7" -> artist -> title = "fmt_dsp"
"last month" -> genre ? dayssinceplayed >= "0" & dayssinceplayed < "31" -> artist -> title = "fmt_dsp"
"before last month" -> genre ? dayssinceplayed > "30" -> artist -> title = "fmt_dsp"
Equivalent for dayssinceadded. This should also answer the request in a forum thread which I can't find right now (not much luck with search engines recently) to display recently uploaded tracks (if auto-update is enabled for database).
As usual the higher numbers include the lower numbered patches, but in addition you will need one of the set_rating patches to be able to set the rating.
- that leaves: lyrics, albumart, rating and relplay