Rockbox

Tasklist

FS#6334 - Star plugin locks up device after selecting play.

Attached to Project: Rockbox
Opened by Douglas Valentine (Dwyloc) - Wednesday, 15 November 2006, 18:01 GMT
Last edited by Antoine Cellerier (dionoea) - Tuesday, 16 October 2007, 08:05 GMT
Task Type Bugs
Category Games
Status Closed
Assigned To No-one
Operating System iPod Nano
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The Star plugin locks up my player when I select play and a reboot is required to exit the plugin.

Tested with the current ipod nano CVS build from 15 Nov 17:29.

steps to reproduce.

1. reboot ipod nano and clear config settings on bootup.
2. Open the menu and select star plugin from the Browse plugins menu.
3. Press select to start playing
At this stage the game status bar will be displayed and the player will lockup and require a reboot to exit.
This task depends upon

Closed by  Antoine Cellerier (dionoea)
Tuesday, 16 October 2007, 08:05 GMT
Reason for closing:  Fixed
Comment by Pierre Jestin (Pierre) - Saturday, 07 April 2007, 18:35 GMT
It also does it on my Nano. I saw an iPod Video and there is a fading. Someone should do a patch to put off this fading on the Nano.
Comment by Rudolf Vavruch (krokodil) - Wednesday, 27 June 2007, 15:35 GMT
Same problem here.

Running r13725-070627
iPod Nano 2GB.

After selecting Play my iPod was frozen on the menu and disconcertingly heating up. I could hear no music (wasn't playing any but I read in another bug report that there was music playing although the plugin was frozen).

I had trouble rebooting it too managed to get it rebooted after a few hours.
Comment by Antoine Cellerier (dionoea) - Tuesday, 25 September 2007, 12:56 GMT
Could someone confirm that this still happens on newer builds? Does it also happen in the simulator? (I only have an iPod Video and an archos Recorder v1 so I'm unable to test on Nano. I'll have a look at the sim version later today)
Comment by Douglas Valentine (Dwyloc) - Tuesday, 25 September 2007, 13:08 GMT
Yes it still happens with today's build, on my iPod nano, if memory servers correctly one or more other target also had the problem.

So the issue is worked round in SVN by disabling the screen translation effect on the other effected targets but for some reason it has not been disabled for the nano.
Comment by Antoine Cellerier (dionoea) - Tuesday, 25 September 2007, 15:16 GMT
Works fine in the nano simulator :/

The only thing which must be different on the real target is the rb->lcd_update_rect call. Could you try adding a bunch of { int fd = rb->open( "/star_debug.txt", O_CREAT|O_WRONLY|O_APPEND ); rb->fdprintf( fd, __FILE__ " %s %d: %d %d %d %d %d\n", __func__, __LINE__, center_x, x, center_y, y, step ); rb->close( fd ); } in the star_transition_update function, lines 539 to 544 and paste the contents of the star_debug.txt file if it looks interesting ? (I'm guessing that the x or y values must somehow overflow an authorised range ... although it'd be weird that this would cause a crash)
Comment by Antoine Cellerier (dionoea) - Monday, 15 October 2007, 12:15 GMT
Douglas, could you give that a try?
Comment by Douglas Valentine (Dwyloc) - Monday, 15 October 2007, 15:18 GMT
Sadly I don't have access to by build environment at the moment but I believe that amiconn worked out what the problem is if you look at the IRC logs
http://www.rockbox.org/irc/reader.pl?date=20071012 at 21:46 as the problem seems to effect a number of other targets as well.

I can have a look at it next weekend if its still required when I will hopefully have time to setup my new laptop with VMWare.
Comment by Antoine Cellerier (dionoea) - Monday, 15 October 2007, 21:02 GMT
Thanks for the hint. I've committed a fix (if I understand amiconn's diagnosis correctly). I'd appreciate if you could test a dev build.
Comment by Douglas Valentine (Dwyloc) - Monday, 15 October 2007, 23:49 GMT
Yes that seems to have fixed it on my nano thanks.
Comment by Antoine Cellerier (dionoea) - Tuesday, 16 October 2007, 08:05 GMT
Cool. I'll close the task.

Loading...