Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6358 - Check for illegal chars on filename creation

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Monday, 20 November 2006, 01:00 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 03 July 2007, 11:53 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To Jonas Häggqvist (rasher)
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch adds an additional check to fat_checkname to disallow the following characters: " * / : < > ? \\ | as per the FAT spec (p 29 of FAT32spec103.pdf). I have tested it to work and fix a problem (previously you could create filenames with (at least) some of these characters. This patch manages to fix that.
(application/octet-stream)    fatcheck.diff (1.3 KiB) 
 fat.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 03 July 2007, 11:53 GMT+2
Reason for closing:  Accepted
Comment by Jonas Häggqvist (rasher) - Monday, 20 November 2006, 01:27 GMT+2
Updated to use strchr() rather than manually looping. Checked on H120 target.
(application/octet-stream)    fatcheck_2.diff (1.2 KiB) 
 fat.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comment by Magnus Holmgren (learman) - Tuesday, 03 April 2007, 19:13 GMT+2
Some further updates, to recude size a little, and check some more things.
Also reduces the size of the char2dos function (~170 bytes on ColdFire).
Checked on H120 too.
(application/octet-stream)    fat_check_3.diff (1.8 KiB) 
 firmware/drivers/fat.c |   51 +++++++++++++++++++++----------------------------
 1 file changed, 22 insertions(+), 29 deletions(-)

Loading...