Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6387 - Get rid of SYSFONT_PITCH_xxx strings

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 27 November 2006, 22:25 GMT+2
Last edited by Nils Wallménius (nls) - Sunday, 05 August 2007, 21:23 GMT+2
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I saw the discussion in IRC. As I'm the last person who touched the pitch screen code...

Also changed the intial pitch screen mode to be 'semitone' (it was 'percent' before)
(application/octet-stream)    dispose_sysfont_pitch.patch (6.2 KiB) 
 apps/screens.c         |   30 ++++++++++++------------
 apps/lang/english.lang |   60 +++++++++++++++++++++++++++++++++++--------------
 2 files changed, 59 insertions(+), 31 deletions(-)

Closed by  Nils Wallménius (nls)
Sunday, 05 August 2007, 21:23 GMT+2
Reason for closing:  Accepted
Comment by Peter D'Hoye (petur) - Friday, 01 December 2006, 09:25 GMT+2
Alexander, the reason I didn't commit this one last night is because I'm not 100% convinced that duplicating strings to rename them is the way to go. As the issue isn't very critical I think it may be better to do a major lang file cleanup. And maybe first get rid of all sysfont stuff everywhere. This means a bit of work in recording screen,...
Comment by Alexander Levin (fml2) - Friday, 01 December 2006, 12:56 GMT+2
D'accord. This should be discussed with someone who's more familiar with the lang file logic and can better estimate the implications.

BTW: some string IDs (e.g. PITCH) were present since long ago, I just introduced those missing.

Thank you very much Peter!

Loading...