This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#6388 - Pitch as a setting
Attached to Project:
Rockbox
Opened by Stephane Doyon (sdoyon) - Tuesday, 28 November 2006, 03:51 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 15:26 GMT+2
Opened by Stephane Doyon (sdoyon) - Tuesday, 28 November 2006, 03:51 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 15:26 GMT+2
|
DetailsIs there any reason why the pitch value isn't saved along with other
settings? I would like it to persist across reboots, and possibly to be able to set it through a config file. Here's a patch, seems to work for me but it would need review. 
pitch.diff
(3.3 KiB)
rockbox-devel/apps/dsp.c | 8 +++----- rockbox-devel/apps/onplay.c | 6 ------ rockbox-devel/apps/settings.c | 5 +++++ rockbox-devel/apps/settings.h | 2 ++ rockbox-devel/apps/sound_menu.c | 3 +++ 5 files changed, 13 insertions(+), 11 deletions(-) |
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Sunday, 05 August 2007, 15:26 GMT+2
Reason for closing: Out of Date
Additional comments about closing: patch very out of date.. if someone really wants this a new patch is needed
Sunday, 05 August 2007, 15:26 GMT+2
Reason for closing: Out of Date
Additional comments about closing: patch very out of date.. if someone really wants this a new patch is needed
podcasts. Long time audio book readers develop this ability to understand
fast speech, up to maybe 2times when concentrating and in quiet
surroundings. Reading outloud is relatively slow :-). Blind readers have
gotten used to speeding it up because we've had those specialized
cassette players with adjustable speed available for over 25years. And
when you're actually working with an audio book (as opposed to just
relaxing) then there's a productivity angle.
Later specialized cassette player models (since maybe 15years) also offer
a function to compensate the pitch transpose that occurs when speeding up
playback. Nowadays the digital Daisy players do that in software. That's
like sox's pitch effect I believe: speed up playback but keep the pitch
the same. (Some voicemail services offer that too...) That's a capability
I would dearly like to see added to RB, because high-pitched speech is
less intelligible and somewhat annoying, and I intend to look into
integrating some code for that some day, but that's another story.
Anyway the point was that it's much nicer to have the pitch as a
persistent setting, so that when you turn your player back on and resume
playing your audio book, it continues at the speed you had it when you
shut it off.
FS#5668Pitch, adjusted from the Sound Settings Menu, should be treated as permanent. Pitch from the pitch quickscreen should be treated as temporary.
If you only want to change it once, ever, going to a static screen for it isn't so much a cost, whereas that way it doesn't become permanent for those used to adjusting it temporarily anyway.