Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6397 - Selecting a big font while "show path" is enabled craches in the font browser.

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Wednesday, 29 November 2006, 18:25 GMT+2
Task Type Bugs
Category Font/charset
Status Closed
Assigned To No-one
Player Type Iriver H300 series
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Steps to reproduce.
0. Reset settings (optional)
1. Set show path to current directory
2. select ter-32n from the font browser in the menu
3. press left to back out from the font browser

if "show path" is off it works fine.
This task depends upon

Closed by  Peter D'Hoye (petur)
Saturday, 09 December 2006, 11:02 GMT+2
Reason for closing:  Accepted
Comment by Mark Arigo (lowlight) - Wednesday, 29 November 2006, 19:45 GMT+2
This is a bug in gui_list_draw. If list titles are displayed and the screen can only display one line, it deadlocks because it can't draw the list. You'll see it on targets small screens including lcd remotes regardless of whether the remote is plugged in.

I've attached a quick patch.
(application/octet-stream)    list_fix.patch (2.9 KiB) 
 apps/gui/list.c |   21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

Comment by Nils Wallménius (nls) - Wednesday, 29 November 2006, 20:05 GMT+2
The patch fixes the issue for me.
Comment by Peter D'Hoye (petur) - Friday, 08 December 2006, 23:39 GMT+2
I've taken the liberty of moving the define into a function so we don't waste bytes.
Also did some code policing. Tested and fixes the issue too.
(application/octet-stream)    list_fix.patch (8.7 KiB) 
 apps/gui/list.c |   71 ++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 44 insertions(+), 27 deletions(-)

Loading...