Rockbox

Tasklist

FS#6410 - Plugin Disktidy error due to too many nested folders

Attached to Project: Rockbox
Opened by Magnus Lindström (mlind) - Sunday, 03 December 2006, 22:08 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 10 August 2008, 12:46 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Disktidy doesn't finish it's work, but stops with an error when it reaches a specific folder - where I have some Mac OS X apps placed (for portable use).

I moved the folder (containing the apps) up two levels to the root, and this time Disktidy worked as it should.
Moved folder back down one level and it still worked.
Moved folder back down yet another - to it's original position - an got an error.

Seems you cannot have more than 7 levels of sub-folders.
(5 of my 8 were inside the app structure)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 10 August 2008, 12:46 GMT
Reason for closing:  Fixed
Comment by Hugo St-Onge (gorman2001) - Monday, 04 December 2006, 00:10 GMT
Same problem for me.
I have MSN Messenger for Mac on my iPod down one folder from root and I have this error when using Disktidy.
Comment by Magnus Lindström (mlind) - Thursday, 28 December 2006, 10:30 GMT
In the file "dir.c" there is a definition of the constant "MAX_OPEN_DIRS" and it's set to 8.
Seems like a probable cause.
The plugin does not take heed of anything like this.
The plugin opens one directory and then makes a recursive call to the same function to open the next subfolder...
Is this why it in RockBox is possible to browse down deeper than 8 subfolders but not with Disktidy?
Comment by Magnus Lindström (mlind) - Thursday, 28 December 2006, 10:51 GMT
OK. IRC seems to be the place to get answers...
From IRC 10th of december:
[url]http://www.rockbox.org/irc/rockbox-20061210.txt[/url]

[quote]20.32.53 #       * Bger just spotted that disktidy can't enter more then 7 (or 8) levels in the dir tree
20.33.39 #       Bger> (because it doesn't close the dir handle and #define MAX_OPEN_DIRS 8 )
...
20.39.56 #       amiconn> But you cannot close the parent handles, otherwise recursion won't work
[/quote]
Comment by David Dent (the_winch) - Saturday, 06 January 2007, 22:24 GMT
This also causes a problem when disktidy deletes a directory.
The return value of tidy_removedir() is not checked. If it runs out of handles while deleting a directory it will not delete the directory and will not show and error.
Comment by Justin Hannigan (Chronon) - Thursday, 18 October 2007, 04:06 GMT
Interesting. I just discovered this on my F40 -- once again the problem was due to deep directory structure in some portable applications.
Comment by Christopher Williams (christop) - Tuesday, 05 August 2008, 20:14 GMT
What would be the proper solution to this? I'm interested in fixing Disktidy so it works as the user expects it to work.

I think it should continue looking in other directories instead of just quitting on the first error. I also think it should display a message at the end that some directories could not be deleted (or possibly a more descriptive message).

Should the plugin return with an error in case it can't enter some directories, or should it still return success?

I attached a file that includes many clean-ups to the code (I made the application's functions and variables static) and also some fixes for this too-deep directory issue.

Loading...