Rockbox

Tasklist

FS#6512 - Make plugin Disktidy avoid opening too many dirs

Attached to Project: Rockbox
Opened by Magnus Lindström (mlind) - Saturday, 06 January 2007, 21:03 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 10 August 2008, 12:53 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System Iriver H100 series
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The patch makes plugin Disktidy avoid going too deep into nested subfolders.
Due to a recursive function there was a possibility that the plugin tried to open more directories than the maximum 8 allowed.

The patch is only tried on an iRiver H120.

The patch is still in my experimental version and stops and waits for keypress RIGHT if open directories exceed 5.
This was to be able to see what happened.
Also I added line wrapping of the displayed path.

Haven't checked what else has to be done according to RockBox standards
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 10 August 2008, 12:53 GMT
Reason for closing:  Out of Date
Additional comments about closing:  no longer needed
Comment by Paul Louden (darkkone) - Saturday, 06 January 2007, 21:27 GMT
Does it provide an error splash if it can't clean everything?
Comment by Magnus Lindström (mlind) - Saturday, 06 January 2007, 22:58 GMT
Hm. Not yet.
Comment by Paul Louden (darkkone) - Saturday, 06 January 2007, 23:00 GMT
It exits out with an error for a reason: That it cannot complete.

If it's going to continue, it should at least make it very, very clear to the user that the operation was not completed successfully.
Comment by Magnus Lindström (mlind) - Sunday, 07 January 2007, 00:11 GMT
Here's a better one.

Only stops to show what dir it skips - and tells user to push PLAY/SELECT to continue.
When Disktidy is done there first comes a splash that says how many items were deleted, and then another one that says how many dirs it skipped.
Comment by Magnus Lindström (mlind) - Sunday, 07 January 2007, 00:16 GMT
I don't see how I can edit my first post!?!?
It seems like a better idea to put the latest patch there...

Loading...