Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6555 - Volume limiter

Attached to Project: Rockbox
Opened by Will Robertson (aliask) - Sunday, 21 January 2007, 04:35 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 12:53 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As per a request from a friend I've implemented a feature from the iPod original firmware, volume limiting.
You can set a maximum volume, and while in the WPS you can't increase the volume past that point, to avoid blowing up your ears.
The patch has only been tested in the sims, and it bumps the config block version so you'll need to save your settings.
(application/octet-stream)    vlimit.patch (8.6 KiB) 
 apps/lang/english.lang  |   14 ++++++++++++++
 apps/settings.c         |    8 ++++++--
 apps/gui/gwps.c         |   24 +++++++++++++-----------
 apps/settings.h         |    1 +
 apps/sound_menu.c       |    6 ++++++
 firmware/export/sound.h |    2 ++
 firmware/sound.c        |   19 +++++++++++++++++++
 7 files changed, 61 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 05 August 2007, 12:53 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  if someone wants to start this again, imo it shuold be added to setvol() in misc.c and not touch any firmware/ code
Comment by Hepdog (007quick) - Thursday, 15 March 2007, 18:32 GMT+2
This patch is out of sync with current svn. Please update it because it would be really usfull!
Comment by Will Robertson (aliask) - Saturday, 17 March 2007, 10:34 GMT+2
Your wish is my command.
   vlimit.patch (8.3 KiB) 
 apps/settings.c                        |    1 +
 apps/lang/english.lang                 |   14 ++++++++++++++
 apps/gui/gwps.c                        |   24 +++++++++++++-----------
 apps/settings.h                        |    1 +
 apps/menus/sound_menu.c                |    2 ++
 apps/settings_list.c                   |    1 +
 firmware/export/sound.h                |    2 ++
 firmware/sound.c                       |   19 +++++++++++++++++++
 manual/working_with_playlists/main.tex |    2 +-
 9 files changed, 54 insertions(+), 12 deletions(-)

Comment by Hepdog (007quick) - Saturday, 17 March 2007, 15:54 GMT+2
Just to tell you, it is still out of sync! it still works becasue it is just a hunk that changes the manual! lol, how did that get in there?
Comment by Will Robertson (aliask) - Sunday, 18 March 2007, 09:17 GMT+2
Ugh, that file is strange... It's been getting into my patches lately for some reason - svn update doesn't see any difference but svn diff obviously does.
Anyway here's the fixed patch.
   vlimit.patch (7.8 KiB) 
 apps/settings.c         |    1 +
 apps/lang/english.lang  |   14 ++++++++++++++
 apps/gui/gwps.c         |   24 +++++++++++++-----------
 apps/settings.h         |    1 +
 apps/menus/sound_menu.c |    2 ++
 apps/settings_list.c    |    1 +
 firmware/export/sound.h |    2 ++
 firmware/sound.c        |   19 +++++++++++++++++++
 8 files changed, 53 insertions(+), 11 deletions(-)

Comment by Sacha (Angyman) - Sunday, 18 March 2007, 16:58 GMT+2
Very useful!!!! Safety First^^
Comment by Nikkhil (AceNik) - Monday, 16 April 2007, 16:40 GMT+2
sync'ed, can someone please add this already
(application/octet-stream)    vlimit.patch (8.1 KiB) 
 apps/settings.c         |    1 +
 apps/lang/english.lang  |   14 ++++++++++++++
 apps/gui/gwps.c         |   24 +++++++++++++-----------
 apps/settings.h         |    1 +
 apps/menus/sound_menu.c |    2 ++
 apps/settings_list.c    |    1 +
 firmware/export/sound.h |    2 ++
 firmware/sound.c        |   26 ++++++++++++++++++++++----
 8 files changed, 56 insertions(+), 15 deletions(-)

Comment by Dominik Riebeling (bluebrother) - Monday, 16 April 2007, 19:21 GMT+2
The patch contains unnecessary (and unwanted) whitespace changes.
Comment by Nikkhil (AceNik) - Monday, 16 April 2007, 19:40 GMT+2
can anyone fix it , i have no clue what it means
Comment by Will Robertson (aliask) - Tuesday, 17 April 2007, 02:33 GMT+2
When you're making a patch you have to be careful not to include tabs. Rockbox source uses 4 spaces for indentation.
Here's the fixed patch.
   vlimit.patch (7.7 KiB) 
 apps/lang/english.lang  |   14 ++++++++++++++
 apps/settings.c         |    1 +
 apps/gui/gwps.c         |   24 +++++++++++++-----------
 apps/settings.h         |    1 +
 apps/menus/sound_menu.c |    2 ++
 apps/settings_list.c    |    1 +
 firmware/export/sound.h |    2 ++
 firmware/sound.c        |   18 ++++++++++++++++++
 8 files changed, 52 insertions(+), 11 deletions(-)

Comment by Nikkhil (AceNik) - Friday, 04 May 2007, 16:16 GMT+2
Sync'ed
(application/octet-stream)    vlimit.patch (7.7 KiB) 
 apps/lang/english.lang  |   14 ++++++++++++++
 apps/settings.c         |    1 +
 apps/gui/gwps.c         |   24 +++++++++++++-----------
 apps/settings.h         |    1 +
 apps/menus/sound_menu.c |    2 ++
 apps/settings_list.c    |    1 +
 firmware/export/sound.h |    2 ++
 firmware/sound.c        |   18 ++++++++++++++++++
 8 files changed, 52 insertions(+), 11 deletions(-)

Comment by Nikkhil (AceNik) - Monday, 28 May 2007, 20:58 GMT+2
patch needs sync, sound.c & sound.h have bin changed
Comment by Mark (Xebozone) - Saturday, 30 June 2007, 12:20 GMT+2
Can someone please add this to the regular builds?

Loading...