This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#6562 - Scroll wheel for Bubbles on the Sansa E200
Attached to Project:
Rockbox
Opened by Benjamin Brown (foolsh) - Tuesday, 23 January 2007, 00:07 GMT+2
Last edited by Daniel Stenberg (bagder) - Thursday, 07 June 2007, 11:25 GMT+2
Opened by Benjamin Brown (foolsh) - Tuesday, 23 January 2007, 00:07 GMT+2
Last edited by Daniel Stenberg (bagder) - Thursday, 07 June 2007, 11:25 GMT+2
|
DetailsI don't like using the left and right buttons to aim with, it did not seem "natural". So here is bubbles.c with changes that allow using the scroll wheel on the Sansa E200.
|
This task depends upon
Closed by Daniel Stenberg (bagder)
Thursday, 07 June 2007, 11:25 GMT+2
Reason for closing: Accepted
Additional comments about closing: Submitter will work on a different approach
Thursday, 07 June 2007, 11:25 GMT+2
Reason for closing: Accepted
Additional comments about closing: Submitter will work on a different approach
1) You seem to change the mapping for all targets rather than just fixing the Sansa's control scheme (now it seems left/right = 'up'/'down' on all targets). Also, you should provide a patch (diff) file, instead of the full .c, so that it's easier to tell your changes from the original.
2) You haven't provided your full name, which is necessary for any of your work to be committed.
If you hadn't intended for this to be committed, no problem - otherwise, if you can fix the above 2 things, it's fine for SVN. Thanks.
1) The controls did change for all targets because bubbles.c uses the generic keymaps from /apps/plugins/lib/pluginlib_actions.h instead of ifdef'ing them for all targets, i.e rockboy, blackjack, etc. Which I kinda like, but has it drawbacks. I haven't learned how to create a diff file yet. I only started learning C two weeks ago, I couldn't even write a helloworld.c without looking up what to #include.
2) Last name included now!
Thanks
And also when changing the generic button actions in the Sansa's plugin-keymap file it also has an influence on the controls of metronome. So if one wants to avoid that, then this needs some more work - either code exceptions in bubbles.c or invent more actions and try to implement these correctly in the two plugins.
I had an idea to add a section to the keymap file something like left-right_scrolling_for_games it could reflect the other scrolling section just left/right and not up/down. I'll revise this and add these changes when life slows down enough so my head can stop spinning.
I'll see if i can get my hands on an ipod to play with/test out. When/if I get done with this I think it would be useful on spacerocks as well.