Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6568 - Target-specific default theme (font and wps)

Attached to Project: Rockbox
Opened by Dave Chapman (linuxstb) - Wednesday, 24 January 2007, 14:16 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 13 March 2008, 12:01 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To Dave Chapman (linuxstb)
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch adds a target-specific default theme - currently iCatcher, which only affects the font and wps settings.

The intention is to give new users a better first impression of Rockbox than the current default font/wps. However, the downside is the increased boot time due to the .bmp files used by iCatcher.

   default_theme.diff (1.8 KiB) 
 apps/settings_list.c |   28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 13 March 2008, 12:01 GMT+2
Reason for closing:  Out of Date
Comment by MichaelGiacomelli (saratoga) - Friday, 18 January 2008, 20:07 GMT+2
Looking over this patch, why is it necessary to hard code the defaults? I don't understand how rockbox deal with themes, but couldn't the default theme setting be read out of the cfg file generated by wpsbuild.pl rather then hard coded?

Loading...