Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6686 - Pause screen when adding to playlist

Attached to Project: Rockbox
Opened by Mike Holden (mikeholden) - Thursday, 22 February 2007, 19:30 GMT+2
Last edited by Alex Parker (BigBambi) - Sunday, 06 June 2010, 00:50 GMT+2
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When adding a new playlist to the current playlist, the progress screen flashes past so quickly that you can't read it.

This patch adds a 2 second pause once the last file has been added, so you can read the status properly.
   splash1.diff (3.8 KiB) 
 apps/playlist.c |   29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Alex Parker (BigBambi)
Sunday, 06 June 2010, 00:50 GMT+2
Reason for closing:  Rejected
Comment by Mike Holden (mikeholden) - Friday, 23 February 2007, 11:35 GMT+2
I have also noticed that the message displayed in the splash is bogus (it says to press STOP to interrupt, but it has already finished processing so there is nothing to interrupt).

I will make another version of the patch shortly to address that issue as well.

Please disregard this until then!
Comment by Mike Holden (mikeholden) - Monday, 26 February 2007, 21:16 GMT+2
New patch.

The following issues are fixed:

1. When finishing inserting or queueing into a playlist, the final status message is displayed for 0 seconds, making it unreadable.

2. When inserting or queueing shorter playlists, the feedback is useless because it only updates every 10 files. Most of my playlists are for albums, and so many contain 9 files or less.

3. Status message at end of insert/queue operation is bogus. It says to press STOP to interrupt, but there is nothing to interrupt as processing of the playlist is already complete.

The fixes are as follows:

1. Completion status splash is now displayed for 2 seconds.

2. When we start to insert/queue, report status every 1 file. After 50 files, switch to reporting every 10 as before. This makes the feedback useful even for smaller playlists.

3. 2 new messages added which don't mention interrupting the operation.
   splash_v2.diff (3.8 KiB) 
 apps/playlist.c        |   38 ++++++++++++++++++++++++++++++++++----
 apps/lang/english.lang |   28 ++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+), 4 deletions(-)

Comment by Mike Holden (mikeholden) - Thursday, 29 March 2007, 00:15 GMT+2
New version. Fixes minor problem, and sync with latest svn.

Should be good to go now, if anybody feels like testing/committing :-)
   splash_20070328_231153.diff (3.8 KiB) 
 apps/playlist.c        |   38 ++++++++++++++++++++++++++++++++++----
 apps/lang/english.lang |   28 ++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+), 4 deletions(-)

Comment by Paul Louden (Llorean) - Saturday, 11 August 2007, 15:23 GMT+2
Don't these make the whole process slower? One thing I've liked about Rockbox is how quickly one can perform these operations.
Comment by Mike Holden (mikeholden) - Wednesday, 15 August 2007, 13:22 GMT+2
Can't say I've noticed an appreciable slowdown. For the most part, the 2 second sleep on the final message is longer than loading the playlist takes anyway!
Comment by Mike Holden (mikeholden) - Monday, 27 August 2007, 13:19 GMT+2
Synced with latest SVN.
   rockbox_splash_h300_20070827_063001.zip (1.76 MiB)
Comment by Mike Holden (mikeholden) - Sunday, 30 November 2008, 13:06 GMT+2
Sync to latest SVN.

I have been using this patch daily since I created it, and it hasn't skipped a beat. The only concern raised on this tracker and in the mailing list is that the delay is too long, but this was from someone who hadn't actually used the patch. I have reduced the message wait time to 1 second to address this issue. Apart from that, the main delay still remains that of waiting for the disk to spin up, which is the biggest part of the procedure. This patch doesn't perceptibly slow anything down.

Any chance this (minor) change could be considered for 3.1?
   splash_20081130_060001.diff (2.8 KiB) 
 apps/playlist.c |   45 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 41 insertions(+), 4 deletions(-)

Comment by Mike Holden (mikeholden) - Sunday, 30 November 2008, 13:17 GMT+2
Actually, missed out the language file diff. The file just uploaded isn't actually in diff format, simply append the contents to the current english.lang file. I do it this way to get round the problem of svn update barfing on a regular basis because other language strings have been added to the repository.
   english.lang.mrh (0.5 KiB)

Loading...