Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6709 - Theme installer for rbUtil

Attached to Project: Rockbox
Opened by Dominik Wenger (Domonoky) - Thursday, 01 March 2007, 01:17 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hi,
I have added a Theme installer to rbutil.
It uses the page www.rockbox-themes.org.

I also changed the string handling (no more normal static strings, only wxT("FooBar"), should help against the unicode issue).

The patch is not completly ready, it need a bit polishing.

If you want to try, a windows binary is at:
http://b23.org/~domonoky/rbutil.zip

attached is the patch + 2 new xpm files (somehow these xpm files dont like diffing)
(application/octet-stream)    rbutil-theme.patch (138.7 KiB) 
 rbutil/rbutil.ini       |   29 ++
 rbutil/rbutil.cpp       |  205 ++++++++++------
 rbutil/rbutilFrm.h      |    4 
 rbutil/bootloaders.cpp  |  168 ++++++-------
 rbutil/irivertools.cpp  |   94 +++----
 rbutil/wizard_pages.h   |   54 ++++
 rbutil/rbutilApp.cpp    |   18 +
 rbutil/rbutil.h         |    6 
 rbutil/rbutilFrm.cpp    |  361 +++++++++++++++++-----------
 rbutil/wizard_pages.cpp |  368 +++++++++++++++++++++++++----
 rbutil/uninstall_3d.xpm |  599 +++++++++++++++++++++++++-----------------------
 rbutil/rbutil.cbp       |    4 
 12 files changed, 1209 insertions(+), 701 deletions(-)

(application/octet-stream)    themes_3d.xpm (22.1 KiB)
(application/octet-stream)    untools2_3d.xpm (9.6 KiB)
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Thursday, 15 March 2007, 15:04 GMT+2
Reason for closing:  Accepted
Comment by Dominik Wenger (Domonoky) - Tuesday, 06 March 2007, 17:30 GMT+2
updated and synced the patch
(application/octet-stream)    rbutil-theme.patch (137.4 KiB) 
 rbutil/rbutil.ini       |   30 ++
 rbutil/rbutil.cpp       |  205 ++++++++++------
 rbutil/rbutilFrm.h      |    4 
 rbutil/bootloaders.cpp  |  181 +++++++-------
 rbutil/irivertools.cpp  |   94 +++----
 rbutil/wizard_pages.h   |   54 ++++
 rbutil/rbutilApp.cpp    |   18 +
 rbutil/rbutil.h         |    6 
 rbutil/rbutilFrm.cpp    |  361 +++++++++++++++++-----------
 rbutil/wizard_pages.cpp |  362 ++++++++++++++++++++++++-----
 rbutil/uninstall_3d.xpm |  599 +++++++++++++++++++++++++-----------------------
 11 files changed, 1209 insertions(+), 705 deletions(-)

Comment by Dominik Wenger (Domonoky) - Tuesday, 06 March 2007, 17:40 GMT+2
Upps, forgot to add the xpm images.
   rbutil-themes.patch (170.7 KiB) 
 rbutil/rbutil.ini       |   30 +
 rbutil/rbutil.cpp       |  205 +++++----
 rbutil/rbutilFrm.h      |    4 
 rbutil/bootloaders.cpp  |  181 ++++----
 rbutil/irivertools.cpp  |   94 ++--
 rbutil/wizard_pages.h   |   54 ++
 rbutil/themes_3d.xpm    | 1059 ++++++++++++++++++++++++++++++++++++++++++++++++
 rbutil/rbutilApp.cpp    |   18 
 rbutil/rbutil.h         |    6 
 rbutil/rbutilFrm.cpp    |  361 +++++++++-------
 rbutil/wizard_pages.cpp |  362 ++++++++++++++--
 rbutil/uninstall_3d.xpm |  599 ++++++++++++++-------------
 rbutil/untools2_3d.xpm  |  304 +++++++++++++
 13 files changed, 2572 insertions(+), 705 deletions(-)

Comment by Mark Bright (Redbreva) - Tuesday, 06 March 2007, 23:28 GMT+2
Select Install themes, Choose a platform ie Nano, Next, Next, Select top Theme 'Angel' and note the description...

Now Back, Back, and select a different platform, ie 5g Ipod Video, Next, Nextm Select top theme 'Aardvark' and notice that the description abd download size are still the ones for Angel
Comment by Dominik Wenger (Domonoky) - Wednesday, 07 March 2007, 00:31 GMT+2
Bug found an fixed,
thanxs for reporting.

   rbutil-theme.patch (138.2 KiB) 
 rbutil/rbutil.ini       |   30 ++
 rbutil/rbutil.cpp       |  205 ++++++++++------
 rbutil/rbutilFrm.h      |    4 
 rbutil/bootloaders.cpp  |  170 ++++++-------
 rbutil/irivertools.cpp  |   94 +++----
 rbutil/wizard_pages.h   |   54 ++++
 rbutil/rbutilApp.cpp    |   18 +
 rbutil/rbutil.h         |    6 
 rbutil/rbutilFrm.cpp    |  361 +++++++++++++++++-----------
 rbutil/wizard_pages.cpp |  364 +++++++++++++++++++++++++----
 rbutil/uninstall_3d.xpm |  599 +++++++++++++++++++++++++-----------------------
 rbutil/rbutil.cbp       |    6 
 12 files changed, 1212 insertions(+), 699 deletions(-)

Loading...