Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6796 - Put ymargin into scrollinfo

Attached to Project: Rockbox
Opened by Max Weninger (maxwen) - Sunday, 11 March 2007, 08:28 GMT+2
Last edited by Paul Louden (Llorean) - Wednesday, 16 January 2008, 15:22 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

ymargin should be put into scrollinfo like xmargin in startx
so that the scroll_thread becomes independent of any ymargin changes
in the rest of the code during runtime

Tested on X5 and simulators for H120 and IPod Nano
   ymargin_scrollinfo.patch (5.5 KiB) 
 rockbox_svn/firmware/drivers/lcd-16bit.c          |    3 ++-
 rockbox_svn/firmware/export/lcd.h                 |    2 ++
 rockbox_svn/firmware/drivers/lcd-1bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-horz.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-1bit-v.c  |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-2bit-vi.c |    3 ++-
 7 files changed, 14 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Paul Louden (Llorean)
Wednesday, 16 January 2008, 15:22 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  See viewports.
Comment by Max Weninger (maxwen) - Sunday, 11 March 2007, 08:30 GMT+2
Removed unneeded line in lcd.h
   ymargin_scrollinfo.patch (5.3 KiB) 
 rockbox_svn/firmware/drivers/lcd-16bit.c          |    3 ++-
 rockbox_svn/firmware/export/lcd.h                 |    1 +
 rockbox_svn/firmware/drivers/lcd-1bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-horz.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-1bit-v.c  |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-2bit-vi.c |    3 ++-
 7 files changed, 13 insertions(+), 6 deletions(-)

Comment by Matthew Schneider (mschneider) - Saturday, 30 June 2007, 01:15 GMT+2
I think this is out of sync. I've tried compiling with the sansa and i get a failed HUNK and an error.
Comment by Max Weninger (maxwen) - Saturday, 30 June 2007, 13:00 GMT+2
sorry try this one
   ymargin_scrollinfo_20070622.patch (5.3 KiB) 
 rockbox_svn/firmware/export/lcd.h                 |    1 +
 rockbox_svn/firmware/drivers/lcd-1bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-horz.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-1bit-v.c  |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-2bit-vi.c |    3 ++-
 rockbox_svn/firmware/drivers/lcd-16bit.c          |    3 ++-
 7 files changed, 13 insertions(+), 6 deletions(-)

Comment by Phil Light (phillight) - Saturday, 28 July 2007, 16:37 GMT+2
Synced
   ymargin-scrollinfo_20070728.patch (5 KiB) 
 rockbox_svn/firmware/export/scroll_engine.h       |    1 +
 rockbox_svn/firmware/drivers/lcd-1bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-horz.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-1bit-v.c  |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-2bit-vi.c |    3 ++-
 rockbox_svn/firmware/drivers/lcd-16bit.c          |    3 ++-
 7 files changed, 13 insertions(+), 6 deletions(-)

Comment by Thomas Martitz (kugel.) - Tuesday, 02 October 2007, 23:05 GMT+2
It stopped compiling today...

CC drivers/lcd-16bit.c
drivers/lcd-16bit.c: In function ‘lcd_puts_customline_scroll_style_offset’:
drivers/lcd-16bit.c:1044: error: ‘struct scrollinfo’ has no member named ‘y_margin’
drivers/lcd-16bit.c: In function ‘lcd_puts_scroll_style_offset’:
drivers/lcd-16bit.c:1125: error: ‘struct scrollinfo’ has no member named ‘y_margin’
drivers/lcd-16bit.c: In function ‘lcd_scroll_fn’:
drivers/lcd-16bit.c:1180: error: ‘struct scrollinfo’ has no member named ‘y_margin’
make[1]: *** [/home/diablo/rockbox/sim/firmware/drivers/lcd-16bit.o] Error 1
make: *** [build] Fehler 2


This also happens when I apply ymargin as a single patch.
Comment by Travis Tooke (tdtooke) - Wednesday, 03 October 2007, 10:25 GMT+2
Here's my personal copy of this patch just in case that'll help:
   ymargin-scrollinfo_20071002.patch (5.2 KiB) 
 rockbox_svn/firmware/drivers/lcd-16bit.c          |    3 ++-
 rockbox_svn/firmware/drivers/lcd-1bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-horz.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-2bit-vert.c      |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-1bit-v.c  |    3 ++-
 rockbox_svn/firmware/drivers/lcd-remote-2bit-vi.c |    3 ++-
 rockbox_svn/firmware/export/scroll_engine.h       |    1 +
 7 files changed, 13 insertions(+), 6 deletions(-)

Loading...