Rockbox

Tasklist

FS#6796 - Put ymargin into scrollinfo

Attached to Project: Rockbox
Opened by Max Weninger (maxwen) - Sunday, 11 March 2007, 07:28 GMT
Last edited by Paul Louden (Llorean) - Wednesday, 16 January 2008, 14:22 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

ymargin should be put into scrollinfo like xmargin in startx
so that the scroll_thread becomes independent of any ymargin changes
in the rest of the code during runtime

Tested on X5 and simulators for H120 and IPod Nano
This task depends upon

Closed by  Paul Louden (Llorean)
Wednesday, 16 January 2008, 14:22 GMT
Reason for closing:  Rejected
Additional comments about closing:  See viewports.
Comment by Max Weninger (maxwen) - Sunday, 11 March 2007, 07:30 GMT
Removed unneeded line in lcd.h
Comment by Matthew Schneider (mschneider) - Friday, 29 June 2007, 23:15 GMT
I think this is out of sync. I've tried compiling with the sansa and i get a failed HUNK and an error.
Comment by Max Weninger (maxwen) - Saturday, 30 June 2007, 11:00 GMT
sorry try this one
Comment by Phil Light (phillight) - Saturday, 28 July 2007, 14:37 GMT
Synced
Comment by Thomas Martitz (kugel.) - Tuesday, 02 October 2007, 21:05 GMT
It stopped compiling today...

CC drivers/lcd-16bit.c
drivers/lcd-16bit.c: In function ‘lcd_puts_customline_scroll_style_offset’:
drivers/lcd-16bit.c:1044: error: ‘struct scrollinfo’ has no member named ‘y_margin’
drivers/lcd-16bit.c: In function ‘lcd_puts_scroll_style_offset’:
drivers/lcd-16bit.c:1125: error: ‘struct scrollinfo’ has no member named ‘y_margin’
drivers/lcd-16bit.c: In function ‘lcd_scroll_fn’:
drivers/lcd-16bit.c:1180: error: ‘struct scrollinfo’ has no member named ‘y_margin’
make[1]: *** [/home/diablo/rockbox/sim/firmware/drivers/lcd-16bit.o] Error 1
make: *** [build] Fehler 2


This also happens when I apply ymargin as a single patch.
Comment by Travis Tooke (tdtooke) - Wednesday, 03 October 2007, 08:25 GMT
Here's my personal copy of this patch just in case that'll help:

Loading...