Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6798 - scan acceleration in the list

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Sunday, 11 March 2007, 14:10 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 27 May 2007, 17:11 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds decent scan acceleration to the list widget for all targets. I tested it on my h300 with music playing and it worked very well scrolling through the 5000+ tracks in the db, and the only annoyance was dropped frames, but thats still better than it taking 15min to go through the list or audio pausing.

The reason its not commited is that I think tt should be tested on other targets to make sure it doesnt cause any extra audio stalling...


If this does go in, should it be controlled by a setting?
(application/octet-stream)    list_accel.patch (1.5 KiB) 
 apps/gui/list.c |   25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 27 May 2007, 17:11 GMT+2
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Monday, 12 March 2007, 05:42 GMT+2
This one does a little hack to work on the ipods correctly.
(application/octet-stream)    list_accel.patch (1.9 KiB) 
 apps/gui/list.c |   41 +++++++++++++++++++++++++++++++++++++++--
 1 file changed, 39 insertions(+), 2 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Monday, 12 March 2007, 09:00 GMT+2
simplifies the list code a bit and keeps the bin size to about neutral.
(application/octet-stream)    list_accel.patch (10.6 KiB) 
 apps/gui/list.c |  257 ++++++++++++++++++++------------------------------------
 1 file changed, 93 insertions(+), 164 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Monday, 12 March 2007, 12:32 GMT+2
once more...
the ipod code was removed because it didnt work at all. Hopefully we can agree on a generic slider control for those targets to deal with acceleration?
Also adds 2 settings to control this
(application/octet-stream)    changes.patch (14.5 KiB) 
 apps/lang/english.lang    |   28 +++++
 apps/gui/list.c           |  248 +++++++++++++++-------------------------------
 apps/settings.h           |    3 
 apps/menus/display_menu.c |    8 +
 apps/settings_list.c      |   22 ++++
 5 files changed, 143 insertions(+), 166 deletions(-)

Comment by Nicolas Pennequin (nicolas_p) - Monday, 21 May 2007, 12:10 GMT+2
Sync'ed to current SVN.
   list_accel.patch (14.6 KiB) 
 apps/lang/english.lang    |   29 +++++
 apps/gui/list.c           |  250 +++++++++++++++-------------------------------
 apps/settings.h           |    2 
 apps/menus/display_menu.c |    8 +
 apps/settings_list.c      |   22 ++++
 5 files changed, 143 insertions(+), 168 deletions(-)

Loading...