Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6831 - prompt to set date/time on startup if RTC has invalid time

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Wednesday, 14 March 2007, 23:35 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 13:00 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is especially useful on targets that have an off switch instead of a reset button like the gigabeat but also applicable to other targets (power loss due to run down battery etc)

The patch:
- displays the date/time settings screen at start-up on encountering an invalid RTC time
- the screen is pre-set with the build date (instead of 01/01/2000) reducing the number of button presses even more
   prompt_datetime_set.patch (2.6 KiB) 
 apps/Makefile              |    2 +-
 apps/menus/settings_menu.c |   16 +++++++++++-----
 apps/root_menu.c           |    6 ++++++
 apps/settings_menu.h       |    1 +
 4 files changed, 19 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 05 August 2007, 13:00 GMT+2
Reason for closing:  Rejected
Comment by Geoff Stokes (iwantanimac) - Friday, 16 March 2007, 12:36 GMT+2
Looks useful. Might investigate it.
Comment by Dominik Riebeling (bluebrother) - Friday, 16 March 2007, 13:59 GMT+2
This might be quite confusing for blind users and pretty much annyoing for users that don't care about their RTC (but lose power frequently like swapping batteries on archos devices). This has also been mentioned in IRC a couple of days ago.
Comment by Sylvan Mably (smably) - Friday, 30 March 2007, 02:27 GMT+2
Updated:
-Synced with SVN
-New menu option "Prompt to Set Time/Date if Invalid" (off by default)

I hope I did this right...not sure how the lang files should look with this.
   prompt_datetime_set-v2.patch (4.8 KiB) 
 apps/Makefile              |    2 +-
 apps/menus/settings_menu.c |   19 +++++++++++++------
 apps/root_menu.c           |    6 ++++++
 apps/settings_menu.h       |    1 +
 apps/settings.h            |    1 +
 apps/settings_list.c       |    1 +
 apps/lang/english.lang     |   14 ++++++++++++++
 7 files changed, 37 insertions(+), 7 deletions(-)

Comment by Robert Kukla (roolku) - Saturday, 31 March 2007, 15:07 GMT+2
adapted to current svn
   prompt_datetime_set.patch (1.3 KiB) 
 apps/menus/settings_menu.c |    2 +-
 apps/root_menu.c           |    6 ++++++
 apps/settings_menu.h       |    1 +
 3 files changed, 8 insertions(+), 1 deletion(-)

   prompt_datetime_set_(with setting).patch (3.5 KiB) 
 apps/menus/settings_menu.c |    5 +++--
 apps/root_menu.c           |    6 ++++++
 apps/settings_menu.h       |    1 +
 apps/settings.h            |    1 +
 apps/settings_list.c       |    1 +
 apps/lang/english.lang     |   14 ++++++++++++++
 6 files changed, 26 insertions(+), 2 deletions(-)

Comment by Henry Lawson (HenryLawson) - Tuesday, 03 April 2007, 03:03 GMT+2
this patch looks quite useful. ill give it my thumbs up for implementation as an extra feature.

"New menu option "Prompt to Set Time/Date if Invalid" (off by default)"

that should prevent any confusion for blind users and allows people who don't care about RTC to continue not caring.
Comment by Gary Light (evilg123) - Wednesday, 02 May 2007, 03:15 GMT+2
I think this needs a sync:
CC root_menu.c
root_menu.c:34:10: error: #include expects "FILENAME" or <FILENAME>
root_menu.c: In function ‘root_menu’:
root_menu.c:445: warning: implicit declaration of function ‘timedate_set’
Comment by Robert Kukla (roolku) - Wednesday, 02 May 2007, 10:23 GMT+2
Didn't think anybody else was actually using it. :)
   prompt_datetime_set.patch (1.3 KiB) 
 apps/menus/settings_menu.c |    2 +-
 apps/root_menu.c           |    6 ++++++
 apps/settings_menu.h       |    1 +
 3 files changed, 8 insertions(+), 1 deletion(-)

   prompt_datetime_set_(with_setting).patch (3.5 KiB) 
 apps/menus/settings_menu.c |    5 +++--
 apps/root_menu.c           |    6 ++++++
 apps/settings_menu.h       |    1 +
 apps/settings.h            |    1 +
 apps/settings_list.c       |    1 +
 apps/lang/english.lang     |   14 ++++++++++++++
 6 files changed, 26 insertions(+), 2 deletions(-)

Loading...