Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6840 - Move rockbox.* into .rockbox

Attached to Project: Rockbox
Opened by Barry Wardell (barrywardell) - Friday, 16 March 2007, 18:10 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently the rockbox.* file is in the root of the device when it's unzipped from rockbox.zip. For various reasons, the general consensus among developers is that it should be moved inside of .rockbox. This patch does just that for iriver, h10, e200, mi4, ipod, gigabeat and iaudio.
   firmware_in_subdir.patch (0.6 KiB) 
 tools/buildzip.pl |    6 ++++++
 1 file changed, 6 insertions(+)

This task depends upon

Closed by  Nils Wallménius (nls)
Wednesday, 21 March 2007, 01:28 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Barry comitted this
Comment by Hepdog (007quick) - Saturday, 17 March 2007, 19:57 GMT+2
Works fine here. Why not commit it to SVN. Just gotta post a big thing in the formus that everyone should delete the rockbox.file from the root.
Comment by Jonathan Gordon (jdgordon) - Sunday, 18 March 2007, 13:09 GMT+2
go for it :)
But is there a version or something in the rockbox. file that can be bumped so we dont have problems with people who left the rockbox. file in /? (unless your patch doesnt try loading that file anymore anyway?)
Comment by Barry Wardell (barrywardell) - Sunday, 18 March 2007, 18:52 GMT+2
Here's an updated patch. It now does the reverse - the default is to put rockbox.* inside .rockbox except for the cases of rockbox.wma, rockbox.ajz and rockbox.mod. Are these the only three that have to be in the root? Is it even necessary for these three to be in the root?

The manual will also need to be updated. Unfortunately I don't have a build environment up and running for building the manual. Would someone be willing to make the changes?
   firmware_in_subdir.patch (0.6 KiB) 
 tools/buildzip.pl |    6 ++++++
 1 file changed, 6 insertions(+)

Comment by Nils Wallménius (nls) - Tuesday, 20 March 2007, 12:09 GMT+2
I can update the manual when this is comitted :-)
The rockbox.ajz and rockbox.mod files need to be in the root because the
original firmware on the archoses loads them on players where rockbox isn't
(or can't be) flashed, and afaik it will only look in the root.
The rockbox.wma is "played" manually to start rockbox on the ifp, i guess
it's placement is for convenience.

Loading...