FS#6862 - WPS Tokenizer
Opened by Nicolas Pennequin (nicolas_p) - Tuesday, 20 March 2007, 01:29 GMT
Last edited by Nicolas Pennequin (nicolas_p) - Wednesday, 04 April 2007, 16:10 GMT
This is my WPS tokenizer patch. The basic idea is to store the WPS as an array of tokens. That way it is only parsed once and transformed into a form easier to use for displaying.
The concept is somewhat similar to what's explained here : http://www.rockbox.org/twiki/bin/view/Main/WPSTokenbasedHandling. There are also some explanations on
To make this patch, I used the code in
It appears to be working nicely with most of the WPS files I tested on most targets.
It still needs to go through extensive testing, so please apply it to your build and test some WPS files :)
Please report any crashes you get (although there shouldn't be any), and post feedback on performance differences, if you notice any (maybe try to activate heavy CPU features like crossfeed, EQ, replaygain, etc... and compare with an SVN build).
Also I'm not sure at all it will work well on the archos player, so it would be good if someone could try that too.
Wednesday, 04 April 2007, 16:11 GMT
Reason for closing: Accepted
Additional comments about closing: Comitted to SVN. Please report problems on the forum : http://forums.rockbox.org/index.php?topi c=9727.0