Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6891 - iPod Nano Charger Support

Attached to Project: Rockbox
Opened by Russell Harmon (eatnumber1) - Friday, 23 March 2007, 12:30 GMT+2
Last edited by Torne Wuff (torne) - Wednesday, 10 February 2010, 14:41 GMT+2
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type iPod Nano
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I implemented the code so that the ipod nano can support usb chargers... Patch attached
(application/octet-stream)    chargerpatch (1.1 KiB)
This task depends upon

Closed by  Torne Wuff (torne)
Wednesday, 10 February 2010, 14:41 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  This has been fixed in r24581 - the correct GPIOs were already checked but CONFIG_CHARGING had not been enabled.
Comment by oblib (oblib__) - Friday, 30 March 2007, 06:58 GMT+2
Um, looks like you got the wrong GPIO bit (I tried that one first too). See 6940.
Comment by Russell Harmon (eatnumber1) - Friday, 30 March 2007, 13:47 GMT+2
The gpio bit that person used was GPIOL 10. That bit does not change when you plug in the usb wall charger on my ipod. 8 is definatley the one that changes
Comment by oblib (oblib__) - Friday, 30 March 2007, 16:11 GMT+2
That's weird. When I go to the debug ports screen, the only activity I see is on GPIO L, and it goes from 0xE8 to 0xF8 when I plug in the wall USB charger when the backlight is on, and from 0x68 to 0x78 when the backlight is off. That means the mask for that bit is 0x10, with 1 being plugged in and 0 is not plugged in. What does your ipod do?

With your patch, does a little plug logo show up in the upper-left corner of rockbox-default when you plug it in? Can you make the backlight turn on and stay on by setting Power(while charging) to on and plugging in the ipod?
Comment by oblib (oblib__) - Friday, 30 March 2007, 16:13 GMT+2
Sorry, that should be "Backlight (while plugged in)" not Power(while charging)
Comment by Russell Harmon (eatnumber1) - Saturday, 31 March 2007, 04:05 GMT+2
I'm not sure how to set the power while charging setting, but I cannot charge the ipod if it is off. Also, the plug does show up. Lastly, the reason for the difference in gpio bits is I use a legacy firewire charger to charge my nano. You probably use the usb. If so, I will make a patch with both.
Comment by oblib (oblib__) - Saturday, 31 March 2007, 15:19 GMT+2
That makes more sense then. I thought by "usb chargers" you meant the +5V that comes from a USB port, which is what my patch addresses. It makes sense that there would be a different status bit for the +12V firewire charge. If I add it to my patch (FS6940), will you test it for me?
Comment by Russell Harmon (eatnumber1) - Saturday, 31 March 2007, 17:33 GMT+2
sure
Comment by Katharine (d14u2x3) - Monday, 23 April 2007, 10:27 GMT+2
when i press that link for the patch, i saw some kind of code. i know you implemented the code, but how to i transfer this to my ipod nano to receive the charger support?
Comment by oblib (oblib__) - Tuesday, 24 April 2007, 01:54 GMT+2
You have to set up a build environment that will let you compile Rockbox, which is a fairly complicated procedure. See http://www.rockbox.org/twiki/bin/view/Main/DevelopmentGuide for details. If you haven't compiled a program in Linux before, you might have a tough time figuring out how to do it.
Comment by Nick Waterton (Nick_W) - Monday, 03 September 2007, 19:33 GMT+2
Hi I found that your logic didn't work with my Nano (build r14596)

This logic does work for both 12V and 5V charging though.

return ((GPIOL_INPUT_VAL & 0x10) | (GPIOL_INPUT_VAL &0x08))?false:true; /*5v and 12V pins */

You may want to update your patch.
Comment by Russell Harmon (eatnumber1) - Monday, 03 September 2007, 22:39 GMT+2
Here is a completely untested patch implementing your changes.
   ipod-nano_charger-fix.patch (1.4 KiB) 
 rockbox_original/firmware/export/config-ipodnano.h     |    4 ++--
 rockbox_original/firmware/target/arm/ipod/power-ipod.c |    3 ---
 2 files changed, 2 insertions(+), 5 deletions(-)

Comment by Russell Harmon (eatnumber1) - Sunday, 09 September 2007, 22:41 GMT+2
That patch was backwards... nevertheless, the code changes there work for me.

Here's a correct one.
   ipod-nano_charger-fix.patch (1.1 KiB) 
 firmware/export/config-ipodnano.h     |    4 ++--
 firmware/target/arm/ipod/power-ipod.c |    2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

Loading...