Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6893 - new UI (no Wizards) for rbUtil

Attached to Project: Rockbox
Opened by Dominik Wenger (Domonoky) - Saturday, 24 March 2007, 03:43 GMT+2
Last edited by Paul Louden (Llorean) - Saturday, 24 March 2007, 04:46 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Here is a patch to change all the Wizards in rbutil into normal Windows.
It has a few issues, (like very bad looking Images in Linux).

a win binary for testing is at:
www.b23.org/~domonoky/rbutil.zip

   rbutil-noWizard.patch (143.2 KiB)
 rbutil/rbutil.ini          |   64 -
 rbutil/rbutil.cpp          |    3 
 rbutil/install_dialogs.cpp | 1672 +++++++++++++++++++++++++++++++++++++++++++++
 rbutil/rbutilFrm.h         |    2 
 rbutil/bootloaders.cpp     |   83 +-
 rbutil/wizard_pages.h      |  241 ------
 rbutil/Makefile            |    2 
 rbutil/rbutilApp.cpp       |    8 
 rbutil/rbutil.h            |    8 
 rbutil/rbutilFrm.cpp       |  264 ++-----
 rbutil/install_dialogs.h   |  278 +++++++
 rbutil/wizard_pages.cpp    |  967 --------------------------
 rbutil/bootloaders.h       |   11 
 rbutil/rbutil.cbp          |    4 
 14 files changed, 2096 insertions(+), 1511 deletions(-)

This task depends upon

Closed by  Dominik Wenger (Domonoky)
Thursday, 03 May 2007, 19:12 GMT+2
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Sunday, 25 March 2007, 14:50 GMT+2
just tested this out under wine, (after never actually using the current rbutil :p ) and it looks good, except 1 thing that I dont like is the message telling me the instalation wizard was canceled after pressing cancel. This seems redundant.

also, there is no exit button except the file menu?
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 27 March 2007, 21:04 GMT+2
I like this patch, but I do agree with JdGordon on the cancel message. I've been meaning to say this ever since I first got to test rbutil so thanks for reminding me of it ;)
Also the DAP type doesn't seem to be right when a window is first displayed. For me it showed gigabeatf but I still had to manually select the right menu entry.
Comment by Dominik Wenger (Domonoky) - Friday, 30 March 2007, 02:38 GMT+2
I have now nearly finished this patch.
- The Images are now in a selfmade control, so should look good on all platforms.
- All functionality should work again
- made more own Control for better Code-reuse.

as always: a win binary for testing:
www.b23.org/~domonoky/rbutil.zip

attached is the new Patch:
   rbutil-newUI.patch (79.6 KiB)
 rbutil/rbutil.ini       |   64 ---
 rbutil/rbutil.cpp       |   43 ++
 rbutil/rbutilFrm.h      |    2 
 rbutil/bootloaders.cpp  |   83 ++--
 rbutil/wizard_pages.h   |  241 -----------
 rbutil/Makefile         |    2 
 rbutil/rbutilApp.cpp    |    8 
 rbutil/rbutil.h         |   46 ++
 rbutil/rbutilFrm.cpp    |  299 ++++----------
 rbutil/wizard_pages.cpp |  967 ------------------------------------------------
 rbutil/bootloaders.h    |   11 
 rbutil/rbutil.cbp       |    4 
 12 files changed, 233 insertions(+), 1537 deletions(-)

Comment by Dominik Wenger (Domonoky) - Wednesday, 04 April 2007, 18:11 GMT+2
nearly finished patch for new UI for rbutil.

Needs testing on linux.

   rbutil.patch (134.4 KiB)
 rbutil/rbutil.ini          |   64 --
 rbutil/rbutil.cpp          |    4 
 rbutil/install_dialogs.cpp |  815 +++++++++++++++++++++++++++++++++++++
 rbutil/rbutilCtrls.cpp     |  592 +++++++++++++++++++++++++++
 rbutil/rbutilFrm.h         |    2 
 rbutil/bootloaders.cpp     |   83 +--
 rbutil/wizard_pages.h      |  241 -----------
 rbutil/Makefile            |    2 
 rbutil/rbutilApp.cpp       |    8 
 rbutil/rbutilFrm.cpp       |  293 +++----------
 rbutil/rbutil.h            |   12 
 rbutil/install_dialogs.h   |  247 +++++++++++
 rbutil/rbutilCtrls.h       |  282 +++++++++++++
 rbutil/wizard_pages.cpp    |  967 ---------------------------------------------
 rbutil/bootloaders.h       |   11 
 rbutil/rbutil.cbp          |    4 
 16 files changed, 2090 insertions(+), 1537 deletions(-)

Comment by Dave Chapman (linuxstb) - Thursday, 05 April 2007, 23:46 GMT+2
A few general comments/suggestions:

1) Why not have a "select device" option on the opening (main) screen. This will allow users to choose their device once, and then the pop-up windows can be customised for those devices - e.g. not displaying a mount point and original firmware location for iPod bootloader installs - having unneeded boxes will just confuse users.

2) Regarding ipods, these can be auto-detected with the ipodpatcher code - so the user just needs to select "ipod", rather than their specific model.

3) The UI allows me to choose a 2.5 release for targets which don't have 2.5 versions.

4) The main opening screen now seems far too cluttered. What about changing to a tabbed layout, with perhaps tabs for "Installation" (the current first two options), "Themes" (fonts and themes) and "Uninstallation" (the current last two options).
Comment by Dominik Wenger (Domonoky) - Tuesday, 24 April 2007, 21:06 GMT+2
New updated Patch.

- Theme installing now also works on Linux (but the window doesnt look nice, it doesnt resize it self)

- Tabs for less cluttering in the main screen.

- Device seleting is now in the main screen.

- about autodetecting ipods, this should work via die autodetect button, and will be extended to other Players in the future.

comments welcome :-)
(application/octet-stream)    rbutil.patch (87.9 KiB)
 rbutil/rbutil.ini       |   64 ---
 rbutil/rbutil.cpp       |    4 
 rbutil/rbutilFrm.h      |    5 
 rbutil/bootloaders.cpp  |   83 ++--
 rbutil/wizard_pages.h   |  241 -----------
 rbutil/Makefile         |    2 
 rbutil/rbutilApp.cpp    |   12 
 rbutil/rbutil.h         |   15 
 rbutil/rbutilFrm.cpp    |  413 ++++++++------------
 rbutil/wizard_pages.cpp |  967 ------------------------------------------------
 rbutil/bootloaders.h    |   11 
 rbutil/rbutil.cbp       |    4 
 12 files changed, 243 insertions(+), 1578 deletions(-)

Comment by Dominik Wenger (Domonoky) - Tuesday, 24 April 2007, 21:26 GMT+2
i missed 2 new files in the diff
(application/octet-stream)    rbutil.patch (119.7 KiB)
 rbutil/rbutil.ini       |   64 ---
 rbutil/rbutil.cpp       |    4 
 rbutil/rbutilCtrls.cpp  |  581 ++++++++++++++++++++++++++++
 rbutil/rbutilFrm.h      |    5 
 rbutil/bootloaders.cpp  |   83 ++--
 rbutil/wizard_pages.h   |  241 -----------
 rbutil/Makefile         |    2 
 rbutil/rbutilApp.cpp    |   12 
 rbutil/rbutil.h         |   15 
 rbutil/rbutilFrm.cpp    |  413 ++++++++------------
 rbutil/rbutilCtrls.h    |  561 +++++++++++++++++++++++++++
 rbutil/wizard_pages.cpp |  967 ------------------------------------------------
 rbutil/bootloaders.h    |   11 
 rbutil/rbutil.cbp       |    4 
 14 files changed, 1385 insertions(+), 1578 deletions(-)

Comment by Dominik Wenger (Domonoky) - Tuesday, 24 April 2007, 21:47 GMT+2
arg, again missed files, now it should be good.

(application/octet-stream)    rbutil2.patch (148.3 KiB)
 rbutil/rbutil.ini          |   64 --
 rbutil/rbutil.cpp          |    4 
 rbutil/install_dialogs.cpp |  753 +++++++++++++++++++++++++++++++++++
 rbutil/rbutilCtrls.cpp     |  581 +++++++++++++++++++++++++++
 rbutil/rbutilFrm.h         |    5 
 rbutil/bootloaders.cpp     |   83 +--
 rbutil/wizard_pages.h      |  241 -----------
 rbutil/Makefile            |    2 
 rbutil/rbutilApp.cpp       |   12 
 rbutil/rbutil.h            |   15 
 rbutil/rbutilFrm.cpp       |  413 +++++++------------
 rbutil/install_dialogs.h   |  234 ++++++++++
 rbutil/rbutilCtrls.h       |  561 ++++++++++++++++++++++++++
 rbutil/wizard_pages.cpp    |  967 ---------------------------------------------
 rbutil/bootloaders.h       |   11 
 rbutil/rbutil.cbp          |    4 
 16 files changed, 2372 insertions(+), 1578 deletions(-)

Comment by Dominik Wenger (Domonoky) - Tuesday, 24 April 2007, 23:56 GMT+2

-fixed autodetection
-fixed strange looking mainwindow in win32

only known big problem: theme dialog doesnt resize properly

(application/octet-stream)    rbutil3.patch (148.5 KiB)
 rbutil/rbutil.ini          |   64 --
 rbutil/rbutil.cpp          |    4 
 rbutil/install_dialogs.cpp |  753 +++++++++++++++++++++++++++++++++++
 rbutil/rbutilCtrls.cpp     |  582 +++++++++++++++++++++++++++
 rbutil/rbutilFrm.h         |    5 
 rbutil/bootloaders.cpp     |   83 +--
 rbutil/wizard_pages.h      |  241 -----------
 rbutil/Makefile            |    2 
 rbutil/rbutilApp.cpp       |   12 
 rbutil/rbutil.h            |   15 
 rbutil/rbutilFrm.cpp       |  419 ++++++++-----------
 rbutil/install_dialogs.h   |  234 ++++++++++
 rbutil/rbutilCtrls.h       |  561 ++++++++++++++++++++++++++
 rbutil/wizard_pages.cpp    |  967 ---------------------------------------------
 rbutil/bootloaders.h       |   11 
 rbutil/rbutil.cbp          |    4 
 16 files changed, 2379 insertions(+), 1578 deletions(-)

Comment by Dominik Wenger (Domonoky) - Wednesday, 25 April 2007, 00:30 GMT+2
now the theme dialog also resizes. It doesnt look nice, but it works and you can see the Buttons :-)

If someone has an idea for another Layout for this Dialog, so that the controls which change in Size, affects the layout less, please tell me :-)

Comment by Dominik Wenger (Domonoky) - Wednesday, 25 April 2007, 00:31 GMT+2
wrong button, forgot the patch :-)
(application/octet-stream)    rbutil4.patch (148.8 KiB)
 rbutil/rbutil.ini          |   64 --
 rbutil/rbutil.cpp          |    4 
 rbutil/install_dialogs.cpp |  753 +++++++++++++++++++++++++++++++++++
 rbutil/rbutilCtrls.cpp     |  588 +++++++++++++++++++++++++++
 rbutil/rbutilFrm.h         |    5 
 rbutil/bootloaders.cpp     |   83 +--
 rbutil/wizard_pages.h      |  241 -----------
 rbutil/Makefile            |    2 
 rbutil/rbutilApp.cpp       |   12 
 rbutil/rbutil.h            |   15 
 rbutil/rbutilFrm.cpp       |  419 ++++++++-----------
 rbutil/install_dialogs.h   |  234 ++++++++++
 rbutil/rbutilCtrls.h       |  561 ++++++++++++++++++++++++++
 rbutil/wizard_pages.cpp    |  967 ---------------------------------------------
 rbutil/bootloaders.h       |   11 
 rbutil/rbutil.cbp          |    4 
 16 files changed, 2385 insertions(+), 1578 deletions(-)

Loading...