Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6920 - Swap power and select in WPS on gigabeat to be consistent with H1x0

Attached to Project: Rockbox
Opened by Alex Parker (BigBambi) - Wednesday, 28 March 2007, 12:46 GMT+2
Last edited by Paul Louden (Llorean) - Friday, 31 August 2007, 16:27 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Gigabeat F/X
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The power and select buttons are swapped in the WPS compared to the equivalent buttons on the H1x0. This patch reverses them so that power pauses and select goes to file browser, analogous to play and navi on the H1x0 to be consistent across targets.
(application/octet-stream)    patch.diff (1.3 KiB) 
 apps/keymaps/keymap-gigabeat.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Paul Louden (Llorean)
Friday, 31 August 2007, 16:27 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted, with modification. (Your version removes the ability to Stop in the wps, and leaves the 'A' button unused. I modified it to align with the semi-standard keymap of Rockbox).
Comment by Sylvan Mably (smably) - Wednesday, 28 March 2007, 18:12 GMT+2
(This is also consistent with H300 and, I believe, X5 behavior.)
Comment by Michael Sevakis (MikeS) - Wednesday, 28 March 2007, 23:57 GMT+2
This makes sense to me. I haven't cared for the current setup much on Gigabeat. I'll give this a check and if all is well I think it should be comitted unless others in the Gigabeat crowd object.
Comment by Paul Louden (Llorean) - Thursday, 29 March 2007, 00:55 GMT+2
I think we're beginning to convince Markun, who was the real objector earlier when it was discussed.

There's a very definite benefit, in my mind, to making the buttons function consistently across screens so that when you realize "Select" and "Navi" are the same, you know what they do everywhere.

An added bonus is that if Pause is one of the side buttons, it makes it much easier to pause without accidentally triggering the cross.
Comment by Michael Sevakis (MikeS) - Thursday, 29 March 2007, 04:13 GMT+2
I love that control...I can haul ass around the UI with it but found the inconsistency weird. Keeping fingers near the outside makes it essentially immune from a wrong press.
Comment by Paul Louden (Llorean) - Thursday, 29 March 2007, 07:34 GMT+2
Well another big advantage of making select exit the WPS, rather than pause, is that with one thumb on the cross you have full playback control up to and includign starting a new playlist, or inserting and queuing. No requiring of a second hand or finger.
Comment by Sylvan Mably (smably) - Saturday, 31 March 2007, 19:59 GMT+2
Just a note that this patch breaks the remote button mapping (remote play/pause displays the file browser).
Comment by Alex Parker (BigBambi) - Wednesday, 04 April 2007, 16:07 GMT+2
OK, this version changes the remote keys such that play/pause on the remote acts like power on the main unit. Consequently, in the WPS play/pause on the remote plays or pauses (!), and in the filetree or menu resumes playback/goes to WPS. In order to select new files/menu items etc, you must go via the Rockbox menu, then navigate via files>artist>whatever, and use right to select. The same goes for settings. This is a result of the remote lacking some keys,
(application/octet-stream)    patch v2.diff (1.8 KiB) 
 apps/keymaps/keymap-gigabeat.c                      |    4 ++--
 firmware/target/arm/gigabeat/meg-fx/button-meg-fx.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comment by Alex Parker (BigBambi) - Wednesday, 04 April 2007, 16:12 GMT+2
And here it is to current SVN:
(application/octet-stream)    patch v2.1.diff (1.8 KiB) 
 apps/keymaps/keymap-gigabeat.c                      |    4 ++--
 firmware/target/arm/gigabeat/meg-fx/button-meg-fx.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comment by Alex Parker (BigBambi) - Tuesday, 17 April 2007, 14:46 GMT+2
Synched
(application/octet-stream)    patch v2.2.diff (1.8 KiB) 
 apps/keymaps/keymap-gigabeat.c                      |    4 ++--
 firmware/target/arm/gigabeat/meg-fx/button-meg-fx.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comment by Nathan Hale (Incubus-1) - Friday, 04 May 2007, 20:15 GMT+2
I, sort of, object to this patch being committed. Not a loud objection, but one none the less. Reason being, as a Gigabeat user coming from the original firmaware, select has always been used as play/pause. So making the Power, or possibly the A button now, play/pause would be awkward. Again this isn't a an adamant objection. The changes between the Power and A button took about 5 minutes to get used to, so I suspect this one would take about the same.
Comment by Paul Louden (Llorean) - Friday, 04 May 2007, 23:27 GMT+2
Rockbox is ROCKBOX, it is not intended to mimic behaviour of the original firmware. I don't see this as an argument in favour of doing so at all.
Comment by Alex Parker (BigBambi) - Saturday, 05 May 2007, 00:16 GMT+2
I wrote this patch because the current inconsistent gigabeat button map annoys me a lot. I would clearly love it to be committed, but even if it is not I will continue to do it for my build (I will shortly do a new patch that is synced). The original gigabeat firmware is irrelevant to me (I have never used it), and really the actual button used for play/pause as opposed to select isn't much of a concern, it is just that currently the gigabeat button map swaps play/pause and select buttons depending on what screen you are in, relative to the rest of rockbox.

I don't mind if power is play/pause and centre cross is select or vice versa (or indeed A or menu), but the usage should be consistent, which it currently isn't.
Comment by Alex Parker (BigBambi) - Monday, 07 May 2007, 13:02 GMT+2
Recently the gigabeat keymap was changed to prevent accidental shutdown by using POWER as the 'shift' button. I think this is a good idea, so have left it as is (i.e. A is the modifier). What I have changed is the unmodified button actions, so now in the tree POWER is resume, SELECT selects (!) and A is stop. Whilst in the WPS, POWER is pause, SELECT is file tree and A is stop. Please let me know if I have unintentionally changed any other actions. New patch is attached.

Alex
   patch.2.5.diff (2.8 KiB) 
 apps/keymaps/keymap-gigabeat.c                          |   16 ++++++++--------
 firmware/target/arm/s3c2440/gigabeat-fx/button-meg-fx.c |    2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

Comment by Paul Louden (Llorean) - Friday, 18 May 2007, 16:16 GMT+2
A should not be stop. Power should be stop. You've basically undone some of the recent changes in SVN, and I'm not certain why.
Comment by Alex Parker (BigBambi) - Friday, 18 May 2007, 16:41 GMT+2
Quick answer: personal preference.

However, the new version undoes these changes, so the only changes now are A and select swapped in WPS, and the play/pause button on the remote acts as the A button, not select.
   patchv3.diff (1.6 KiB) 
 apps/keymaps/keymap-gigabeat.c                          |    4 ++--
 firmware/target/arm/s3c2440/gigabeat-fx/button-meg-fx.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comment by Alex Parker (BigBambi) - Tuesday, 22 May 2007, 13:50 GMT+2
OK, with the remote now having its own button defines, here it is synched.

This change also changed the remote mute button from acting like select everywhere, to being stop in the WPS (analagous to power, but as the remote now has its own defines, it isn't necessarily power everywhere).

Consequently, two versions of the patch are attached -
a) swaps A and select on the main unit in the WPS only
b) swaps A and select on the main unit in the WPS and also makes mute on the remote menu in the WPS but otherwise leaves the mute button as it is in SVN.

I know which I prefer (the latter), but what are people's thoughts?
   patch4.diff (1 KiB) 
 apps/keymaps/keymap-gigabeat.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

   patch4.remote_mute_menu.diff (1.5 KiB) 
 apps/keymaps/keymap-gigabeat.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment by Alex Parker (BigBambi) - Friday, 25 May 2007, 10:41 GMT+2
OK, I realised that since the separate remote mappings there was no way to resume playback/go to WPS from the filetree with the remote. I find this annoying as often the main unit will be in my pocket, and I'll turn it on with remote but then cannot resume (I have it going straight to filetree). Consequently the two patch versions here are as above, but with play on the remote resuming/going to WPS from the filetree.
   patchv5.diff (1.6 KiB) 
 apps/keymaps/keymap-gigabeat.c |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

   patchv5.remote_mute_menu.diff (2.2 KiB) 
 apps/keymaps/keymap-gigabeat.c |   15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

Comment by Paul Louden (Llorean) - Friday, 25 May 2007, 22:39 GMT+2
What about the "Now Playing" entry in the main menu? That seems like a perfectly suitable way...
Comment by Alex Parker (BigBambi) - Friday, 25 May 2007, 23:52 GMT+2
True, but currently 'play' on the remote is used for nothing when in the filetree. When I start up I am in filetree. If I use Now Playing in main menu, I have to press left, then down three times, then right to resume playback. Given that play on the remote is currently used for nothing at all in the filetree, why not have it act as 'play' and therefore resume playback?
Comment by Paul Louden (Llorean) - Friday, 25 May 2007, 23:55 GMT+2
Ah, didn't realize it did nothing, I thought you were removing some other function of it. Comment retracted.
Comment by Josh Drizin (krazykit) - Sunday, 24 June 2007, 21:28 GMT+2
I've synced the first part of the patch. I know the remote has gone through several changes (and haven't had a chance to check out this patch's remote section).
   patchv5-synced.diff (1.4 KiB) 
 apps/keymaps/keymap-gigabeat.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comment by Alex Parker (BigBambi) - Sunday, 24 June 2007, 21:38 GMT+2
Thanks. The remote has since had missing button functions added in SVN and no longer needs patching. Consequently, it is just A and select in the WPS that need swapping. I've removed some additional unnecessary remote stuff from the patch you synched.
   patchv5.1-synced.diff (1 KiB) 
 apps/keymaps/keymap-gigabeat.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment by Frank Grisafi (JobVanDam) - Tuesday, 14 August 2007, 22:20 GMT+2
This patch is f'n incredible. It just changes Play/Pause to the A button and the File Browser button to the center cross while in the WPS. Everything else stays the same! Sorry just couldn't help myself, this patch is a benefit to all mankind. Thank you so much.
Comment by Jacob Brooks (jac0b) - Saturday, 25 August 2007, 16:12 GMT+2
resynced
   swap_button_r2.patch (1 KiB) 
 apps/keymaps/keymap-gigabeat.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment by Alex Parker (BigBambi) - Saturday, 25 August 2007, 16:15 GMT+2
Thanks. I still have hope this'll get in!

Loading...