Rockbox

Tasklist

FS#6964 - Plugin header info incorrect?

Attached to Project: Rockbox
Opened by Toni (ahellmann) - Tuesday, 03 April 2007, 20:59 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System PortalPlayer-based
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

For some reason the plugin header 'end_addr' entry can be smaller than the plugin filesize.
This may create serious problems with the clearing of the bss area by the following rb code:
memset(pluginbuf + readsize, 0, plugin_size - readsize);
The hiss in the mpegplayer on the sansa seems to be a result from this bug.
This task depends upon

Closed by  Jens Arnold (amiconn)
Tuesday, 17 April 2007, 17:59 GMT
Reason for closing:  Fixed
Additional comments about closing:  end_addr can very well be lower than the plugin filesize + load_addr. This happens if the iram section is larger than the bss area. The loader was fixed to not call memset() in this case.

Loading...