Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6988 - Video item in Main Menu

Attached to Project: Rockbox
Opened by Bobby Graese (TrueJournals) - Friday, 06 April 2007, 23:42 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Saturday, 04 August 2007, 16:44 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Adds a video item to the main menu. I made this patch not having the plans to include it in the normal build, but for those who would like to easily have a video item in the Main Menu (like myself). What this does is add an item to the Main Menu right above Plugins that says Videos. It is linked to the Videos menu in the root of your deivce (/Videos). It will only show Supported files, so you will only see mpg videos that you can actually watch with rockbox.

Enjoy.
   video_menu.patch (3.5 KiB) 
 apps/recorder/icons.h  |    1 +
 apps/recorder/icons.c  |    1 +
 apps/lang/english.lang |   14 ++++++++++++++
 apps/settings.h        |    1 +
 apps/root_menu.c       |    9 ++++++++-
 apps/root_menu.h       |    1 +
 6 files changed, 26 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Saturday, 04 August 2007, 16:44 GMT+2
Reason for closing:  Rejected
Comment by Henry Lawson (HenryLawson) - Tuesday, 17 April 2007, 08:10 GMT+2
Hi Bobby, this patch is a really good idea IMO. It would be pretty sweet if you could do the same but for Music as in binding a Music link to a "/Music" folder. I realize going Files > Music is the same thing but it makes the process slightly faster and a lot more "Newb friend friendly" for those times when you lend ur rockbox to your mate.

If this is included to the normal builds could it be hidden/revealed with a menu option?
Comment by Dagni McPhee (donutman25) - Thursday, 26 April 2007, 00:56 GMT+2
sync please :)
Comment by Bobby Graese (TrueJournals) - Saturday, 28 April 2007, 18:36 GMT+2
Sorry for the wait.. just synced the patch.. Haven't tested it though, so it might or might not work. In this version, the directory changed to /videos (lowercase "v"), because I saw that all the other listed directories were lowercase.

Henry Lawson: Glad to hear you like it. I see no point in making a Music link because of the database feature. The database feature is really what you want to be able to browse your music. If it is ever included in the normal builds, then there will most likely not be an option to hide/show unless someone else adds it. I am very new to coding ;-)
(application/octet-stream)    videos_menu.patch (2.8 KiB) 
 apps/lang/english.lang |   14 ++++++++++++++
 apps/settings.h        |    1 +
 apps/root_menu.c       |    9 ++++++++-
 apps/root_menu.h       |    1 +
 4 files changed, 24 insertions(+), 1 deletion(-)

Comment by Bobby Graese (TrueJournals) - Monday, 30 April 2007, 02:40 GMT+2
Woops... just found a rather stupid typo. This patch will actually work. I'd also like to point out that this patch now uses the folder icon as its icon. This is because with the new icon system, it's too hard to add a custom icon... If someone would like to let me know how to use the icon from the .mpg file type for the videos item menu, that would be great.
   videos_menu.patch (2.9 KiB) 
 apps/lang/english.lang |   14 ++++++++++++++
 apps/settings.h        |    1 +
 apps/root_menu.c       |    9 ++++++++-
 apps/root_menu.h       |    1 +
 4 files changed, 24 insertions(+), 1 deletion(-)

Loading...