Index: apps/tagtree.h =================================================================== --- apps/tagtree.h (revision 13139) +++ apps/tagtree.h (working copy) @@ -46,11 +46,7 @@ bool tagtree_insert_selection_playlist(int position, bool queue); char *tagtree_get_title(struct tree_context* c); int tagtree_get_attr(struct tree_context* c); -#ifdef HAVE_LCD_BITMAP -const unsigned char* tagtree_get_icon(struct tree_context* c); -#else -int tagtree_get_icon(struct tree_context* c); -#endif +int tagtree_get_icon(struct tree_context* c); int tagtree_get_filename(struct tree_context* c, char *buf, int buflen); #endif Index: apps/recorder/bmp.c =================================================================== --- apps/recorder/bmp.c (revision 13139) +++ apps/recorder/bmp.c (working copy) @@ -215,13 +215,6 @@ } height = readlong(&bmph.height); - if (height > LCD_HEIGHT) { - DEBUGF("read_bmp_file: Bitmap too high (%d pixels, max is %d)\n", - height, LCD_HEIGHT); - close(fd); - return -5; - } - depth = readshort(&bmph.bit_count); padded_width = ((width * depth + 31) >> 3) & ~3; /* 4-byte boundary aligned */ Index: apps/recorder/icons.h =================================================================== --- apps/recorder/icons.h (revision 13139) +++ apps/recorder/icons.h (working copy) @@ -32,11 +32,7 @@ #include #endif -/* - * Icons of size 6x8 pixels - */ - /* Symbolic names for icons */ enum icons_5x8 { Icon_Lock_Main, @@ -49,46 +45,6 @@ Icon5x8Last }; -/* If any icons are added to this enum, they must be - added to the unused_but_needed enum in ../player/icons.h */ -enum icons_6x8 { - Icon_Audio, - Icon_Folder, - Icon_Playlist, - Icon_Cursor, - Icon_Wps, - Icon_Firmware, - Icon_Font, - Icon_Language, - Icon_Config, - Icon_Plugin, - Icon_Bookmark, - Icon_Preset, - Icon_Queued, - Icon_Moving, - Icon_Keyboard, - Icon_Reverse_Cursor, - Icon_Questionmark, - Icon_Menu_setting, - Icon_Menu_functioncall, - Icon_Submenu, - Icon_Submenu_Entered, - Icon_Recording, - Icon_Voice, - Icon_General_settings_menu, - Icon_System_menu, - Icon_Playback_menu, - Icon_Display_menu, - Icon_Remote_Display_menu, -#if CONFIG_TUNER - Icon_Radio_screen, -#endif - Icon_file_view_menu, - Icon_EQ, - Icon_Rockbox, - Icon6x8Last, -}; - enum icons_7x8 { Icon_Plug, Icon_USBPlug, @@ -144,7 +100,6 @@ #endif /* CONFIG_CODEC == SWCODEC && defined (HAVE_RECORDING) */ extern const unsigned char bitmap_icons_5x8[Icon5x8Last][5]; -extern const unsigned char bitmap_icons_6x8[Icon6x8Last][6]; extern const unsigned char bitmap_icons_7x8[Icon7x8Last][7]; extern const unsigned char bitmap_icon_disk[]; Index: apps/recorder/keyboard.c =================================================================== --- apps/recorder/keyboard.c (revision 13139) +++ apps/recorder/keyboard.c (working copy) @@ -31,7 +31,7 @@ #include "logf.h" #include "hangul.h" #include "action.h" -#include "icons.h" +#include "icon.h" #ifndef O_BINARY #define O_BINARY 0 @@ -654,10 +654,9 @@ /* Draw nicer bitmap arrow if room, else settle for "<". */ if (text_w >= 6 && pm->font_h >= 8) { - sc->mono_bitmap(bitmap_icons_6x8[Icon_Reverse_Cursor], - (text_w - 6) / 2, - pm->main_y + (pm->font_h - 8) / 2 , - 6, 8); + screen_put_iconxy(sc, (text_w - 6) / 2, + pm->main_y + (pm->font_h - 8) / 2 , + Icon_Reverse_Cursor); } else { @@ -672,10 +671,9 @@ /* Draw nicer bitmap arrow if room, else settle for ">". */ if (text_w >= 6 && pm->font_h >= 8) { - sc->mono_bitmap(bitmap_icons_6x8[Icon_Cursor], - sc->width - text_w + (text_w - 6) / 2, - pm->main_y + (pm->font_h - 8) / 2, - 6, 8); + screen_put_iconxy(sc, sc->width - text_w + (text_w - 6) / 2, + pm->main_y + (pm->font_h - 8) / 2, + Icon_Cursor); } else { Index: apps/recorder/icons.c =================================================================== --- apps/recorder/icons.c (revision 13139) +++ apps/recorder/icons.c (working copy) @@ -44,44 +44,6 @@ #endif }; -const unsigned char bitmap_icons_6x8[][6] = -{ - { 0x60, 0x7f, 0x03, 0x33, 0x3f, 0x00 }, /* Musical note */ - { 0x7e, 0x41, 0x41, 0x42, 0x7e, 0x00 }, /* Folder */ - { 0x55, 0x00, 0x55, 0x55, 0x55, 0x55 }, /* Playlist */ - { 0x3e, 0x1c, 0x08, 0x00, 0x00, 0x00 }, /* Cursor / Marker */ - { 0x58, 0x5f, 0x42, 0x50, 0x55, 0x55 }, /* WPS file */ - { 0x63, 0x7f, 0x3a, 0x7f, 0x63, 0x00 }, /* Mod or ajz file */ - { 0x60, 0x70, 0x38, 0x2c, 0x7e, 0x7e }, /* Font file */ - { 0x3e, 0x2a, 0x3e, 0x2a, 0x2a, 0x3e }, /* Language file */ - { 0x4e, 0x51, 0x51, 0x40, 0x55, 0x55 }, /* Config file */ - { 0x0a, 0x0a, 0x5f, 0x4e, 0x24, 0x18 }, /* Plugin file */ - { 0x7f, 0x41, 0x4f, 0x4a, 0x4c, 0x78 }, /* Bookmark file */ - { 0x5f, 0x45, 0x5b, 0x40, 0x55, 0x55 }, /* Preset file */ - { 0x77, 0x55, 0x55, 0x55, 0x55, 0x77 }, /* Queued Item */ - { 0x3e, 0x41, 0x3e, 0x1c, 0x1c, 0x08 }, /* Moving Item */ - { 0x7f, 0x7f, 0x1c, 0x3e, 0x77, 0x63 }, /* Keyboard file */ - { 0x00, 0x00, 0x00, 0x08, 0x1c, 0x3e }, /* Reverse Cursor / Marker */ - { 0x06, 0x03, 0x5b, 0x5b, 0x0f, 0x06 }, /* question mark */ - { 0x00, 0x18, 0x24, 0x24, 0x18, 0x00 }, /* Menu Settings */ - { 0x00, 0x18, 0x3c, 0x3c, 0x18, 0x00 }, /* function call from the menu */ - { 0x18, 0x18, 0x7e, 0x7e, 0x18, 0x18 }, /* sub menu */ - { 0x01, 0x55, 0x01, 0x55, 0x54, 0x54 }, /* in submenu */ - { 0x1c, 0x3e, 0x7f, 0x7f, 0x3e, 0x1c }, /* Recording menu */ - { 0x1c, 0x1c, 0x22, 0x41, 0x7f, 0x00 }, /* voice menu */ - { 0x06, 0x0f, 0x78, 0x78, 0x0f, 0x06 }, /* general settings menu */ - { 0x1e, 0x22, 0x49, 0x49, 0x22, 0x1e }, /* system menu */ - { 0x7f, 0x7f, 0x3e, 0x1c, 0x08, 0x00 }, /* playback menu */ - { 0x1f, 0x51, 0x71, 0x71, 0x51, 0x1f }, /* display menu */ - { 0x1e, 0x32, 0x32, 0x32, 0x1e, 0x00 }, /* remote display menu */ -#if CONFIG_TUNER - { 0x03, 0x05, 0x7f, 0x05, 0x03, 0x00 }, /* radio */ -#endif - { 0x1f, 0x11, 0x7d, 0x46, 0x44, 0x78 }, /* File View Menu */ - { 0x06, 0x7f, 0x06, 0x18, 0x7f, 0x18 }, /* EQ menu */ - { 0x20, 0x70, 0x70, 0x3f, 0x0a, 0x0a }, /* "rockbox" musical note */ -}; - const unsigned char bitmap_icons_7x8[][7] = { {0x08,0x1c,0x3e,0x3e,0x3e,0x14,0x14}, /* Power plug */ Index: apps/tree.c =================================================================== --- apps/tree.c (revision 13139) +++ apps/tree.c (working copy) @@ -219,20 +219,20 @@ } -static void tree_get_fileicon(int selected_item, void * data, ICON * icon) +static int tree_get_fileicon(int selected_item, void * data) { struct tree_context * local_tc=(struct tree_context *)data; #ifdef HAVE_TAGCACHE bool id3db = *(local_tc->dirfilter) == SHOW_ID3DB; if (id3db) { - *icon = (ICON)tagtree_get_icon(&tc); + return tagtree_get_icon(&tc); } else #endif { struct entry* dc = local_tc->dircache; struct entry* e = &dc[selected_item]; - *icon = (ICON)filetype_get_icon(e->attr); + return filetype_get_icon(e->attr); } } Index: apps/plugins/viewers.config =================================================================== --- apps/plugins/viewers.config (revision 13139) +++ apps/plugins/viewers.config (working copy) @@ -1,32 +1,32 @@ -ch8,viewers/chip8,70 70 7f 7f 70 70 -txt,viewers/viewer,55 55 55 55 55 55 -nfo,viewers/viewer,55 55 55 55 55 55 -txt,rocks/text_editor, 55 55 55 55 55 55 -jpg,viewers/jpeg,18 24 3C 3C 24 18 -jpe,viewers/jpeg,18 24 3C 3C 24 18 -jpeg,viewers/jpeg,18 24 3C 3C 24 18 -ucl,viewers/rockbox_flash,2A 7F 41 41 7F 2A -rvf,viewers/video,5D 7F 5D 7F 5D 7F -mp3,viewers/vbrfix,10 08 58 38 04 02 -m3u,viewers/search,00 00 00 00 00 00 -txt,viewers/sort,00 00 00 00 00 00 -gb,viewers/rockboy,0C 2A 59 7A 2E 0C -gbc,viewers/rockboy,0C 2A 59 7A 2E 0C -m3u,viewers/iriverify,00 00 00 00 00 00 -mid,viewers/midiplay,20 70 70 3F 00 00 -rmi,viewers/midiplay,20 70 70 3F 00 00 -rsp,viewers/searchengine,0e 11 11 31 7e 60 -ss,rocks/sudoku,55 55 55 55 55 55 -wav,viewers/wav2wv,00 00 00 00 00 00 -wav,viewers/mp3_encoder,00 00 00 00 00 00 -wav,viewers/wavplay,60 7F 05 35 3F 00 -wav,viewers/wavview,18 7E 3C FF 7E 18 -bmp,rocks/rockpaint,01 10 01 10 01 10 -mpg,viewers/mpegplayer,5D 7F 5D 7F 5D 7F -mpeg,viewers/mpegplayer,5D 7F 5D 7F 5D 7F -iriver,viewers/iriver_flash,2A 7F 41 41 7F 2A -tap,viewers/zxbox,66 52 4A 66 52 4A -sna,viewers/zxbox,66 52 4A 66 52 4A -tzx,viewers/zxbox,66 52 4A 66 52 4A -z80,viewers/zxbox,66 52 4A 66 52 4A -zzz,viewers/properties,00 00 00 00 00 00 +ch8,viewers/chip8,1 +txt,viewers/viewer,2 +nfo,viewers/viewer,2 +txt,rocks/text_editor,3 +jpg,viewers/jpeg,3 +jpe,viewers/jpeg,3 +jpeg,viewers/jpeg,3 +ucl,viewers/rockbox_flash,4 +rvf,viewers/video,5 +mp3,viewers/vbrfix,6 +m3u,viewers/search,- +txt,viewers/sort,- +gb,viewers/rockboy,7 +gbc,viewers/rockboy,7 +m3u,viewers/iriverify,- +mid,viewers/midiplay,8 +rmi,viewers/midiplay,8 +rsp,viewers/searchengine,9 +ss,rocks/sudoku,2 +wav,viewers/wav2wv,- +wav,viewers/mp3_encoder,- +wav,viewers/wavplay,b0 +wav,viewers/wavview,11 +bmp,rocks/rockpaint,12 +mpg,viewers/mpegplayer,5 +mpeg,viewers/mpegplayer,5 +iriver,viewers/iriver_flash,4 +tap,viewers/zxbox,13 +sna,viewers/zxbox,13 +tzx,viewers/zxbox,13 +z80,viewers/zxbox,13 +zzz,viewers/properties,- Index: apps/lang/english.lang =================================================================== --- apps/lang/english.lang (revision 13139) +++ apps/lang/english.lang (working copy) @@ -10741,3 +10741,45 @@ *: "Context Menu" + + id: LANG_ICON_HEIGHT + desc: icon height setting + user: + + *: "Icon Height" + + + *: "Icon Height" + + + *: "Icon Height" + + + + id: LANG_USE_FOR_ICONSET + desc: use the bmp for the iconset + user: + + *: "Use For Iconset" + + + *: "Use For Iconset" + + + *: "Use For Iconset" + + + + id: LANG_USE_FOR_REMOTE_ICONSET + desc: use the bmp for the iconset + user: + + *: "Use For Remote Iconset" + + + *: "Use For Remote Iconset" + + + *: "Use For Remote Iconset" + + Index: apps/settings.c =================================================================== --- apps/settings.c (revision 13139) +++ apps/settings.c (working copy) @@ -853,6 +853,9 @@ #if defined(HAVE_RECORDING) && CONFIG_CODEC == SWCODEC enc_global_settings_apply(); #endif + /* load the icon set */ + icons_init(); + } @@ -1076,13 +1079,7 @@ else oldvalue = *(bool*)variable; gui_synclist_init(&lists,value_setting_get_name_cb,(void*)cb_data,false,1); - gui_synclist_set_title(&lists, (char*)string, -#ifdef HAVE_LCD_BITMAP - bitmap_icons_6x8[Icon_Questionmark] -#else - NOICON -#endif - ); + gui_synclist_set_title(&lists, (char*)string,Icon_Questionmark); gui_synclist_set_icon_callback(&lists,NULL); gui_synclist_set_nb_items(&lists,nb_items); gui_synclist_limit_scroll(&lists,true); Index: apps/onplay.c =================================================================== --- apps/onplay.c (revision 13139) +++ apps/onplay.c (working copy) @@ -513,7 +513,26 @@ } } #endif - +#ifdef HAVE_LCD_BITMAP +static bool load_iconset(void) +{ + load_icons(selected_file, SCREEN_MAIN); + set_file(selected_file, (char *)global_settings.icon_file, MAX_FILENAME); + /* assume custom icons are square, should be right more often than not */ + global_settings.icon_height = get_icon_width(SCREEN_MAIN); + return false; +} +#ifdef HAVE_REMOTE_LCD +static bool load_remote_iconset(void) +{ + load_icons(selected_file, SCREEN_REMOTE); + set_file(selected_file, (char *)global_settings.remote_icon_file, MAX_FILENAME); + /* assume custom icons are square, should be right more often than not */ + global_settings.remote_icon_height = get_icon_width(SCREEN_REMOTE); + return false; +} +#endif +#endif /* HAVE_LCD_BITMAP */ static bool rename_file(void) { char newname[MAX_PATH]; @@ -880,12 +899,12 @@ int onplay(char* file, int attr, int from) { #if CONFIG_CODEC == SWCODEC - struct menu_item items[14]; /* increase this if you add entries! */ + struct menu_item items[16]; /* increase this if you add entries! */ #else - struct menu_item items[12]; + struct menu_item items[14]; #endif int m, i=0, result; -#if LCD_DEPTH > 1 +#ifdef HAVE_LCD_BITMAP char *suffix; #endif @@ -971,18 +990,29 @@ items[i].function = delete_file; i++; -#if LCD_DEPTH > 1 +#ifdef HAVE_LCD_BITMAP suffix = strrchr(file, '.'); if (suffix) { if (strcasecmp(suffix, ".bmp") == 0) { +#if LCD_DEPTH > 1 items[i].desc = ID2P(LANG_SET_AS_BACKDROP); items[i].function = set_backdrop; i++; +#endif + + items[i].desc = ID2P(LANG_USE_FOR_ICONSET); + items[i].function = load_iconset; + i++; +#ifdef HAVE_REMOTE_LCD + items[i].desc = ID2P(LANG_USE_FOR_REMOTE_ICONSET); + items[i].function = load_remote_iconset; + i++; +#endif } } -#endif +#endif /* HAVE_LCD_BITMAP */ } else { Index: apps/gui/color_picker.c =================================================================== --- apps/gui/color_picker.c (revision 13139) +++ apps/gui/color_picker.c (working copy) @@ -31,7 +31,7 @@ #include "lang.h" #include "splash.h" #include "action.h" -#include "icons.h" +#include "icon.h" /* structure for color info */ struct rgb_pick @@ -220,13 +220,11 @@ /* Draw "> <" around sliders */ int top = text_top + (display->char_height - SELECTOR_HEIGHT) / 2; - display->mono_bitmap(bitmap_icons_6x8[Icon_Cursor], - MARGIN_LEFT, top, - SELECTOR_WIDTH, SELECTOR_HEIGHT); - display->mono_bitmap(bitmap_icons_6x8[Icon_Reverse_Cursor], - display->width - MARGIN_RIGHT - - SELECTOR_WIDTH, top, SELECTOR_WIDTH, - SELECTOR_HEIGHT); + screen_put_iconxy(display, MARGIN_LEFT, top, Icon_Cursor); + screen_put_iconxy(display, + display->width - MARGIN_RIGHT - + get_icon_width(display->screen_type), + top, Icon_Cursor); } if (display->depth >= 16) Index: apps/gui/list.c =================================================================== --- apps/gui/list.c (revision 13139) +++ apps/gui/list.c (working copy) @@ -92,7 +92,7 @@ gui_list->selected_size=selected_size; gui_list->title = NULL; gui_list->title_width = 0; - gui_list->title_icon = NOICON; + gui_list->title_icon = Icon_NOICON; gui_list->last_displayed_selected_item = -1 ; gui_list->last_displayed_start_item = -1 ; @@ -230,8 +230,6 @@ static void gui_list_draw_smart(struct gui_list *gui_list) { struct screen * display=gui_list->display; - int cursor_pos = 0; - int icon_pos = 1; int text_pos; bool draw_icons = (gui_list->callback_get_item_icon != NULL && global_settings.show_icons); bool draw_cursor; @@ -288,9 +286,9 @@ { if (gui_list->title_icon != NOICON && draw_icons) { - screen_put_iconxy(display, 0, 0, gui_list->title_icon); + screen_put_icon(display, 0, 0, gui_list->title_icon); #ifdef HAVE_LCD_BITMAP - text_pos = 8; /* pixels */ + text_pos = get_icon_width(display->screen_type)+1; /* pixels */ #else text_pos = 1; /* chars */ #endif @@ -327,17 +325,13 @@ if(draw_scrollbar || SHOW_LIST_TITLE) /* indent if there's a title */ { - cursor_pos++; - icon_pos++; text_pos += SCROLLBAR_WIDTH; } - if(!draw_cursor) - icon_pos--; - else - text_pos += CURSOR_WIDTH; + if(draw_cursor) + text_pos += get_icon_width(display->screen_type) + 1; if(draw_icons) - text_pos += 8; + text_pos += get_icon_width(display->screen_type) + 1; #else draw_cursor = true; if(draw_icons) @@ -413,7 +407,12 @@ #endif if (draw_cursor) - screen_put_cursorxy(display, cursor_pos, i, true); + { + screen_put_icon_with_offset(display, 0, i, + (draw_scrollbar || SHOW_LIST_TITLE)? + SCROLLBAR_WIDTH: 0, + 0, Icon_Cursor); + } } else {/* normal item */ @@ -437,12 +436,15 @@ /* Icons display */ if(draw_icons) { - ICON icon; - gui_list->callback_get_item_icon(current_item, - gui_list->data, - &icon); - if(icon) - screen_put_iconxy(display, icon_pos, i, icon); + enum themable_icons icon; + icon = gui_list->callback_get_item_icon(current_item, gui_list->data); + if(icon > Icon_NOICON) + { + int x = draw_cursor?1:0; + int x_off = (draw_scrollbar || SHOW_LIST_TITLE) ? SCROLLBAR_WIDTH: 0; + screen_put_icon_with_offset(display, x, i, + x_off, 0, icon); + } } } @@ -737,7 +739,8 @@ * Set the title and title icon of the list. Setting title to NULL disables * both the title and icon. Use NOICON if there is no icon. */ -static void gui_list_set_title(struct gui_list * gui_list, char * title, ICON icon) +static void gui_list_set_title(struct gui_list * gui_list, + char * title, enum themable_icons icon) { gui_list->title = title; gui_list->title_icon = icon; @@ -870,7 +873,7 @@ } void gui_synclist_set_title(struct gui_synclist * lists, - char * title, ICON icon) + char * title, enum themable_icons icon) { int i; FOR_NB_SCREENS(i) Index: apps/gui/list.h =================================================================== --- apps/gui/list.h (revision 13139) +++ apps/gui/list.h (working copy) @@ -49,9 +49,7 @@ * the icon after the function returns. * Note : we use the ICON type because the real type depends of the plateform */ -typedef void list_get_icon(int selected_item, - void * data, - ICON * icon); +typedef enum themable_icons list_get_icon(int selected_item, void * data); /* * Text callback * - selected_item : an integer that tells the number of the item to display @@ -101,7 +99,7 @@ /* The optional title, set to NULL for none */ char * title; /* Optional title icon */ - ICON title_icon; + enum themable_icons title_icon; }; /* @@ -190,7 +188,7 @@ extern void gui_synclist_limit_scroll(struct gui_synclist * lists, bool scroll); extern void gui_synclist_flash(struct gui_synclist * lists); extern void gui_synclist_set_title(struct gui_synclist * lists, char * title, - ICON icon); + int icon); /* * Do the action implied by the given button, Index: apps/gui/icon.c =================================================================== --- apps/gui/icon.c (revision 13139) +++ apps/gui/icon.c (working copy) @@ -7,7 +7,7 @@ * \/ \/ \/ \/ \/ * $Id$ * - * Copyright (C) Robert E. Hak(2002) + * Copyright (C) 2007 Jonathan Gordon * * All files in this archive are subject to the GNU General Public License. * See the file COPYING in the source tree root for full license agreement. @@ -16,42 +16,210 @@ * KIND, either express or implied. * ****************************************************************************/ - +#include +#include +#include +#include "inttypes.h" #include "config.h" #include "icon.h" #include "screen_access.h" #include "icons.h" +#include "settings.h" +#include "bmp.h" +/* Quick and Dirty hack untill lcd bitmap drawing is fixed */ +#ifdef HAVE_REMOTE_LCD +#include "lcd-remote.h" +#endif -/* Count in letter positions, NOT pixels */ -void screen_put_iconxy(struct screen * display, int x, int y, ICON icon) + +#include +#ifdef HAVE_REMOTE_LCD +#include +#endif + +/* These should robably be moved to config-.h */ +#define MAX_ICON_HEIGHT 24 +#define MAX_ICON_WIDTH 24 +#define DEFAULT_ICON_HEIGHT 8 +#define DEFAULT_REMOTE_ICON_HEIGHT 8 +#define MAX_ICONS (Icon_Last_Themeable+16) /* The 16 is the number of different + icons in viewers.config */ +static int get_icon_height(enum screen_type screen_type); + +/* We dont actually do anything with these pointers, + but they need to be grouped like this to save code + so storing them as void* is ok. (stops compile warning) */ +static const void * inbuilt_icons[NB_SCREENS] = { + (void*)default_icons +#ifdef HAVE_REMOTE_LCD + , (void*)remote_default_icons +#endif +}; + +static const int default_width[NB_SCREENS] = { + BMPWIDTH_default_icons +#ifdef HAVE_REMOTE_LCD + , BMPWIDTH_remote_default_icons +#endif +}; + +/* height of each icon */ +static const int default_icon_height[NB_SCREENS] = { + DEFAULT_ICON_HEIGHT +#ifdef HAVE_REMOTE_LCD + , DEFAULT_REMOTE_ICON_HEIGHT +#endif +}; +/* height of whole file */ +static const int default_height[NB_SCREENS] = { + BMPHEIGHT_default_icons +#ifdef HAVE_REMOTE_LCD + , BMPHEIGHT_remote_default_icons +#endif +}; + +#define IMG_BUFSIZE (MAX_ICON_HEIGHT * MAX_ICON_WIDTH * MAX_ICONS *LCD_DEPTH/8) +static unsigned char icon_buffer[IMG_BUFSIZE][NB_SCREENS]; +static bool use_inbuilt[NB_SCREENS] = {false}; +static struct bitmap user_iconset[NB_SCREENS]; + +/* x,y in letter positions */ +#define ICONWIDTH(screen) (use_inbuilt[screen]? \ + default_width[screen] : \ + user_iconset[screen].width) + +/* x,y in letters, not pixles */ +void screen_put_icon(struct screen * display, + int x, int y, enum themable_icons icon) { -#ifdef HAVE_LCD_BITMAP + screen_put_icon_with_offset(display, x, y, 0, 0, icon); +} + +void screen_put_icon_with_offset(struct screen * display, + int x, int y, int off_x, int off_y, + enum themable_icons icon) +{ + int xpos, ypos; int width, height; - int xpos, ypos; + int screen = display->screen_type; display->getstringsize((unsigned char *)"M", &width, &height); - xpos = x*CURSOR_WIDTH; - ypos = y*height + display->getymargin(); + xpos = x*ICONWIDTH(screen) + off_x; + ypos = y*height + display->getymargin() + off_y; - if ( height > CURSOR_HEIGHT )/* center the cursor */ - ypos += (height - CURSOR_HEIGHT) / 2; - if(icon==0)/* Don't display invalid icons */ - screen_clear_area(display, xpos, ypos, CURSOR_WIDTH, CURSOR_HEIGHT); + if ( height > get_icon_height(screen) )/* center the cursor */ + ypos += (height - get_icon_height(screen)) / 2; + screen_put_iconxy(display, xpos, ypos, icon); +} + +/* x,y in pixels */ +void screen_put_iconxy(struct screen * display, + int xpos, int ypos, enum themable_icons icon) +{ + fb_data *data; + int screen = display->screen_type; + if (((icon >= MAX_ICONS) || (icon == Icon_NOICON)) || + (!use_inbuilt[screen] && + (icon*get_icon_height(screen) > user_iconset[screen].height))) + { + screen_clear_area(display, xpos, ypos, + ICONWIDTH(screen), get_icon_height(screen)); + return; + } + if (use_inbuilt[screen]) + { + data = (fb_data *)inbuilt_icons[screen]; + } else - display->mono_bitmap(icon, xpos, ypos, CURSOR_WIDTH, CURSOR_HEIGHT); -#else - if(icon==-1) - display->putc(x, y, ' '); - else - display->putc(x, y, icon); + { + data = (fb_data *)user_iconset[screen].data; + } + /* add some left padding to the icons if they are on the edge */ + if (xpos == 0) + xpos++; + +#ifdef HAVE_REMOTE_LCD + if (display->screen_type == SCREEN_REMOTE) + { + /* Quick and Dirty hack untill lcd bitmap drawing is fixed */ + lcd_remote_bitmap_part((unsigned char *)data, + get_icon_width(screen)*icon, 0, + ICONWIDTH(screen), xpos, ypos, + ICONWIDTH(screen), get_icon_height(screen)); + return; + } #endif +#if LCD_DEPTH == 16 + display->transparent_bitmap_part(data, 0, get_icon_height(screen)*icon, + ICONWIDTH(screen), xpos, ypos, + ICONWIDTH(screen), get_icon_height(screen)); +#else /* LCD_DEPTH < 16 */ + display->bitmap_part(data, get_icon_width(screen)*icon, 0, + ICONWIDTH(screen), xpos, ypos, + ICONWIDTH(screen), get_icon_height(screen)); +#endif /* LCD_DEPTH == 16 */ } void screen_put_cursorxy(struct screen * display, int x, int y, bool on) { #ifdef HAVE_LCD_BITMAP - screen_put_iconxy(display, x, y, on?bitmap_icons_6x8[Icon_Cursor]:0); + screen_put_icon(display, x, y, on?Icon_Cursor:0); #else - screen_put_iconxy(display, x, y, on?CURSOR_CHAR:-1); + screen_put_icon(display, x, y, on?CURSOR_CHAR:-1); #endif } + +void load_icons(const char* filename, enum screen_type screen_type) +{ + int size_read; + if (filename && (icon_buffer[screen_type] == NULL)) + load_icons(NULL, screen_type); /* force a buffer init an inbuilt icon load before + loading the users iconset */ + + use_inbuilt[screen_type] = true; + + if (filename != NULL) + { + user_iconset[screen_type].data = icon_buffer[screen_type]; + size_read = read_bmp_file((char*)filename, &user_iconset[screen_type], + IMG_BUFSIZE, + FORMAT_NATIVE | FORMAT_DITHER); + if (size_read > 0) + { + use_inbuilt[screen_type] = false; + } + } +} + + +void icons_init(void) +{ + char path[MAX_PATH]; + snprintf(path, MAX_PATH, "%s/%s.bmp", ICON_DIR, global_settings.icon_file); + load_icons(global_settings.icon_file[0]?path:NULL, SCREEN_MAIN); +#ifdef HAVE_REMOTE_LCD + snprintf(path, MAX_PATH, "%s/%s.bmp", ICON_DIR, + global_settings.remote_icon_file); + load_icons(global_settings.remote_icon_file[0]?path:NULL, SCREEN_REMOTE); +#endif +} + +int get_icon_width(enum screen_type screen_type) +{ + return ICONWIDTH(screen_type); +} + +static int get_icon_height(enum screen_type screen_type) +{ + if (use_inbuilt[screen_type]) + return default_icon_height[screen_type]; + else + { +#ifdef HAVE_REMOTE_LCD + if (screen_type == SCREEN_REMOTE) + return global_settings.remote_icon_height; + else +#endif + return global_settings.icon_height; + } +} Index: apps/gui/icon.h =================================================================== --- apps/gui/icon.h (revision 13139) +++ apps/gui/icon.h (working copy) @@ -24,19 +24,51 @@ * char-based displays and bitmap displays */ #ifdef HAVE_LCD_BITMAP typedef const unsigned char * ICON; -typedef unsigned char * ICON_NO_CONST; -#define NOICON NULL +#define NOICON Icon_NOICON #else typedef long ICON; -#define ICON_NO_CONST ICON -#define NOICON -1 +#define NOICON Icon_NOICON #endif -#define Icon_NOICON -1 -#define CURSOR_CHAR 0xe10c -#define CURSOR_WIDTH 6 -#define CURSOR_HEIGHT 8 +/* Don't #ifdef icon values, or we wont be able to use the same + cmp for every target. */ +enum themable_icons { + Icon_NOICON = -1, /* Dont put this in a .bmp */ + Icon_Audio, + Icon_Folder, + Icon_Playlist, + Icon_Cursor, + Icon_Wps, + Icon_Firmware, + Icon_Font, + Icon_Language, + Icon_Config, + Icon_Plugin, + Icon_Bookmark, + Icon_Preset, + Icon_Queued, + Icon_Moving, + Icon_Keyboard, + Icon_Reverse_Cursor, + Icon_Questionmark, + Icon_Menu_setting, + Icon_Menu_functioncall, + Icon_Submenu, + Icon_Submenu_Entered, + Icon_Recording, + Icon_Voice, + Icon_General_settings_menu, + Icon_System_menu, + Icon_Playback_menu, + Icon_Display_menu, + Icon_Remote_Display_menu, + Icon_Radio_screen, + Icon_file_view_menu, + Icon_EQ, + Icon_Rockbox, + Icon_Last_Themeable, +}; /* * Draws a cursor at a given position, if th @@ -49,12 +81,39 @@ /* * Put an icon on a screen at a given position * (the position is given in characters) - * If the given icon is null (HAVE_LCD_BITMAP) or -1 otherwise, the icon + * If the given icon is Icon_blank, the icon * at the given position will be erased * - screen : the screen where we put our icon - * - x, y : the position, in character, not in pixel !! + * - x, y : the position, pixel value !! * - icon : the icon to put */ -extern void screen_put_iconxy(struct screen * screen, int x, int y, ICON icon); +extern void screen_put_iconxy(struct screen * screen, + int x, int y, enum themable_icons icon); +#ifdef HAVE_LCD_CHARCELLS +# define screen_put_icon(s, x, y, i) screen_put_iconxy +# define screen_put_icon_with_ofset(s, x, y, w, h, i) screen_put_icon(s, x, y, i) +#else +/* For both of these, the icon will be placed in the center of the rectangle */ +/* as above, but x,y are letter position, NOT PIXEL */ +extern void screen_put_icon(struct screen * screen, + int x, int y, enum themable_icons icon); +/* as above (x,y are letter pos), but with a pxiel offset for both */ +extern void screen_put_icon_with_offset(struct screen * display, + int x, int y, int off_x, int off_y, + enum themable_icons icon); +#endif + +void load_icons(const char* filename, enum screen_type screen_type); + +void icons_init(void); + + +#ifdef HAVE_LCD_CHARCELLS +# define CURSOR_CHAR 0xe10c +# define get_icon_width(a) 6 +#else +int get_icon_width(enum screen_type screen_type); +#endif + #endif /*_GUI_ICON_H_*/ Index: apps/menu.c =================================================================== --- apps/menu.c (revision 13139) +++ apps/menu.c (working copy) @@ -136,7 +136,7 @@ return P2STR(menu->callback_and_desc->desc); } #ifdef HAVE_LCD_BITMAP -static void menu_get_icon(int selected_item, void * data, ICON * icon) +static int menu_get_icon(int selected_item, void * data) { const struct menu_item_ex *menu = (const struct menu_item_ex *)data; int menu_icon = Icon_NOICON; @@ -144,8 +144,7 @@ if ((menu->flags&MENU_TYPE_MASK) == MT_RETURN_ID) { - *icon = bitmap_icons_6x8[Icon_Menu_functioncall]; - return; + return Icon_Menu_functioncall; } menu = menu->submenus[selected_item]; if (menu->flags&MENU_HAS_DESC) @@ -153,28 +152,24 @@ else if (menu->flags&MENU_DYNAMIC_DESC) menu_icon = menu->menu_get_name_and_icon->icon_id; - switch (menu->flags&MENU_TYPE_MASK) + if (menu_icon == Icon_NOICON) { - case MT_SETTING: - case MT_SETTING_W_TEXT: - *icon = bitmap_icons_6x8[Icon_Menu_setting]; - break; - case MT_MENU: - if (menu_icon == Icon_NOICON) - *icon = bitmap_icons_6x8[Icon_Submenu]; - else - *icon = bitmap_icons_6x8[menu_icon]; - break; - case MT_FUNCTION_CALL: - case MT_RETURN_VALUE: - if (menu_icon == Icon_NOICON) - *icon = bitmap_icons_6x8[Icon_Menu_functioncall]; - else - *icon = bitmap_icons_6x8[menu_icon]; - break; - default: - *icon = NOICON; + switch (menu->flags&MENU_TYPE_MASK) + { + case MT_SETTING: + case MT_SETTING_W_TEXT: + menu_icon = Icon_Menu_setting; + break; + case MT_MENU: + menu_icon = Icon_Submenu; + break; + case MT_FUNCTION_CALL: + case MT_RETURN_VALUE: + menu_icon = Icon_Menu_functioncall; + break; + } } + return menu_icon; } #endif @@ -184,7 +179,7 @@ int i, count = MENU_GET_COUNT(menu->flags); int type = (menu->flags&MENU_TYPE_MASK); menu_callback_type menu_callback = NULL; - ICON icon = NOICON; + int icon; current_subitems_count = 0; if (type == MT_OLD_MENU) @@ -220,9 +215,9 @@ gui_synclist_init(lists,get_menu_item_name,(void*)menu,false,1); #ifdef HAVE_LCD_BITMAP if (menu->callback_and_desc->icon_id == Icon_NOICON) - icon = bitmap_icons_6x8[Icon_Submenu_Entered]; + icon = Icon_Submenu_Entered; else - icon = bitmap_icons_6x8[menu->callback_and_desc->icon_id]; + icon = menu->callback_and_desc->icon_id; gui_synclist_set_title(lists, P2STR(menu->callback_and_desc->desc), icon); gui_synclist_set_icon_callback(lists, menu_get_icon); #else @@ -704,10 +699,10 @@ } #ifdef HAVE_LCD_BITMAP -static void oldmenu_get_icon(int selected_item, void * data, ICON * icon) +static int oldmenu_get_icon(int selected_item, void * data) { (void)data; (void)selected_item; - *icon = bitmap_icons_6x8[Icon_Menu_functioncall]; + return Icon_Menu_functioncall; } #endif @@ -722,7 +717,7 @@ gui_synclist_select_item(lists, selected); #ifdef HAVE_LCD_BITMAP gui_synclist_set_title(lists, menus[menu->value].title, - bitmap_icons_6x8[Icon_Submenu_Entered]); + Icon_Submenu_Entered); gui_synclist_set_icon_callback(lists, oldmenu_get_icon); #endif } Index: apps/settings.h =================================================================== --- apps/settings.h (revision 13139) +++ apps/settings.h (working copy) @@ -55,6 +55,7 @@ #define LANG_DIR ROCKBOX_DIR "/langs" #define WPS_DIR ROCKBOX_DIR "/wps" #define THEME_DIR ROCKBOX_DIR "/themes" +#define ICON_DIR ROCKBOX_DIR "/icons" #define PLUGIN_DIR ROCKBOX_DIR "/rocks" #define VIEWERS_DIR ROCKBOX_DIR "/viewers" #define BACKDROP_DIR ROCKBOX_DIR "/backdrops" @@ -706,7 +707,13 @@ (defined(HAVE_RECORDING) || CONFIG_TUNER) int alarm_wake_up_screen; #endif - + /* customizable icons */ + unsigned char icon_file[MAX_FILENAME+1]; + int icon_height; +#ifdef HAVE_REMOTE_LCD + unsigned char remote_icon_file[MAX_FILENAME+1]; + int remote_icon_height; +#endif }; /** global variables **/ Index: apps/menus/display_menu.c =================================================================== --- apps/menus/display_menu.c (revision 13139) +++ apps/menus/display_menu.c (working copy) @@ -169,7 +169,9 @@ MENUITEM_FUNCTION(reset_colors, 0, ID2P(LANG_RESET_COLORS), reset_color, NULL, NULL, Icon_NOICON); #endif - +#ifdef HAVE_LCD_BITMAP +MENUITEM_SETTING(icon_height, &global_settings.icon_height, NULL); +#endif /* now the actual menu */ MAKE_MENU(lcd_settings,ID2P(LANG_LCD_MENU), NULL, Icon_Display_menu @@ -203,14 +205,17 @@ # ifdef HAVE_LCD_FLIP ,&flip_display # endif - ,&invert_cursor + ,&invert_cursor, #endif /* HAVE_LCD_BITMAP */ #if LCD_DEPTH > 1 - ,&clear_main_bd, + &clear_main_bd, #endif #ifdef HAVE_LCD_COLOR - &set_bg_col, &set_fg_col, &reset_colors + &set_bg_col, &set_fg_col, &reset_colors, #endif +#ifdef HAVE_LCD_BITMAP + &icon_height +#endif ); /* LCD MENU */ /***********************************/ @@ -260,6 +265,7 @@ MENUITEM_SETTING(remote_reduce_ticking, &global_settings.remote_reduce_ticking, ticking_callback); #endif +MENUITEM_SETTING(remote_icon_height, &global_settings.remote_icon_height, NULL); MAKE_MENU(lcd_remote_settings, ID2P(LANG_LCD_REMOTE_MENU), NULL, Icon_Remote_Display_menu, @@ -275,6 +281,7 @@ #ifdef HAVE_REMOTE_LCD_TICKING ,&remote_reduce_ticking #endif + ,&remote_icon_height ); #endif /* HAVE_REMOTE_LCD */ Index: apps/bitmaps/remote_native/SOURCES =================================================================== --- apps/bitmaps/remote_native/SOURCES (revision 13139) +++ apps/bitmaps/remote_native/SOURCES (working copy) @@ -3,9 +3,11 @@ #if (LCD_REMOTE_DEPTH == 1) remote_rockboxlogo.128x42x1.bmp remote_usblogo.104x27x1.bmp +remote_default_icons.6x8x1.bmp #elif (LCD_REMOTE_DEPTH == 2) remote_rockboxlogo.128x42x2.bmp remote_usblogo.104x27x2.bmp +remote_default_icons.6x8x2.bmp #endif #endif /* HAVE_REMOTE_LCD */ Index: apps/bitmaps/native/SOURCES =================================================================== --- apps/bitmaps/native/SOURCES (revision 13139) +++ apps/bitmaps/native/SOURCES (working copy) @@ -40,4 +40,11 @@ #endif #endif +/* List Icons */ +#if LCD_DEPTH == 16 +default_icons.6x8x16.bmp +#else +default_icons.6x8x1.bmp +#endif + #endif /* HAVE_LCD_BITMAP */ Index: apps/playlist_viewer.c =================================================================== --- apps/playlist_viewer.c (revision 13139) +++ apps/playlist_viewer.c (working copy) @@ -570,7 +570,7 @@ } -static void playlist_callback_icons(int selected_item, void *data, ICON * icon) +static int playlist_callback_icons(int selected_item, void *data) { struct playlist_viewer * local_viewer=(struct playlist_viewer *)data; struct playlist_entry *track= @@ -578,36 +578,20 @@ if (track->index == local_viewer->current_playing_track) { /* Current playing track */ -#ifdef HAVE_LCD_BITMAP - *icon=bitmap_icons_6x8[Icon_Audio]; -#else - *icon=Icon_Audio; -#endif + return Icon_Audio; } else if (track->index == local_viewer->move_track) { /* Track we are moving */ -#ifdef HAVE_LCD_BITMAP - *icon=bitmap_icons_6x8[Icon_Moving]; -#else - *icon=Icon_Moving; -#endif + return Icon_Moving; } else if (track->queued) { /* Queued track */ -#ifdef HAVE_LCD_BITMAP - *icon=bitmap_icons_6x8[Icon_Queued]; -#else - *icon=Icon_Queued; -#endif + return Icon_Queued; } else -#ifdef HAVE_LCD_BITMAP - *icon=0; -#else - *icon=-1; -#endif + return Icon_NOICON; } /* Main viewer function. Filename identifies playlist to be viewed. If NULL, @@ -627,13 +611,13 @@ &playlist_callback_icons:NULL); gui_synclist_set_nb_items(&playlist_lists, viewer.num_tracks); gui_synclist_select_item(&playlist_lists, viewer.selected_track); - gui_synclist_set_title(&playlist_lists, str(LANG_PLAYLIST_MENU), + gui_synclist_set_title(&playlist_lists, str(LANG_PLAYLIST_MENU), Icon_Playlist);/* #ifdef HAVE_LCD_BITMAP bitmap_icons_6x8[Icon_Playlist] #else NOICON #endif - ); + );*/ gui_synclist_draw(&playlist_lists); action_signalscreenchange(); while (!exit) @@ -800,17 +784,6 @@ return(buffer); } - -static void playlist_search_callback_icons(int selected_item, void * data, ICON * icon) -{ - (void)selected_item; - (void)data; -#ifdef HAVE_LCD_BITMAP - *icon=0; -#else - *icon=-1; -#endif -} bool search_playlist(void) { char search_str[32] = ""; @@ -851,9 +824,7 @@ backlight_on(); gui_synclist_init(&playlist_lists, playlist_search_callback_name, found_indicies, false, 1); - gui_synclist_set_icon_callback(&playlist_lists, - global_settings.playlist_viewer_icons? - &playlist_search_callback_icons:NULL); + gui_synclist_set_icon_callback(&playlist_lists, NULL); gui_synclist_set_nb_items(&playlist_lists, found_indicies_count); gui_synclist_select_item(&playlist_lists, 0); gui_synclist_draw(&playlist_lists); Index: apps/settings_list.c =================================================================== --- apps/settings_list.c (revision 13139) +++ apps/settings_list.c (working copy) @@ -1160,6 +1160,22 @@ {F_T_INT, &global_settings.alarm_wake_up_screen, LANG_ALARM_WAKEUP_SCREEN, INT(ALARM_START_WPS), "alarm wakeup screen", ALARM_SETTING_TEXT, UNUSED}, #endif /* HAVE_RTC_ALARM */ + + /* Customizable icons */ +#ifdef HAVE_LCD_BITMAP + FILENAME_SETTING(F_THEMESETTING, icon_file, "iconset", "", + ICON_DIR "/", ".bmp", MAX_FILENAME+1), + INT_SETTING(F_THEMESETTING, icon_height, + LANG_ICON_HEIGHT, 8, "icon height", + UNIT_PIXEL, 0, 24, 1, NULL, NULL,NULL) , +#ifdef HAVE_REMOTE_LCD + FILENAME_SETTING(F_THEMESETTING, remote_icon_file, "remote iconset", "", + ICON_DIR "/", ".bmp", MAX_FILENAME+1), + INT_SETTING(F_THEMESETTING, remote_icon_height, + LANG_ICON_HEIGHT, 8, "remote icon height", + UNIT_PIXEL, 0, 24, 1, NULL, NULL,NULL) , +#endif +#endif /* HAVE_REMOTE_LCD */ }; const int nb_settings = sizeof(settings)/sizeof(*settings); Index: apps/player/icons.h =================================================================== --- apps/player/icons.h (revision 13139) +++ apps/player/icons.h (working copy) @@ -25,50 +25,5 @@ * Icons of size 5x7 pixels for the Player LCD */ -#ifdef HAVE_LCD_CHARCELLS -enum { - Icon_Queued = 'Q', - Icon_Moving = 'M', - Icon_Unknown = 0xe100, - Icon_Bookmark, - Icon_Plugin, - Icon_Folder, - Icon_Firmware, - Icon_Language, - Icon_Audio, - Icon_Wps, - Icon_Playlist, - Icon_Text, - Icon_Config, -}; - -/* put icons from the 6x8 enum here if the player - doesnt have an icon for it */ -enum unused_but_needed { - Icon_Cursor, - Icon_Font, - Icon_Preset, - Icon_Keyboard, - Icon_Reverse_Cursor, - Icon_Questionmark, - Icon_Menu_setting, - Icon_Menu_functioncall, - Icon_Submenu, - Icon_Submenu_Entered, - Icon_Recording, - Icon_Voice, - Icon_General_settings_menu, - Icon_System_menu, - Icon_Playback_menu, - Icon_Display_menu, - Icon_Remote_Display_menu, - Icon_Radio_screen, - Icon_file_view_menu, - Icon_EQ, - Icon_Rockbox, - Icon6x8Last, -}; -#endif - #endif /* _ICONS_H_ */ Index: apps/player/icons.c =================================================================== --- apps/player/icons.c (revision 13139) +++ apps/player/icons.c (working copy) @@ -7,7 +7,7 @@ * \/ \/ \/ \/ \/ * $Id$ * - * Copyright (C) 2002 Justin Heiner + * Copyright (C) 2007 Jonathan Gordon * * All files in this archive are subject to the GNU General Public License. * See the file COPYING in the source tree root for full license agreement. @@ -17,8 +17,97 @@ * ****************************************************************************/ #include "lcd.h" -#include "icons.h" +#include "icon.h" #ifdef HAVE_LCD_CHARCELLS +/* For the moment, charcell cant load custom maps... */ +enum old_values{ + old_Icon_Queued = 'Q', + old_Icon_Moving = 'M', + old_Icon_Unknown = 0xe100, + old_Icon_Bookmark, + old_Icon_Plugin, + old_Icon_Folder, + old_Icon_Firmware, + old_Icon_Language, + old_Icon_Audio, + old_Icon_Wps, + old_Icon_Playlist, + old_Icon_Text, + old_Icon_Config, +}; + +static const long icons[Icon_Last_Themeable] = { + [0 ... Icon_Last_Themeable-1] = 0, + + [Icon_Audio] = old_Icon_Audio, + [Icon_Folder] = old_Icon_Folder, + [Icon_Playlist] = old_Icon_Playlist, + [Icon_Cursor] = CURSOR_CHAR, + [Icon_Wps] = old_Icon_Wps, + [Icon_Firmware] = old_Icon_Firmware, + [Icon_Language] = old_Icon_Language, + [Icon_Config] = old_Icon_Config, + [Icon_Plugin] = old_Icon_Plugin, + [Icon_Bookmark] = old_Icon_Bookmark, + [Icon_Queued] = 'Q', + [Icon_Moving] = 'M', + + /* + [Icon_Keyboard] = , + [Icon_Font] = , + [Icon_Preset] = , + [Icon_Reverse_Cursor] = , + [Icon_Questionmark] = , + [Icon_Menu_setting] = , + [Icon_Menu_functioncall] = , + [Icon_Submenu] = , + [Icon_Submenu_Entered] = , + [Icon_Recording] = , + [Icon_Voice] = , + [Icon_General_settings_menu] = , + [Icon_System_menu] = , + [Icon_Playback_menu] = , + [Icon_Display_menu] = , + [Icon_Remote_Display_menu] = , + [Icon_Radio_screen] = , + [Icon_file_view_menu] = , + [Icon_EQ] = , + [Icon_Rockbox] = , + */ +}; + +/* as above, but x,y are letter position, NOT PIXEL */ +extern void screen_put_iconxy(struct screen * screen, + int x, int y, enum themable_icons icon) +{ + if ((icon==Icon_NOICON) && (icons[icon]!=0)) + screen->putc(x, y, ' '); + else + screen->putc(x, y, icons[icon]); +} + +void screen_put_cursorxy(struct screen * display, int x, int y, bool on) +{ + screen_put_iconxy(display, x, y, on?Icon_Cursor:-1); + +} + +void load_icons(const char* filename, enum screen_type screen_type) +{ + (void)filename; + (void)screen_type; + /* do something */ +} + +void icons_init(void) +{ +} + + + + + + #endif Index: apps/SOURCES =================================================================== --- apps/SOURCES (revision 13139) +++ apps/SOURCES (working copy) @@ -48,7 +48,9 @@ gui/buttonbar.c gui/gwps.c gui/gwps-common.c +#ifdef HAVE_LCD_BITMAP gui/icon.c +#endif gui/list.c gui/option_select.c gui/quickscreen.c Index: apps/plugin.h =================================================================== --- apps/plugin.h (revision 13139) +++ apps/plugin.h (working copy) @@ -274,7 +274,7 @@ void (*gui_synclist_flash)(struct gui_synclist * lists); unsigned (*gui_synclist_do_button)(struct gui_synclist * lists, unsigned button,enum list_wrap wrap); - void (*gui_synclist_set_title)(struct gui_synclist *lists, char* title, ICON icon); + void (*gui_synclist_set_title)(struct gui_synclist *lists, char* title, int icon); /* button */ long (*button_get)(bool block); Index: apps/filetypes.c =================================================================== --- apps/filetypes.c (revision 13139) +++ apps/filetypes.c (working copy) @@ -22,6 +22,7 @@ #include #include #include "string.h" +#include "atoi.h" #include #include "sprintf.h" @@ -55,7 +56,7 @@ #define ROCK_EXTENSION "rock" struct file_type { - ICON_NO_CONST icon; /* the icon which shall be used for it, NOICON if unknown */ + int icon; /* the icon which shall be used for it, NOICON if unknown */ bool viewer; /* true if the rock is in viewers, false if in rocks */ unsigned char attr; /* FILETYPES_MASK >> 8 */ char* plugin; /* Which plugin to use, NULL if unknown, or builtin */ @@ -73,6 +74,38 @@ } static void read_builtin_types(void); static void read_config(char* config_file); +#ifdef HAVE_LCD_BITMAP +static void read_theme_file(void) +{ + char buffer[MAX_PATH]; + int fd; + char *ext, *icon; + int i; + snprintf(buffer, MAX_PATH, "%s/%s.icons", ICON_DIR, + global_settings.icon_file); + fd = open(buffer, O_RDONLY); + if (fd < 0) + return; + while (read_line(fd, buffer, MAX_PATH) > 0) + { + if (!settings_parseline(buffer, &ext, &icon)) + continue; + for (i=0; i>8; if (filetypes[filetype_count].attr > heighest_attr) heighest_attr = filetypes[filetype_count].attr; - filetypes[filetype_count].icon = -#ifdef HAVE_LCD_BITMAP - (ICON_NO_CONST)&bitmap_icons_6x8[types[i].icon]; -#else - (ICON_NO_CONST)types[i].icon; -#endif + filetypes[filetype_count].icon = types[i].icon; filetype_count++; } } @@ -133,10 +160,6 @@ { char line[64], *s, *e; char extension[8], plugin[32]; -#ifdef HAVE_LCD_BITMAP - char icon[ICON_LENGTH]; - int good_icon; -#endif bool viewer; int fd = open(config_file, O_RDONLY); if (fd < 0) @@ -185,40 +208,13 @@ /* get the icon */ #ifdef HAVE_LCD_BITMAP s = e+1; - good_icon = 1; - if (strlen(s) == 12) - { - int i, j; - char val[2]; - for (i = 0; good_icon && i < ICON_LENGTH; i++) - { - for (j=0; good_icon && j<2; j++) - { - val[j] = tolower(s[i*2+j]); - if (val[j] >= 'a' && val[j] <= 'f') - { - val[j] = val[j] - 'a' + 10; - } - else if (val[j] >= '0' && val[j] <= '9') - { - val[j] = val[j] - '0'; - } - else - good_icon = 0; - } - icon[i]=((val[0]<<4) | val[1]); - } - } - if (good_icon) - { - filetypes[filetype_count].icon = - (ICON_NO_CONST)buffer_alloc(ICON_LENGTH); - memcpy(filetypes[filetype_count].icon, icon, ICON_LENGTH); - } - else - filetypes[filetype_count].icon = NOICON; + if (*s == 'b') + filetypes[filetype_count].icon = atoi(s+1); + else if (*s == '-') + filetypes[filetype_count].icon = Icon_NOICON; + else filetypes[filetype_count].icon = Icon_Last_Themeable + atoi(s); #else - filetypes[filetype_count].icon = Icon_Unknown; + filetypes[filetype_count].icon = Icon_NOICON; #endif filetype_count++; } @@ -254,12 +250,12 @@ return -1; } -ICON filetype_get_icon(int attr) +int filetype_get_icon(int attr) { int index = find_attr(attr); if (index < 0) - return NOICON; - return (ICON)filetypes[index].icon; + return Icon_NOICON; + return filetypes[index].icon; } char* filetype_get_plugin(const struct entry* file) Index: apps/filetypes.h =================================================================== --- apps/filetypes.h (revision 13139) +++ apps/filetypes.h (working copy) @@ -28,7 +28,7 @@ /* Return the attribute (TREE_ATTR_*) of the file */ int filetype_get_attr(const char* file); -ICON filetype_get_icon(int attr); +int filetype_get_icon(int attr); /* return the plugin filename associated with the file */ char* filetype_get_plugin(const struct entry* file); Index: apps/main.c =================================================================== --- apps/main.c (revision 13139) +++ apps/main.c (working copy) @@ -70,6 +70,7 @@ #include "splash.h" #include "eeprom_settings.h" #include "scrobbler.h" +#include "icon.h" #if (CONFIG_CODEC == SWCODEC) #include "playback.h" @@ -267,6 +268,7 @@ sleep(HZ/2); tree_init(); filetype_init(); + icons_init(); playlist_init(); #if CONFIG_CODEC != SWCODEC @@ -501,6 +503,7 @@ playlist_init(); tree_init(); filetype_init(); + icons_init(); scrobbler_init(); cuesheet_init(); Index: apps/tagtree.c =================================================================== --- apps/tagtree.c (revision 13139) +++ apps/tagtree.c (working copy) @@ -1686,20 +1686,12 @@ return attr; } -#ifdef HAVE_LCD_BITMAP -const unsigned char* tagtree_get_icon(struct tree_context* c) -#else -int tagtree_get_icon(struct tree_context* c) -#endif +int tagtree_get_icon(struct tree_context* c) { int icon = Icon_Folder; if (tagtree_get_attr(c) == TREE_ATTR_MPA) icon = Icon_Audio; -#ifdef HAVE_LCD_BITMAP - return bitmap_icons_6x8[icon]; -#else return icon; -#endif }