Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7179 - Standalone checkwps tool

Attached to Project: Rockbox
Opened by Dave Chapman (linuxstb) - Thursday, 17 May 2007, 03:32 GMT+2
Last edited by Dave Chapman (linuxstb) - Tuesday, 29 May 2007, 21:01 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch is a first attempt at a standalone checkwps tool.

Compile it by typing "make checkwps" in the tools/ directory, and then you can use it to parse and debug a WPS using the command "./checkwps filename.wps"

The code itself needs cleaning up before it's suitable for committing (there are too many hacks) but I'm posting the patch to get feedback on the idea and if people think it would be useful and worth committing.
(application/octet-stream)    checkwps.diff (4.3 KiB) 
 tools/checkwps.c      |   90 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tools/Makefile        |    5 ++
 apps/gui/wps_debug.c  |    9 +++--
 apps/gui/wps_parser.c |    5 ++
 4 files changed, 107 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Dave Chapman (linuxstb)
Tuesday, 29 May 2007, 21:01 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as SVN revision 13517
Comment by Dave Chapman (linuxstb) - Thursday, 17 May 2007, 11:52 GMT+2
Version 2 of the patch attached. This is slightly less hacky.
   checkwps-v2.diff (4.9 KiB) 
 tools/checkwps.c      |   91 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tools/Makefile        |    5 ++
 apps/gui/wps_parser.c |   32 +++++++++++++++++
 apps/gui/wps_debug.c  |    8 +++-
 4 files changed, 134 insertions(+), 2 deletions(-)

Comment by Dave Chapman (linuxstb) - Thursday, 17 May 2007, 12:12 GMT+2
Oops, I forgot to include a file in the diff.
   checkwps-v3.diff (5.9 KiB) 
 tools/checkwps.c       |   91 +++++++++++++++++++++++++++++++++++++++++++++++++
 tools/Makefile         |    5 ++
 apps/gui/wps_parser.c  |   32 +++++++++++++++++
 apps/gui/wps_debug.c   |    8 +++-
 apps/gui/gwps-common.c |   26 --------------
 5 files changed, 134 insertions(+), 28 deletions(-)

Comment by Nicolas Pennequin (nicolas_p) - Sunday, 20 May 2007, 23:32 GMT+2
I like it :)
Are you planning on committing it ?

Loading...