Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7247 - Fix buffer size in radio_edit_preset

Attached to Project: Rockbox
Opened by Gerhard Dirschl (gdirschl) - Friday, 01 June 2007, 14:22 GMT+2
Last edited by Peter D'Hoye (petur) - Monday, 04 June 2007, 23:39 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Input buffer is too small by one.
   fix-radio_edit_preset-bufsize.patch (0.4 KiB) 
 rockbox/apps/recorder/radio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Peter D'Hoye (petur)
Monday, 04 June 2007, 23:39 GMT+2
Reason for closing:  Accepted
Comment by Peter D'Hoye (petur) - Saturday, 02 June 2007, 13:22 GMT+2
please give your full real name for the credits

the patch you made isn't 100% according to the CONTRIBUTING doc, namely that it should apply with -p0
it's ok for now, just a note for future patches

Let me know your name asap
Comment by Peter D'Hoye (petur) - Saturday, 02 June 2007, 13:29 GMT+2
fixed patch + added another similar change
   fm2.patch (0.6 KiB) 
 apps/recorder/radio.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment by Gerhard Dirschl (gdirschl) - Sunday, 03 June 2007, 02:02 GMT+2
Thanks for the note. I generate patches that apply with -p1 mostly out of habit, but I'll try to bear that in mind in future.

P.S. I added my real name to my Flyspray account.
Comment by Peter D'Hoye (petur) - Monday, 04 June 2007, 11:54 GMT+2
Great, if nobody does it before me I'll commit this tonight

Loading...