Rockbox

Tasklist

FS#7247 - Fix buffer size in radio_edit_preset

Attached to Project: Rockbox
Opened by Gerhard Dirschl (gdirschl) - Friday, 01 June 2007, 12:22 GMT
Last edited by Peter D'Hoye (petur) - Monday, 04 June 2007, 21:39 GMT
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Input buffer is too small by one.
This task depends upon

Closed by  Peter D'Hoye (petur)
Monday, 04 June 2007, 21:39 GMT
Reason for closing:  Accepted
Comment by Peter D'Hoye (petur) - Saturday, 02 June 2007, 11:22 GMT
please give your full real name for the credits

the patch you made isn't 100% according to the CONTRIBUTING doc, namely that it should apply with -p0
it's ok for now, just a note for future patches

Let me know your name asap
Comment by Peter D'Hoye (petur) - Saturday, 02 June 2007, 11:29 GMT
fixed patch + added another similar change
Comment by Gerhard Dirschl (gdirschl) - Sunday, 03 June 2007, 00:02 GMT
Thanks for the note. I generate patches that apply with -p1 mostly out of habit, but I'll try to bear that in mind in future.

P.S. I added my real name to my Flyspray account.
Comment by Peter D'Hoye (petur) - Monday, 04 June 2007, 09:54 GMT
Great, if nobody does it before me I'll commit this tonight

Loading...