Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7249 - Seperate configuration for use of .talk clips and other voicing methods

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 01 June 2007, 18:34 GMT+2
Last edited by Steve Bavin (pondlife) - Thursday, 07 June 2007, 12:50 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch seperates out the options to use .talk clips, allowing the user a choice of falling back to numbered or spelt files and directories if the .talk clip is not present (or the database is in use).

Without this patch, Rockbox will fall back to using numbers for directories, which doesn't make it easy to use in the database.
   voice_options.patch (10.7 KiB) 
 apps/tree.c                |   59 +++++++++++++++++++++++----------------------
 apps/lang/english.lang     |   32 ++++++++++++++++++++++--
 apps/settings.h            |    6 +++-
 apps/menus/settings_menu.c |   20 +++++++++------
 apps/talk.c                |    4 +--
 apps/settings_list.c       |   14 ++++++----
 6 files changed, 87 insertions(+), 48 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Thursday, 07 June 2007, 12:50 GMT+2
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Monday, 04 June 2007, 08:53 GMT+2
Small update; default settings should not be checking for .talk clips.
   voice_options_070604.patch (10.7 KiB) 
 apps/tree.c                |   59 +++++++++++++++++++++++----------------------
 apps/lang/english.lang     |   32 ++++++++++++++++++++++--
 apps/settings.h            |    6 +++-
 apps/menus/settings_menu.c |   20 +++++++++------
 apps/settings_list.c       |   14 ++++++----
 apps/talk.c                |    4 +--
 6 files changed, 87 insertions(+), 48 deletions(-)

Comment by Steve Bavin (pondlife) - Wednesday, 06 June 2007, 08:56 GMT+2
Here's a patch to update the manual. I've not managed to even build this; perhaps a kindly soul could check it for me (and see if they can simplify the wording perhaps).
   voice_options_manual.patch (2.6 KiB) 
 manual/configure_rockbox/voice.tex |   34 ++++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

Comment by Marianne Arnold (pixelma) - Thursday, 07 June 2007, 12:18 GMT+2
I attached a new manual patch because the old one didn't work - the new nested \begin{desciption} tags were missing the end defines.
   voice_options_manual2.diff (2.7 KiB) 
 manual/configure_rockbox/voice.tex |   38 ++++++++++++++++++++++++++-----------
 1 file changed, 27 insertions(+), 11 deletions(-)

Loading...