Rockbox

Tasklist

FS#7251 - Remove unused struct members from the mp3entry struct and rearrange structs to save codesize.

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Friday, 01 June 2007, 21:07 GMT
Last edited by Nils Wallménius (nls) - Thursday, 25 October 2007, 21:50 GMT
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This is a reworked version of the changes committed in revision 13527 which were later reverted because of a negative impact on binary size.

In this version I have rearranged the mp3entry struct and the track_info struct (in which the mp3entry struct is a member) this patch now decreases binary size.

Recorder v1 -256 bytes
iriver H300 -48 bytes
ipod video +4 bytes

I also bumped the codec api version as Lear pointed out that changes to these structs could break the api compatiblity. I added info about this to comments before each struct.
This task depends upon

Closed by  Nils Wallménius (nls)
Thursday, 25 October 2007, 21:50 GMT
Reason for closing:  Accepted
Additional comments about closing:  comitted relevant stuff no reordering
Comment by Nils Wallménius (nls) - Friday, 01 June 2007, 21:53 GMT
Bumped plugin api too, and adjusted comments. Thanks to linuxstb for pointing that out.

Loading...